fix backward

Author: gkorland

NRedisTimeSeries/DataTypes/TimeSeriesInformation.cs

@@ -42,10 +42,11 @@ public class TimeSeriesInformation
         /// <summary>
         /// Maximum Number of samples per Memory Chunk.
         /// </summary>
+        [ObsoleteAttribute("This method has been deprecated. Use ChunkSize instead.")] 
         public long MaxSamplesPerChunk { get; private set; }
 
         /// <summary>
-        /// Chunk size in bytes.
+        /// Memory Chunk size in Bytes. 
         /// </summary>
         public long ChunkSize { get; private set; }
 
@@ -63,22 +64,20 @@ public class TimeSeriesInformation
         /// A readonly list of TimeSeriesRules that represent compaction Rules of the time-series.
         /// </summary>
         public IReadOnlyList<TimeSeriesRule> Rules { get; private set; }
-
-        internal TimeSeriesInformation(long totalSamples, long memoryUsage, TimeStamp firstTimeStamp,
-        TimeStamp lastTimeStamp, long retentionTime, long chunkCount, long maxSamplesPerChunk,
-        long chunkSize, IReadOnlyList<TimeSeriesLabel> labels, string sourceKey, IReadOnlyList<TimeSeriesRule> rules)
+        internal TimeSeriesInformation(long totalSamples, long memoryUsage, TimeStamp firstTimeStamp, TimeStamp lastTimeStamp, long retentionTime, long chunkCount, long chunkSize, IReadOnlyList<TimeSeriesLabel> labels, string sourceKey, IReadOnlyList<TimeSeriesRule> rules)
         {
             TotalSamples = totalSamples;
             MemoryUsage = memoryUsage;
             FirstTimeStamp = firstTimeStamp;
             LastTimeStamp = lastTimeStamp;
             RetentionTime = retentionTime;
             ChunkCount = chunkCount;
-            MaxSamplesPerChunk = maxSamplesPerChunk;
-            ChunkSize = chunkSize;
             Labels = labels;
             SourceKey = sourceKey;
             Rules = rules;
+            // backwards compatible with RedisTimeSeries < v1.4
+            MaxSamplesPerChunk = chunkSize/16;
+            ChunkSize = chunkSize;
         }
     }
 }

NRedisTimeSeries/TimeSeriesClientResponseParser.cs

@@ -135,7 +135,9 @@ private static TimeSeriesInformation ParseInfo(RedisResult result)
                         chunkSize = (long)redisResults[i];
                         break;
                     case "maxSamplesPerChunk":
-                        maxSamplesPerChunk = (long)redisResults[i];
+                        // If the property name is maxSamplesPerChunk then this is an old
+                        // version of RedisTimeSeries and we used the number of samples before ( now Bytes )
+                        chunkSize = chunkSize * 16;
                         break;
                     case "firstTimestamp":
                         firstTimestamp = ParseTimeStamp(redisResults[i]);
@@ -155,7 +157,7 @@ private static TimeSeriesInformation ParseInfo(RedisResult result)
                 }
             }
             return new TimeSeriesInformation(totalSamples, memoryUsage, firstTimestamp,
-            lastTimestamp, retentionTime, chunkCount, maxSamplesPerChunk, chunkSize, labels, sourceKey, rules);
+            lastTimestamp, retentionTime, chunkCount, chunkSize, labels, sourceKey, rules);
         }
 
         private static IReadOnlyList<string> ParseStringArray(RedisResult result)