Skip to content

Commit b05b45d

Browse files
author
DvirDukhan
authored
Merge pull request #36 from shaunsales/feature/aggregation
Implemented new aggregation type.
2 parents 5b4ac9b + e84b2f5 commit b05b45d

25 files changed

+166
-177
lines changed

NRedisTimeSeries.Example/MRangeExample.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ internal class MRangeExample
1717
/// In this case, the strings are implicitly casted into TimeStamp objects.
1818
/// The TimeSeriesMRange command returns an IReadOnlyList<(string key, IReadOnlyList<TimeSeriesLabel> labels, IReadOnlyList<TimeSeriesTuple> values)>collection.
1919
/// </summary>
20-
public static void BasicMRangeExample()
20+
public static void BasicMRangeExample()
2121
{
2222
ConnectionMultiplexer redis = ConnectionMultiplexer.Connect("localhost");
2323
IDatabase db = redis.GetDatabase();
@@ -43,7 +43,7 @@ public static void CountMRangeExample()
4343
ConnectionMultiplexer redis = ConnectionMultiplexer.Connect("localhost");
4444
IDatabase db = redis.GetDatabase();
4545
var filter = new List<string> { "MRANGEkey=MRANGEvalue" };
46-
var results = db.TimeSeriesMRange("-", "+", filter, count:50);
46+
var results = db.TimeSeriesMRange("-", "+", filter, count: 50);
4747
// Values extraction example. No lables in this case.
4848
foreach (var result in results)
4949
{
@@ -64,7 +64,7 @@ public static void MRangeAggregationExample()
6464
ConnectionMultiplexer redis = ConnectionMultiplexer.Connect("localhost");
6565
IDatabase db = redis.GetDatabase();
6666
var filter = new List<string> { "MRANGEkey=MRANGEvalue" };
67-
var results = db.TimeSeriesMRange("-", "+", filter, aggregation:Aggregation.MIN, timeBucket:50);
67+
var results = db.TimeSeriesMRange("-", "+", filter, aggregation: TsAggregation.Min, timeBucket: 50);
6868
// Values extraction example. No lables in this case.
6969
foreach (var result in results)
7070
{
@@ -85,7 +85,7 @@ public static void MRangeWithLabelsExample()
8585
ConnectionMultiplexer redis = ConnectionMultiplexer.Connect("localhost");
8686
IDatabase db = redis.GetDatabase();
8787
var filter = new List<string> { "MRANGEkey=MRANGEvalue" };
88-
var results = db.TimeSeriesMRange("-", "+", filter,withLabels:true);
88+
var results = db.TimeSeriesMRange("-", "+", filter, withLabels: true);
8989
// Values extraction example.
9090
foreach (var result in results)
9191
{

NRedisTimeSeries.Example/MRangeExampleAsync.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ public static async Task MRangeAggregationAsyncExample()
6464
ConnectionMultiplexer redis = ConnectionMultiplexer.Connect("localhost");
6565
IDatabase db = redis.GetDatabase();
6666
var filter = new List<string> { "MRANGEkey=MRANGEvalue" };
67-
var results = await db.TimeSeriesMRangeAsync("-", "+", filter, aggregation: Aggregation.MIN, timeBucket: 50);
67+
var results = await db.TimeSeriesMRangeAsync("-", "+", filter, aggregation: TsAggregation.Min, timeBucket: 50);
6868
// Values extraction example. No lables in this case.
6969
foreach (var result in results)
7070
{

NRedisTimeSeries.Example/RangeExample.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public static void RangeAggregationExample()
4949
{
5050
ConnectionMultiplexer redis = ConnectionMultiplexer.Connect("localhost");
5151
IDatabase db = redis.GetDatabase();
52-
db.TimeSeriesRange("my_ts", "-", "+", aggregation: Aggregation.MIN, timeBucket: 50);
52+
db.TimeSeriesRange("my_ts", "-", "+", aggregation: TsAggregation.Min, timeBucket: 50);
5353
redis.Close();
5454
}
5555
}

NRedisTimeSeries.Example/RangeExampleAsync.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public static async Task RangeAggregationAsyncExample()
4949
{
5050
ConnectionMultiplexer redis = ConnectionMultiplexer.Connect("localhost");
5151
IDatabase db = redis.GetDatabase();
52-
await db.TimeSeriesRangeAsync("my_ts", "-", "+", aggregation: Aggregation.MIN, timeBucket: 50);
52+
await db.TimeSeriesRangeAsync("my_ts", "-", "+", aggregation: TsAggregation.Min, timeBucket: 50);
5353
redis.Close();
5454
}
5555
}

NRedisTimeSeries.Example/RulesExample.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ public static void RulesCreateDeleteExample()
1818
ConnectionMultiplexer redis = ConnectionMultiplexer.Connect("localhost");
1919
IDatabase db = redis.GetDatabase();
2020
// Create you rule with destination key, time bucket and aggregation type.
21-
TimeSeriesRule rule = new TimeSeriesRule("dest_ts", 50, Aggregation.AVG);
21+
TimeSeriesRule rule = new TimeSeriesRule("dest_ts", 50, TsAggregation.Avg);
2222
db.TimeSeriesCreateRule("my_ts", rule);
2323
db.TimeSeriesDeleteRule("my_ts", "dest");
2424
redis.Close();

NRedisTimeSeries.Example/RulesExampleAsync.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ public static async Task RulesCreateDeleteAsyncExample()
1818
ConnectionMultiplexer redis = ConnectionMultiplexer.Connect("localhost");
1919
IDatabase db = redis.GetDatabase();
2020
// Create your rule with destination key, time bucket and aggregation type.
21-
TimeSeriesRule rule = new TimeSeriesRule("dest_ts", 50, Aggregation.AVG);
21+
TimeSeriesRule rule = new TimeSeriesRule("dest_ts", 50, TsAggregation.Avg);
2222
await db.TimeSeriesCreateRuleAsync("my_ts", rule);
2323
await db.TimeSeriesDeleteRuleAsync("my_ts", "dest");
2424
redis.Close();

NRedisTimeSeries.Test/TestAPI/TestMRange.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ public void TestMRangeAggregation()
133133
}
134134

135135
var tuples = CreateData(db, 50);
136-
var results = db.TimeSeriesMRange("-", "+", new List<string> { "key=MRangeAggregation" }, aggregation: Aggregation.MIN, timeBucket: 50);
136+
var results = db.TimeSeriesMRange("-", "+", new List<string> { "key=MRangeAggregation" }, aggregation: TsAggregation.Min, timeBucket: 50);
137137
Assert.Equal(keys.Length, results.Count);
138138
for (int i = 0; i < results.Count; i++)
139139
{
@@ -171,7 +171,7 @@ public void TestMissingTimeBucket()
171171
}
172172

173173
var tuples = CreateData(db, 50);
174-
var ex = Assert.Throws<ArgumentException>(() => db.TimeSeriesMRange("-", "+", new List<string> { "key=MissingTimeBucket" }, aggregation: Aggregation.AVG));
174+
var ex = Assert.Throws<ArgumentException>(() => db.TimeSeriesMRange("-", "+", new List<string> { "key=MissingTimeBucket" }, aggregation: TsAggregation.Avg));
175175
Assert.Equal("RANGE Aggregation should have timeBucket value", ex.Message);
176176

177177
}

NRedisTimeSeries.Test/TestAPI/TestMRangeAsync.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ public async Task TestMRangeAggregation()
128128
}
129129

130130
var tuples = await CreateData(db, keys, 50);
131-
var results = await db.TimeSeriesMRangeAsync("-", "+", new List<string> { $"{keys[0]}=value" }, aggregation: Aggregation.MIN, timeBucket: 50);
131+
var results = await db.TimeSeriesMRangeAsync("-", "+", new List<string> { $"{keys[0]}=value" }, aggregation: TsAggregation.Min, timeBucket: 50);
132132
Assert.Equal(keys.Length, results.Count);
133133
for (var i = 0; i < results.Count; i++)
134134
{
@@ -172,7 +172,7 @@ public async Task TestMissingTimeBucket()
172172
{
173173
await db.TimeSeriesMRangeAsync("-", "+",
174174
filter: new List<string>() { $"key=value" },
175-
aggregation: Aggregation.AVG);
175+
aggregation: TsAggregation.Avg);
176176
});
177177
Assert.Equal("RANGE Aggregation should have timeBucket value", ex.Message);
178178
}

NRedisTimeSeries.Test/TestAPI/TestMRevRange.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ public void TestMRevRangeAggregation()
128128
}
129129

130130
var tuples = CreateData(db, keys, 50);
131-
var results = db.TimeSeriesMRevRange("-", "+", new List<string> { $"{keys[0]}=value" }, aggregation: Aggregation.MIN, timeBucket: 50);
131+
var results = db.TimeSeriesMRevRange("-", "+", new List<string> { $"{keys[0]}=value" }, aggregation: TsAggregation.Min, timeBucket: 50);
132132
Assert.Equal(keys.Length, results.Count);
133133
for (var i = 0; i < results.Count; i++)
134134
{
@@ -168,7 +168,7 @@ public void TestMissingTimeBucket()
168168
}
169169

170170
var tuples = CreateData(db, keys, 50);
171-
var ex = Assert.Throws<ArgumentException>(() => db.TimeSeriesMRevRange("-", "+", new List<string> { "key=MissingTimeBucket" }, aggregation: Aggregation.AVG));
171+
var ex = Assert.Throws<ArgumentException>(() => db.TimeSeriesMRevRange("-", "+", new List<string> { "key=MissingTimeBucket" }, aggregation: TsAggregation.Avg));
172172
Assert.Equal("RANGE Aggregation should have timeBucket value", ex.Message);
173173

174174
}

NRedisTimeSeries.Test/TestAPI/TestMRevRangeAsync.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ public async Task TestMRangeAggregation()
128128
}
129129

130130
var tuples = await CreateData(db, keys, 50);
131-
var results = await db.TimeSeriesMRevRangeAsync("-", "+", new List<string> { $"{keys[0]}=value" }, aggregation: Aggregation.MIN, timeBucket: 50);
131+
var results = await db.TimeSeriesMRevRangeAsync("-", "+", new List<string> { $"{keys[0]}=value" }, aggregation: TsAggregation.Min, timeBucket: 50);
132132
Assert.Equal(keys.Length, results.Count);
133133
for (var i = 0; i < results.Count; i++)
134134
{
@@ -172,7 +172,7 @@ public async Task TestMissingTimeBucket()
172172
{
173173
await db.TimeSeriesMRevRangeAsync("-", "+",
174174
filter: new List<string>() { $"key=value" },
175-
aggregation: Aggregation.AVG);
175+
aggregation: TsAggregation.Avg);
176176
});
177177
Assert.Equal("RANGE Aggregation should have timeBucket value", ex.Message);
178178
}

0 commit comments

Comments
 (0)