Skip to content

[Documentation] Wrong description of array A in LAPACK ?tfsm routines #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sergey-v-kuznetsov opened this issue Aug 9, 2024 · 2 comments

Comments

@sergey-v-kuznetsov
Copy link
Contributor

Description
One of OneMKL customer failed to use DTFSM solver ( a triangular solver where one operand is a triangular matrix in RFP format) . The problem was reported on OneMKL forum:
https://community.intel.com/t5/Intel-oneAPI-Math-Kernel-Library/The-LAPACKE-dtfsm-function/m-p/1579919

Further investigation showed that the problem appears because of bugs in LAPACKE interfaces for this solver but the description of array A in Reference LAPACK ?dtfsm is also wrong.

So the current description of A (https://www.netlib.org/lapack/explore-html/dd/d79/group__tfsm_ga8f8cf589889048a6ab91d2d4f8653aac.html)
is the following
"A [in]
A is DOUBLE PRECISION array, dimension (NT)
NT = N*(N+1)/2. On entry, the matrix A in RFP Format. "

But debugging and comments in the file (see the comments on lines

361 IF( LSIDE ) THEN
362 *
363 * SIDE = 'L'
364 *
365 * A is M-by-M.
366 * If M is odd, set NISODD = .TRUE., and M1 and M2.
367 * If M is even, NISODD = .FALSE., and M. ")

in dtfsm.f shows that the size of A in the case side='L' must be NT = M*(M+1)/2

So the correct description of A must be the following:
"A [in]
A is DOUBLE PRECISION array, dimension (NT)
NT = N*(N+1)/2 if SIDE='R' and NT = M*(M+1)/2 otherwise . On entry, the matrix A in RFP Format. "

Checklist

  • [ x ] I'd be willing to make a PR to solve the LAPACKE issues reported on OneMKL forum
@langou
Copy link
Contributor

langou commented Aug 9, 2024

It's great to hear that RFP format is being used! A PR to solve the issue would be more than welcomed.

@sergey-v-kuznetsov
Copy link
Contributor Author

The issue was fixed in the PR #1042

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants