Fix PHPCS errors

Author: bdsl

src/CompareClasses.php

@@ -8,9 +8,9 @@
 use Psl\Regex;
 use Psl\Str;
 use Roave\BackwardCompatibility\DetectChanges\BCBreak\ClassBased\ClassBased;
+use Roave\BackwardCompatibility\DetectChanges\BCBreak\EnumBased\EnumBased;
 use Roave\BackwardCompatibility\DetectChanges\BCBreak\InterfaceBased\InterfaceBased;
 use Roave\BackwardCompatibility\DetectChanges\BCBreak\TraitBased\TraitBased;
-use Roave\BackwardCompatibility\DetectChanges\BCBreak\EnumBased\EnumBased;
 use Roave\BetterReflection\Reflection\ReflectionClass;
 use Roave\BetterReflection\Reflector\Exception\IdentifierNotFound;
 use Roave\BetterReflection\Reflector\Reflector;

src/DetectChanges/BCBreak/EnumBased/CasesChanged.php

@@ -11,6 +11,10 @@
 use Roave\BetterReflection\Reflection\ReflectionEnum;
 use Roave\BetterReflection\Reflection\ReflectionEnumCase;
 
+use function array_filter;
+use function array_map;
+use function array_values;
+
 class CasesChanged implements EnumBased
 {
     public function __invoke(ReflectionClass $fromEnum, ReflectionClass $toEnum): Changes
@@ -32,12 +36,8 @@ static function (ReflectionEnumCase $case) use ($fromEnum): bool {
                     return false;
                 }
 
-                if ($fromEnum->hasCase($case->getName())) {
-                    return false;
-                }
-
-                return true;
-            }
+                return ! $fromEnum->hasCase($case->getName());
+            },
         );
 
         $removedCases = array_filter(
@@ -47,24 +47,26 @@ static function (ReflectionEnumCase $case) use ($toEnum): bool {
                     return false;
                 }
 
-                return !$toEnum->hasCase($case->getName());
-            }
+                return ! $toEnum->hasCase($case->getName());
+            },
         );
 
-        $caseRemovedChanges = array_values(array_map(function (ReflectionEnumCase $case) use ($fromEnumName): Change {
-            $caseName = $case->getName();
+        $caseRemovedChanges = array_values(array_map(
+            static function (ReflectionEnumCase $case) use ($fromEnumName): Change {
+                $caseName = $case->getName();
 
-            return Change::removed("Case {$fromEnumName}::{$caseName} was removed");
-        },
-            $removedCases
+                return Change::removed('Case ' . $fromEnumName . '::' . $caseName . ' was removed');
+            },
+            $removedCases,
         ));
 
-        $caseAddedChanges = array_values(array_map(function (ReflectionEnumCase $case) use ($fromEnumName): Change {
-            $caseName = $case->getName();
+        $caseAddedChanges = array_values(array_map(
+            static function (ReflectionEnumCase $case) use ($fromEnumName): Change {
+                $caseName = $case->getName();
 
-            return Change::added("Case {$fromEnumName}::{$caseName} was added");
+                return Change::added('Case ' . $fromEnumName . '::' . $caseName . ' was added');
             },
-            $addedCases
+            $addedCases,
         ));
 
         return Changes::fromList(...$caseRemovedChanges, ...$caseAddedChanges);
@@ -79,4 +81,4 @@ private static function isInternalDocComment(string|null $comment): bool
         return $comment !== null
             && Regex\matches($comment, '/\s+@internal\s+/');
     }
-};
+}

src/DetectChanges/BCBreak/EnumBased/EnumBased.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Roave\BackwardCompatibility\DetectChanges\BCBreak\EnumBased;
 
 use Roave\BackwardCompatibility\Changes;
@@ -8,4 +10,4 @@
 interface EnumBased
 {
     public function __invoke(ReflectionClass $fromInterface, ReflectionClass $toInterface): Changes;
-}
+}

test/unit/CompareClassesTest.php

@@ -45,7 +45,7 @@ protected function setUp(): void
         $this->classBasedComparison     = $this->createMock(ClassBased::class);
         $this->interfaceBasedComparison = $this->createMock(InterfaceBased::class);
         $this->traitBasedComparison     = $this->createMock(TraitBased::class);
-        $this->enumBasedComparison     = $this->createMock(EnumBased::class);
+        $this->enumBasedComparison      = $this->createMock(EnumBased::class);
         $this->compareClasses           = new CompareClasses(
             $this->classBasedComparison,
             $this->interfaceBasedComparison,

test/unit/DetectChanges/BCBreak/EnumBased/EnumCaseAddedTest.php

@@ -12,6 +12,9 @@
 use Roave\BetterReflection\Reflector\DefaultReflector;
 use Roave\BetterReflection\SourceLocator\Type\SingleFileSourceLocator;
 
+use function array_map;
+use function iterator_to_array;
+
 /** @covers \Roave\BackwardCompatibility\DetectChanges\BCBreak\EnumBased\CasesChanged */
 final class EnumCaseAddedTest extends TestCase
 {
@@ -23,9 +26,8 @@ final class EnumCaseAddedTest extends TestCase
     public function testDiffs(
         ReflectionClass $fromEnum,
         ReflectionClass $toEnum,
-        array           $expectedMessages,
-    ): void
-    {
+        array $expectedMessages,
+    ): void {
         $changes = (new CasesChanged())($fromEnum, $toEnum);
 
         self::assertSame(
@@ -40,7 +42,7 @@ public function testDiffs(
      * @return array<string, array<int, ReflectionClass|array<int, string>>>
      * @psalm-return array<string, array{0: ReflectionClass, 1: ReflectionClass, 2: list<string>}>
      */
-    public function enumsToBeTested()
+    public function enumsToBeTested(): array
     {
         $locator = (new BetterReflection())->astLocator();