#767: Improve test coverage

Author: bdsl

src/DetectChanges/BCBreak/EnumBased/CasesChanged.php

@@ -13,7 +13,6 @@
 
 use function array_filter;
 use function array_map;
-use function array_values;
 
 class CasesChanged implements EnumBased
 {

test/unit/DetectChanges/BCBreak/EnumBased/DummyEnum.php

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+namespace RoaveTest\BackwardCompatibility\DetectChanges\BCBreak\EnumBased;
+
+enum DummyEnum
+{
+    case someCase;
+}

test/unit/DetectChanges/BCBreak/EnumBased/EnumCaseAddedTest.php renamed to test/unit/DetectChanges/BCBreak/EnumBased/EnumCasesChangedTest.php

@@ -11,12 +11,13 @@
 use Roave\BetterReflection\Reflection\ReflectionClass;
 use Roave\BetterReflection\Reflector\DefaultReflector;
 use Roave\BetterReflection\SourceLocator\Type\SingleFileSourceLocator;
+use stdClass;
 
 use function array_map;
 use function iterator_to_array;
 
 /** @covers \Roave\BackwardCompatibility\DetectChanges\BCBreak\EnumBased\CasesChanged */
-final class EnumCaseAddedTest extends TestCase
+final class EnumCasesChangedTest extends TestCase
 {
     /**
      * @param string[] $expectedMessages
@@ -38,6 +39,32 @@ public function testDiffs(
         );
     }
 
+    public function testReturnsNoChangesIfOldEnumIsNotEnum(): void
+    {
+        // EnumCasesChanged should not be called when the old symbol is not an Enum. If it does it will
+        // just return an empty list.
+
+        $changes = (new CasesChanged())(
+            ReflectionClass::createFromName(stdClass::class),
+            ReflectionClass::createFromName(DummyEnum::class),
+        );
+
+        $this->assertSame(0, $changes->count());
+    }
+
+    public function testReturnsNoChangesIfNewEnumIsNotEnum(): void
+    {
+        // EnumCasesChanged should not be called when the old symbol is not an Enum. If it does it will
+        // just return an empty list.
+
+        $changes = (new CasesChanged())(
+            ReflectionClass::createFromName(DummyEnum::class),
+            ReflectionClass::createFromName(stdClass::class),
+        );
+
+        $this->assertSame(0, $changes->count());
+    }
+
     /**
      * @return array<string, array<int, ReflectionClass|array<int, string>>>
      * @psalm-return array<string, array{0: ReflectionClass, 1: ReflectionClass, 2: list<string>}>