Skip to content

Commit 5ff1c98

Browse files
RonnyPfannschmidtWintreistclaude
committed
doc: credit Wintreist and document the preserved composition order
The regression test for pytest-dev#14329 is Wintreist's, taken verbatim from pytest-dev#14332; carry the attribution and add them to AUTHORS. Also spell out in the changelog what does *not* change: `own_markers` keeps its base-first order, and so do the consumers that compose markers rather than look one up. `usefixtures` requests its fixtures in the same order as before, and an inherited class level `parametrize` composes the same test IDs as before -- no pinned ID selection and no `--last-failed` cache is invalidated by this fix. Co-authored-by: Wintreist <49996562+Wintreist@users.noreply.github.com> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent 81a845d commit 5ff1c98

2 files changed

Lines changed: 6 additions & 5 deletions

File tree

AUTHORS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -523,6 +523,7 @@ Wil Cooley
523523
Will Riley
524524
William Lee
525525
Wim Glenn
526+
Wintreist
526527
Wouter van Ackooy
527528
Xixi Zhao
528529
Xuan Luong

changelog/14329.bugfix.rst

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
now walk the class MRO closest-first, so a marker on a subclass takes precedence over the
33
same marker on one of its base classes.
44

5-
``own_markers`` keeps its previous (base class first) order.
6-
7-
As a consequence, :ref:`usefixtures <usefixtures>` markers are now iterated in reverse, which
8-
keeps base class fixtures being requested before subclass ones, and additionally makes stacked
9-
``usefixtures`` markers on a single node request their fixtures in source order.
5+
``own_markers`` keeps its previous (base class first) order, and so do the consumers that
6+
compose markers rather than look one up: :ref:`usefixtures <usefixtures>` fixtures are still
7+
requested in the same order as before, and inherited class level
8+
:ref:`parametrize <pytest.mark.parametrize ref>` markers still compose their test IDs the
9+
same way.

0 commit comments

Comments
 (0)