fix cargo clippy

Author: Firestar99

.cargo/config.toml

@@ -40,7 +40,7 @@ rustflags = [
     "-Wclippy::map_err_ignore",
     "-Wclippy::map_flatten",
     "-Wclippy::map_unwrap_or",
-    "-Wclippy::match_on_vec_items",
+    "-Wclippy::indexing_slicing",
     "-Wclippy::match_same_arms",
     "-Wclippy::match_wild_err_arm",
     "-Wclippy::match_wildcard_for_single_variants",

src/assembler/compiled.rs

@@ -92,7 +92,7 @@ impl Assembler for CompiledAssembler {
                     .map_err(|e| crate::error::Error {
                         inner: shared::SpirvResult::InvalidText,
                         diagnostic: Some(
-                            format!("spirv disassemble returned non-utf8 text: {}", e).into(),
+                            format!("spirv disassemble returned non-utf8 text: {e}").into(),
                         ),
                     });
 

src/assembler/tool.rs

@@ -65,7 +65,7 @@ impl Assembler for ToolAssembler {
         String::from_utf8(cmd_output.binary)
             .map_err(|e| crate::error::Error {
                 inner: spirv_tools_sys::shared::SpirvResult::InvalidText,
-                diagnostic: Some(format!("spirv disassemble returned non-utf8 text: {}", e).into()),
+                diagnostic: Some(format!("spirv disassemble returned non-utf8 text: {e}").into()),
             })
             .map(|s| if s.is_empty() { None } else { Some(s) })
     }

src/cmd.rs

@@ -179,7 +179,10 @@ pub fn exec(
                     return None;
                 }
                 let (ret, remaining) = match memchr::memchr(self.needle, self.haystack) {
-                    Some(pos) => (&self.haystack[..pos], &self.haystack[pos + 1..]),
+                    Some(pos) => (
+                        self.haystack.get(..pos).unwrap(),
+                        self.haystack.get(pos + 1..).unwrap(),
+                    ),
                     None => (self.haystack, &[][..]),
                 };
                 self.haystack = remaining;

src/opt/tool.rs

@@ -37,7 +37,7 @@ impl Optimizer for ToolOptimizer {
         cmd.args(
             self.passes
                 .iter()
-                .filter_map(|p| pass_to_string(*p).map(|s| format!("--{}", s))),
+                .filter_map(|p| pass_to_string(*p).map(|s| format!("--{s}"))),
         );
 
         if self.use_perf_passes {
@@ -54,7 +54,7 @@ impl Optimizer for ToolOptimizer {
 
         if let Some(opts) = options {
             if let Some(max_id_bound) = opts.max_id_bound {
-                cmd.arg(format!("--max-id-bound={}", max_id_bound));
+                cmd.arg(format!("--max-id-bound={max_id_bound}"));
             }
 
             if opts.preserve_bindings {

tests/issue_22.rs

@@ -34,7 +34,7 @@ fn issue() {
         .optimize(
             &assembled,
             &mut |msg| {
-                eprintln!("[tool] optimizer message: {:#?}", msg);
+                eprintln!("[tool] optimizer message: {msg:#?}");
             },
             None,
         )
@@ -44,7 +44,7 @@ fn issue() {
         .optimize(
             &assembled,
             &mut |msg| {
-                eprintln!("[compiled] optimizer message: {:#?}", msg);
+                eprintln!("[compiled] optimizer message: {msg:#?}");
             },
             None,
         )

tests/optimizer.rs

@@ -25,7 +25,7 @@ fn compiled_matches_binary() {
         .optimize(
             &assembled,
             &mut |msg| {
-                eprintln!("[tool] optimizer message: {:#?}", msg);
+                eprintln!("[tool] optimizer message: {msg:#?}");
             },
             None,
         )
@@ -35,7 +35,7 @@ fn compiled_matches_binary() {
         .optimize(
             &assembled,
             &mut |msg| {
-                eprintln!("[compiled] optimizer message: {:#?}", msg);
+                eprintln!("[compiled] optimizer message: {msg:#?}");
             },
             None,
         )