Skip to content

Commit 7e4c6b9

Browse files
committed
nvme/pci: Fix read queue count
If nvme.write_queues equals the number of CPUs, the driver had decreased the number of interrupts available such that there could only be one read queue even if the controller could support more. Remove the interrupt count reduction in this case. The driver wouldn't request more IRQs than it wants queues anyway. Reviewed-by: Jens Axboe <[email protected]> Signed-off-by: Keith Busch <[email protected]>
1 parent 17c3316 commit 7e4c6b9

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

drivers/nvme/host/pci.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2054,7 +2054,6 @@ static int nvme_setup_irqs(struct nvme_dev *dev, unsigned int nr_io_queues)
20542054
.priv = dev,
20552055
};
20562056
unsigned int irq_queues, this_p_queues;
2057-
unsigned int nr_cpus = num_possible_cpus();
20582057

20592058
/*
20602059
* Poll queues don't need interrupts, but we need at least one IO
@@ -2065,10 +2064,7 @@ static int nvme_setup_irqs(struct nvme_dev *dev, unsigned int nr_io_queues)
20652064
this_p_queues = nr_io_queues - 1;
20662065
irq_queues = 1;
20672066
} else {
2068-
if (nr_cpus < nr_io_queues - this_p_queues)
2069-
irq_queues = nr_cpus + 1;
2070-
else
2071-
irq_queues = nr_io_queues - this_p_queues + 1;
2067+
irq_queues = nr_io_queues - this_p_queues + 1;
20722068
}
20732069
dev->io_queues[HCTX_TYPE_POLL] = this_p_queues;
20742070

0 commit comments

Comments
 (0)