Skip to content

Get rid of build warnings in luigi #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hardl opened this issue Sep 19, 2018 · 2 comments
Closed

Get rid of build warnings in luigi #95

hardl opened this issue Sep 19, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@hardl
Copy link
Contributor

hardl commented Sep 19, 2018 •
edited by kwiatekus
Loading

when execute npm run bundle in luigi/core the console is polluted by a lot of warning logs. Either fix warnings or change log level.
@hardl hardl added this to the Sprint_Swinka_1 milestone Sep 19, 2018
@hardl hardl added area/luigi enhancement New feature or request labels Sep 19, 2018
@kwiatekus
Copy link
Contributor

Related : sveltejs/svelte#1594

@dariadomagala-sap dariadomagala-sap self-assigned this Oct 1, 2018
@dariadomagala-sap
Copy link
Contributor

In core we are importing css files from fundamental-ui, and because of that we have lots of unused css selectors. Those additional selectors cause warnings and for now there is no way to remove all of them.
I was able to reduce the number of warnings from >1500 to <70 by removing unnecessary imports. The remaining warnings are still there but they are not displayed during the build anymore.

@kwiatekus kwiatekus modified the milestones: Sprint_Swinka_1, Sprint_Swinka_2 Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kwiatekus @hardl @dariadomagala-sap