♻️ Refactor properties to use auto-implemented getters and private setters

Author: danielmackay

Directory.Build.props

@@ -17,8 +17,5 @@
         <!-- Disable "must have curly braces for if/else" -->
         <NoWarn>$(NoWarn);IDE0011</NoWarn>
 
-      <!-- Disable "auto property warning" TODO: Remove after fields are introduced -->
-      <NoWarn>$(NoWarn);IDE0032</NoWarn>
-
     </PropertyGroup>
 </Project>

src/Domain/Common/Base/Auditable.cs

@@ -9,32 +9,30 @@ public abstract class Auditable : IAuditable
     public const int UpdatedByMaxLength = 128;
 
     private const string SystemUser = "System";
-    private string _createdBy = null!;
-    private string? _updatedBy;
 
     public DateTimeOffset CreatedAt { get; private set; }
 
     public string CreatedBy
     {
-        get => _createdBy;
+        get;
         private set
         {
             ThrowIfNullOrWhiteSpace(value, nameof(CreatedBy));
             ThrowIfGreaterThan(value.Length, CreatedByMaxLength, nameof(CreatedBy));
-            _createdBy = value;
+            field = value;
         }
-    }
+    } = null!;
 
     public DateTimeOffset? UpdatedAt { get; private set; }
 
     public string? UpdatedBy
     {
-        get => _updatedBy;
+        get;
         private set
         {
             ThrowIfNullOrWhiteSpace(value, nameof(UpdatedBy));
             ThrowIfGreaterThan(value.Length, UpdatedByMaxLength, nameof(UpdatedBy));
-            _updatedBy = value;
+            field = value;
         }
     }
 

src/Domain/Heroes/Hero.cs

@@ -13,30 +13,27 @@ public class Hero : AggregateRoot<HeroId>
 
     private readonly List<Power> _powers = [];
 
-    private string _name = null!;
-    private string _alias = null!;
-
     public string Name
     {
-        get => _name;
+        get;
         set
         {
             ThrowIfNullOrWhiteSpace(value, nameof(Name));
             ThrowIfGreaterThan(value.Length, NameMaxLength, nameof(Name));
-            _name = value;
+            field = value;
         }
-    }
+    } = null!;
 
     public string Alias
     {
-        get => _alias;
+        get;
         set
         {
             ThrowIfNullOrWhiteSpace(value, nameof(Alias));
             ThrowIfGreaterThan(value.Length, AliasMaxLength, nameof(Alias));
-            _alias = value;
+            field = value;
         }
-    }
+    } = null!;
 
     public int PowerLevel { get; private set; }
     public TeamId? TeamId { get; private set; }

src/Domain/Heroes/Power.cs

@@ -4,30 +4,27 @@ public record Power : IValueObject
 {
     public const int NameMaxLength = 50;
 
-    private string _name = null!;
-    private int _powerLevel;
-
     // Private setters needed for EF
     public string Name
     {
-        get => _name;
+        get;
         private set
         {
             ThrowIfNullOrWhiteSpace(value, nameof(Name));
             ThrowIfGreaterThan(value.Length, NameMaxLength, nameof(Name));
-            _name = value;
+            field = value;
         }
-    }
+    } = null!;
 
     // Private setters needed for EF
     public int PowerLevel
     {
-        get => _powerLevel;
+        get;
         private set
         {
             ThrowIfLessThan(value, 1, nameof(PowerLevel));
             ThrowIfGreaterThan(value, 10, nameof(PowerLevel));
-            _powerLevel = value;
+            field = value;
         }
     }
 

src/Domain/Teams/Mission.cs

@@ -6,19 +6,18 @@
 
 public class Mission : Entity<MissionId>
 {
-    private string _description = null!;
     public const int DescriptionMaxLength = 500;
 
     public string Description
     {
-        get => _description;
+        get;
         private set
         {
             ThrowIfNullOrWhiteSpace(value, nameof(Description));
             ThrowIfGreaterThan(value.Length, DescriptionMaxLength, nameof(Description));
-            _description = value;
+            field = value;
         }
-    }
+    } = null!;
 
     public MissionStatus Status { get; private set; }
 

src/Domain/Teams/Team.cs

@@ -10,21 +10,20 @@ public class Team : AggregateRoot<TeamId>
 {
     public const int NameMaxLength = 100;
 
-    private string _name = null!;
     private readonly List<Hero> _heroes = [];
     private readonly List<Mission> _missions = [];
     private Mission? CurrentMission => _missions.FirstOrDefault(m => m.Status == MissionStatus.InProgress);
 
     public string Name
     {
-        get => _name;
+        get;
         private set
         {
             ThrowIfNullOrWhiteSpace(value, nameof(Name));
             ThrowIfGreaterThan(value.Length, NameMaxLength, nameof(Name));
-            _name = value;
+            field = value;
         }
-    }
+    } = null!;
 
     public int TotalPowerLevel { get; private set; }
     public TeamStatus Status { get; private set; }