user: skip validations when creating portus user

This is a fix for a regression introduced by the previous two commits.

Signed-off-by: Miquel Sabaté Solà <[email protected]>

Author: mssola

app/models/user.rb

@@ -62,6 +62,7 @@ class User < ActiveRecord::Base
   validate :private_namespace_and_team_available, on: :create
   validate :portus_user_validation, on: :update
   after_create :create_personal_namespace!
+  after_create :no_skip_validation!
 
   # Actions performed before destroy
   before_destroy :update_tags!
@@ -78,6 +79,21 @@ class User < ActiveRecord::Base
   scope :enabled,    -> { not_portus.where enabled: true }
   scope :admins,     -> { not_portus.where enabled: true, admin: true }
 
+  class <<self
+    attr_accessor :skip_portus_validation
+  end
+
+  # Creates the Portus hidden user.
+  def self.create_portus_user!
+    User.skip_portus_validation = true
+    User.create!(
+      username: "portus",
+      password: Rails.application.secrets.portus_password,
+      email:    "[email protected]",
+      admin:    true
+    )
+  end
+
   # Special method used by Devise to require an email on signup. This is always
   # true except for LDAP.
   def email_required?
@@ -87,6 +103,11 @@ def email_required?
   # Adds an error if the user to be updated is the portus one. This is a
   # validation on update, so it can be skipped when strictly required.
   def portus_user_validation
+    if User.skip_portus_validation
+      User.skip_portus_validation = nil
+      return
+    end
+
     return unless portus? || portus?(username_was)
     errors.add(:username, "cannot be updated")
   end
@@ -138,7 +159,11 @@ def create_personal_namespace!
       description: default_description,
       registry:    Registry.get # TODO: fix once we handle more registries
     )
-    update_attributes(namespace: namespace)
+
+    # Skipping validation on purpose, so after creating the portus hidden user,
+    # a namespace can be assigned to it even if updates are forbidden
+    # afterwards.
+    update_attribute("namespace", namespace)
   end
 
   # Find the user that can be guessed from the given push event.
@@ -256,6 +281,11 @@ def suggest_username(data)
 
   protected
 
+  # Validations can no longer be skipped after calling this method.
+  def no_skip_validation!
+    User.skip_portus_validation = nil
+  end
+
   # Get username from provider's data.
   def extract_username(data)
     data["nickname"] || data["username"] || data["email"].match(/^[^@]*/).to_s

db/seeds.rb

@@ -8,12 +8,7 @@
 end
 
 Rails.logger.info "Adding the \"portus\" user"
-User.create!(
-  username: "portus",
-  password: Rails.application.secrets.portus_password,
-  email:    "[email protected]",
-  admin:    true
-)
+User.create_portus_user!
 
 # Adding a user and a registry for integration tests.
 if ENV["INTEGRATION_TESTS"]

spec/api/grape_api/v1/users_spec.rb

@@ -144,10 +144,10 @@
 
     context "portus user" do
       it "does not allow portus user to be updated" do
-        create :user, username: "portus", email: "[email protected]"
+        User.create_portus_user!
         portus = User.find_by(username: "portus")
         put "/api/v1/users/#{portus.id}", { user: user_data }, @header
-        expect(response).to have_http_status(:unprocessable_entity)
+        expect(response).to have_http_status(:bad_request)
       end
     end
   end

spec/api/v2/token_spec.rb

@@ -302,14 +302,7 @@ def parse_token(body)
           }
         end
 
-        before do
-          User.create!(
-            username: "portus",
-            password: Rails.application.secrets.portus_password,
-            email:    "[email protected]",
-            admin:    true
-          )
-        end
+        before { User.create_portus_user! }
 
         it "allows portus to access the Catalog API" do
           get v2_token_url, valid_request, valid_portus_auth_header

spec/controllers/admin/namespaces_controller_spec.rb

@@ -13,7 +13,9 @@
     end
 
     describe "GET #index" do
-      let!(:portus) { create(:admin, username: "portus") }
+      before { User.create_portus_user! }
+
+      let(:portus) { User.find_by(username: "portus") }
 
       context "pagination" do
         it "paginates namespaces" do

spec/controllers/namespaces_controller_spec.rb

@@ -62,7 +62,9 @@
   end
 
   describe "GET #show" do
-    let!(:portus) { create(:admin, username: "portus") }
+    before { User.create_portus_user! }
+
+    let(:portus) { User.find_by(username: "portus") }
 
     it "paginates repositories" do
       sign_in owner

spec/features/admin/dashboard_spec.rb

@@ -14,7 +14,7 @@
   end
 
   it "The dashboard does not count the Portus user" do
-    create_portus_user!
+    User.create_portus_user!
     visit admin_dashboard_index_path
 
     # 3 users: admin, user and the one created by the registry.
@@ -24,7 +24,7 @@
   it "Warn the admin that the portus user does not exist" do
     expect(page).to have_content("The Portus user does not exist!")
 
-    create_portus_user!
+    User.create_portus_user!
     visit admin_dashboard_index_path
 
     expect(page).not_to have_content("The Portus user does not exist!")

spec/features/auth/signup_feature_spec.rb

@@ -38,7 +38,7 @@
 
   it "The portus user does not interfere with regular admin creation" do
     User.delete_all
-    create_portus_user!
+    User.create_portus_user!
 
     visit new_user_registration_url
 
@@ -102,7 +102,7 @@
 
   it "I am redirected to the signup page if only the portus user exists" do
     User.delete_all
-    create(:admin, username: "portus")
+    User.create_portus_user!
 
     visit new_user_session_url
     expect(current_url).to eq new_user_registration_url

spec/lib/portus/registry_client_spec.rb

@@ -242,7 +242,7 @@ def fetch_link_test(header)
   context "fetching Catalog from registry" do
     it "returns the available catalog" do
       create(:registry)
-      create(:admin, username: "portus")
+      User.create_portus_user!
 
       VCR.use_cassette("registry/get_registry_catalog", record: :none) do
         registry = described_class.new(
@@ -261,7 +261,7 @@ def fetch_link_test(header)
 
     it "returns the available catalog even if it has more than 100 repos" do
       create(:registry)
-      create(:admin, username: "portus")
+      User.create_portus_user!
 
       VCR.use_cassette("registry/catalog_lots_of_repos", record: :none) do
         WebMock.disable_net_connect!
@@ -286,7 +286,7 @@ def fetch_link_test(header)
 
     it "does not remove all repos just because one of them is failing" do
       create(:registry)
-      create(:admin, username: "portus")
+      User.create_portus_user!
 
       VCR.use_cassette("registry/get_registry_one_fails", record: :none) do
         registry = described_class.new(
@@ -355,7 +355,7 @@ def fetch_link_test(header)
 
     it "returns nil for tags when an exception happened" do
       create(:registry)
-      create(:admin, username: "portus")
+      User.create_portus_user!
 
       allow_any_instance_of(::Portus::RegistryClient).to receive(:tags) do
         raise ::Portus::Errors::NotFoundError, "I AM ERROR"
@@ -380,7 +380,7 @@ def fetch_link_test(header)
   context "fetching lists from the catalog" do
     it "returns the available tags even if there are more than 100 of them" do
       create(:registry)
-      create(:admin, username: "portus")
+      User.create_portus_user!
 
       VCR.use_cassette("registry/catalog_lots_of_tags", record: :none) do
         registry = described_class.new(

spec/models/namespace_spec.rb

@@ -67,9 +67,11 @@
   end
 
   context "is portus" do
-    let!(:registry)    { create(:registry) }
-    let!(:owner)       { create(:user) }
-    let!(:portus)      { create(:admin, username: "portus") }
+    let!(:registry) { create(:registry) }
+    let!(:owner)    { create(:user) }
+    let(:portus)    { User.find_by(username: "portus") }
+
+    before { User.create_portus_user! }
 
     it "returns true when the given namespace belongs to portus" do
       expect(described_class.find_by(name: portus.username)).to be_portus