Implemented namespace deletion

This commit fixes one of the oldest requests we've had: being able to
delete a namespace. It also introduces an API endpoint for it. There are
two exceptions when it comes to deleting a namespace:

1. Personal namespaces cannot be removed. In the future we might
   implement user removal, and then it will make sense to re-iterate on
   this.
2. Global namespaces cannot be removed, because they are meant to be
   guaranteed by everyone using the registry.

Fixes #767

Signed-off-by: Miquel Sabaté Solà <[email protected]>
Signed-off-by: Vítor Avelino <[email protected]>

Author: mssola

app/assets/javascripts/modules/namespaces/components/delete-btn.vue

@@ -0,0 +1,69 @@
+<template>
+  <div>
+    <button
+      class="btn btn-danger namespace-delete-btn"
+      data-container="body"
+      data-placement="left"
+      data-toggle="popover"
+      data-content="<p>Are you sure you want to remove this namespace?</p>
+      <a class='btn btn-default'>No</a> <a class='btn btn-primary yes'>Yes</a>"
+      data-template="<div class='popover popover-namespace-delete' role='tooltip'><div class='arrow'></div><h3 class='popover-title'></h3><div class='popover-content'></div></div>'"
+      data-html="true"
+      role="button"
+      title="Delete image"
+      :disabled="state.isDeleting">
+      <i class="fa fa-trash"></i>
+      Delete namespace
+    </button>
+  </div>
+</template>
+
+<script>
+  import Vue from 'vue';
+
+  import { handleHttpResponseError } from '~/utils/http';
+
+  import NamespacesStore from '../store';
+  import NamespacesService from '../services/namespaces';
+
+  const { set } = Vue;
+
+  export default {
+    props: {
+      namespace: {
+        type: Object,
+        required: true,
+      },
+      redirectPath: String,
+    },
+
+    data() {
+      return {
+        state: NamespacesStore.state,
+      };
+    },
+
+    methods: {
+      deleteNamespace() {
+        set(this.state, 'isDeleting', true);
+
+        NamespacesService.remove(this.namespace.id).then(() => {
+          this.$alert.$schedule('Namespace removed with all its repositories');
+          window.location.href = this.redirectPath;
+        }).catch(handleHttpResponseError)
+          .finally(() => set(this.state, 'isDeleting', false));
+      },
+    },
+
+    mounted() {
+      const DELETE_BTN = '.namespace-delete-btn';
+      const POPOVER_DELETE = '.popover-namespace-delete';
+
+      // TODO: refactor bootstrap popover to a component
+      $(this.$el).on('inserted.bs.popover', DELETE_BTN, () => {
+        const $yes = $(POPOVER_DELETE).find('.yes');
+        $yes.click(this.deleteNamespace.bind(this));
+      });
+    },
+  };
+</script>

app/assets/javascripts/modules/namespaces/pages/show.vue

@@ -1,5 +1,13 @@
 <template>
   <div class="namespaces-show-page">
+    <div class="header clearfix">
+      <div class="btn-toolbar pull-right">
+        <div class="btn-group">
+          <delete-namespace-btn :namespace="namespace" :redirect-path="namespacesPath" v-if="namespace.destroyable"></delete-namespace-btn>
+        </div>
+      </div>
+    </div>
+
     <namespace-details-panel :namespace="namespace" :state="state" :teams-path="teamsPath" :webhooks-path="webhooksPath"></namespace-details-panel>
     <repositories-panel title="Namespace's repositories" :repositories="repositories" :show-namespaces="false" :repositories-path="repositoriesPath">
       <div slot="heading-right">
@@ -68,6 +76,7 @@
 
   import RepositoriesPanel from '~/modules/repositories/components/panel';
   import WebhooksPanel from '~/modules/webhooks/components/panel';
+  import DeleteNamespaceBtn from '../components/delete-btn';
 
   import NamespaceDetailsPanel from '../components/details';
 
@@ -83,6 +92,9 @@
       repositoriesRef: {
         type: Array,
       },
+      namespacesPath: {
+        type: String,
+      },
       repositoriesPath: {
         type: String,
       },
@@ -98,6 +110,7 @@
       NamespaceDetailsPanel,
       RepositoriesPanel,
       WebhooksPanel,
+      DeleteNamespaceBtn,
     },
 
     data() {

app/assets/javascripts/modules/namespaces/services/namespaces.js

@@ -58,11 +58,16 @@ function teamExists(value) {
     .catch(() => null);
 }
 
+function remove(id) {
+  return resource.delete({ id });
+}
+
 export default {
   get,
   all,
   update,
   save,
+  remove,
   searchTeam,
   teamExists,
   validate,

app/assets/javascripts/modules/namespaces/store.js

@@ -3,6 +3,7 @@ class RepositoriesStore {
     this.state = {
       newFormVisible: false,
       editFormVisible: false,
+      isDeleting: false,
       isLoading: false,
       notLoaded: false,
       onGoingVisibilityRequest: false,

app/assets/javascripts/modules/users/components/application-tokens/panel.vue

@@ -3,7 +3,7 @@
     <h5 slot="heading-left">Application tokens</h5>
 
     <div slot="heading-right" v-if="canCreate">
-      <toggle-link text="Create new team" :state="state" state-key="newFormVisible" class="toggle-link-new-app-token"></toggle-link>
+      <toggle-link text="Create new token" :state="state" state-key="newFormVisible" class="toggle-link-new-app-token"></toggle-link>
     </div>
 
     <div slot="body">

app/helpers/namespaces_helper.rb

@@ -9,4 +9,43 @@ module NamespacesHelper
   def can_create_namespace?
     current_user.admin? || APP_CONFIG.enabled?("user_permission.create_namespace")
   end
+
+  # Render the name for the namespace from the given activity. An article can be
+  # prepended to the activity if `article` is set to true (e.g. "deleted the
+  # namespace" vs "deleted namespace").
+  #
+  # NOTE: to be removed when working on #1936,
+  def render_namespace_name(activity, article = false)
+    name = activity.parameters[:namespace_name]
+
+    if name
+      articled("the ", name, article)
+    elsif activity.trackable && activity.trackable_type == "Namespace"
+      articled("the ", link_to(activity.trackable.name, activity.trackable), article)
+    else
+      articled(name, "a", article)
+    end
+  end
+
+  # Render the team for the namespace from the given activity.
+  #
+  # NOTE: to be removed when working on #1936,
+  def render_namespace_team(activity)
+    name = activity.parameters[:team]
+
+    if activity.trackable_type == "Namespace" && activity.trackable&.team
+      content_tag(:span, "the ") + link_to(activity.trackable.team.name, activity.trackable.team)
+    elsif name
+      content_tag(:span, "the ") + name
+    else
+      content_tag(:span, "a")
+    end
+  end
+
+  protected
+
+  # NOTE: to be removed when working on #1936,
+  def articled(pre, post, article)
+    article ? content_tag(:span, pre) + post : post
+  end
 end

app/helpers/repositories_helper.rb

@@ -65,7 +65,7 @@ def render_repo_activity(activity, action)
     owner = content_tag(:strong, "#{activity_owner(activity)} #{action} ")
 
     namespace = render_namespace(activity)
-    namespace += " / " unless namespace.empty?
+    namespace += "/" unless namespace.empty?
 
     owner + namespace + render_repository(activity)
   end
@@ -78,7 +78,7 @@ def render_repo_activity(activity, action)
   def render_namespace(activity)
     tr = activity.trackable
 
-    if tr.nil? || tr.is_a?(Namespace)
+    if tr.nil? || tr.is_a?(Namespace) || tr.is_a?(Registry)
       if activity.parameters[:namespace_name].nil?
         ""
       else
@@ -111,7 +111,7 @@ def render_repository(activity)
   def get_repo_link_tag(activity)
     tr = activity.trackable
 
-    if tr.nil?
+    if tr.nil? || tr.is_a?(Registry)
       if repo_name(activity).nil?
         ["a repository", nil, ""]
       else

app/models/activity/fallback.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+# Activity holds utility methods to update activity records depending on the
+# model including this module.
+module Activity
+  # Fallback has a set of methods that manage trackable types for existing
+  # activities.
+  module Fallback
+    # fallback_activity updates the model including this method by setting a new
+    # type an id for all the rows.
+    def fallback_activity(type, id)
+      PublicActivity::Activity.where(trackable: self).update_all(
+        trackable_type: type,
+        trackable_id:   id,
+        recipient_type: nil
+      )
+    end
+  end
+end

app/models/namespace.rb

@@ -24,6 +24,7 @@
 class Namespace < ActiveRecord::Base
   include PublicActivity::Common
   include SearchCop
+  include ::Activity::Fallback
 
   search_scope :search do
     attributes :name, :description
@@ -122,7 +123,6 @@ def self.make_valid(name)
     # To avoid any name conflict we append an incremental number to the end
     # of the name returns it as the name that will be used on both Namespace
     # and Team on the User#create_personal_namespace! method
-    # TODO: workaround until we implement the namespace/team removal
     increment = 0
     original_name = name
     while Namespace.exists?(name: name)
@@ -140,4 +140,40 @@ def self.make_valid(name)
   def clean_name
     global? ? registry.hostname : name
   end
+
+  # Tries to delete a namespace and, on success, it will create delete
+  # activities and update related ones. This method assumes that all
+  # repositories and tags under this namespace have already been destroyed.
+  def delete_by!(actor)
+    destroy ? create_delete_activities!(actor) : false
+  end
+
+  protected
+
+  def create_delete_activities!(actor)
+    # Set the namespace name in the parameters field.
+    # TODO(2.5): this could be more performant in PostgreSQL if we used its
+    # `jsonb_set` function. Plus, in Rails 5 there might be some improvements
+    # that might help on this.
+    ActiveRecord::Base.transaction do
+      PublicActivity::Activity.where(trackable: self).find_each do |act|
+        act.parameters[:namespace_name] = clean_name
+        act.save
+      end
+    end
+
+    fallback_activity(Registry, registry.id)
+
+    # Add a "delete" activity"
+    registry.create_activity(
+      :delete,
+      owner:      actor,
+      recipient:  self,
+      parameters: {
+        namespace_name: clean_name,
+        team_name:      team.name,
+        registry_id:    registry.id
+      }
+    )
+  end
 end

app/models/registry.rb

@@ -24,6 +24,8 @@
 # NOTE: currently only one Registry is allowed to exist in the database. This
 # might change in the future.
 class Registry < ActiveRecord::Base
+  include PublicActivity::Common
+
   has_many :namespaces, dependent: :destroy
 
   validates :name, presence: true, uniqueness: true