test: annotation calls and named types referencing declarations in other files (#587)

Closes partially #540

### Summary of Changes

Add tests to ensure that annotation calls and named types can reference
declarations in other files. No changes to the implementation of the
scope provider were needed.

---------

Co-authored-by: megalinter-bot <[email protected]>

Author: lars-reimann

src/language/scoping/safe-ds-scope-provider.ts

@@ -132,20 +132,18 @@ export class SafeDsScopeProvider extends DefaultScopeProvider {
     }
 
     private getScopeForMemberAccessMember(node: SdsMemberAccess): Scope {
-        let currentScope = EMPTY_SCOPE;
-
         // Static access
         const declaration = this.getUniqueReferencedDeclarationForExpression(node.receiver);
         if (isSdsClass(declaration)) {
-            currentScope = this.createScopeForNodes(classMembersOrEmpty(declaration, isStatic));
+            return this.createScopeForNodes(classMembersOrEmpty(declaration, isStatic));
 
             //     val superTypeMembers = receiverDeclaration.superClassMembers()
             //         .filter { it.isStatic() }
             // .toList()
             //
             //     return Scopes.scopeFor(members, Scopes.scopeFor(superTypeMembers))
         } else if (isSdsEnum(declaration)) {
-            currentScope = this.createScopeForNodes(enumVariantsOrEmpty(declaration));
+            return this.createScopeForNodes(enumVariantsOrEmpty(declaration));
         }
 
         //     // Call results
@@ -176,7 +174,7 @@ export class SafeDsScopeProvider extends DefaultScopeProvider {
         //     else -> resultScope
         //     }
 
-        return currentScope;
+        return EMPTY_SCOPE;
     }
 
     /**

tests/language/formatting/creator.ts

@@ -5,6 +5,7 @@ import { Diagnostic } from 'vscode-languageserver-types';
 import { createSafeDsServices } from '../../../src/language/safe-ds-module.js';
 import { EmptyFileSystem } from 'langium';
 import { getSyntaxErrors } from '../../helpers/diagnostics.js';
+import { clearDocuments } from 'langium/test';
 
 const services = createSafeDsServices(EmptyFileSystem).SafeDs;
 const root = 'formatting';
@@ -29,12 +30,14 @@ const createFormattingTest = async (relativeResourcePath: string): Promise<Forma
     const expectedFormattedCode = normalizeLineBreaks(parts[1]).trim();
 
     // Original code must not contain syntax errors
+    await clearDocuments(services);
     const syntaxErrorsInOriginalCode = await getSyntaxErrors(services, originalCode);
     if (syntaxErrorsInOriginalCode.length > 0) {
         return invalidTest(relativeResourcePath, new SyntaxErrorsInOriginalCodeError(syntaxErrorsInOriginalCode));
     }
 
     // Expected formatted code must not contain syntax errors
+    await clearDocuments(services);
     const syntaxErrorsInExpectedFormattedCode = await getSyntaxErrors(services, expectedFormattedCode);
     if (syntaxErrorsInExpectedFormattedCode.length > 0) {
         return invalidTest(

tests/language/partialEvaluation/creator.ts

@@ -10,6 +10,7 @@ import { URI } from 'vscode-uri';
 import { getSyntaxErrors, SyntaxErrorsInCodeError } from '../../helpers/diagnostics.js';
 import { EmptyFileSystem } from 'langium';
 import { createSafeDsServices } from '../../../src/language/safe-ds-module.js';
+import { clearDocuments } from 'langium/test';
 
 const services = createSafeDsServices(EmptyFileSystem).SafeDs;
 const root = 'partial evaluation';
@@ -40,6 +41,7 @@ const createPartialEvaluationTest = async (
         const code = fs.readFileSync(absolutePath).toString();
 
         // File must not contain any syntax errors
+        await clearDocuments(services);
         const syntaxErrors = await getSyntaxErrors(services, code);
         if (syntaxErrors.length > 0) {
             return invalidTest(

tests/language/scoping/creator.ts

@@ -40,14 +40,14 @@ const createScopingTest = async (
         const code = fs.readFileSync(absolutePath).toString();
 
         // File must not contain any syntax errors
+        await clearDocuments(services);
         const syntaxErrors = await getSyntaxErrors(services, code);
         if (syntaxErrors.length > 0) {
             return invalidTest(
                 `INVALID TEST FILE [${relativeResourcePath}]`,
                 new SyntaxErrorsInCodeError(syntaxErrors),
             );
         }
-        await clearDocuments(services);
 
         const checksResult = findTestChecks(code, uri, { failIfFewerRangesThanComments: true });
 

tests/language/typing/creator.ts

@@ -10,6 +10,7 @@ import { URI } from 'vscode-uri';
 import { getSyntaxErrors, SyntaxErrorsInCodeError } from '../../helpers/diagnostics.js';
 import { EmptyFileSystem } from 'langium';
 import { createSafeDsServices } from '../../../src/language/safe-ds-module.js';
+import { clearDocuments } from 'langium/test';
 
 const services = createSafeDsServices(EmptyFileSystem).SafeDs;
 const root = 'typing';
@@ -39,6 +40,7 @@ const createTypingTest = async (
         const code = fs.readFileSync(absolutePath).toString();
 
         // File must not contain any syntax errors
+        await clearDocuments(services);
         const syntaxErrors = await getSyntaxErrors(services, code);
         if (syntaxErrors.length > 0) {
             return invalidTest(

tests/language/validation/creator.ts

@@ -10,6 +10,7 @@ import { getSyntaxErrors, SyntaxErrorsInCodeError } from '../../helpers/diagnost
 import { EmptyFileSystem } from 'langium';
 import { createSafeDsServices } from '../../../src/language/safe-ds-module.js';
 import { DocumentUri, Range } from 'vscode-languageserver-types';
+import { clearDocuments } from 'langium/test';
 
 const services = createSafeDsServices(EmptyFileSystem).SafeDs;
 const root = 'validation';
@@ -38,6 +39,7 @@ const createValidationTest = async (
         const code = fs.readFileSync(absolutePath).toString();
 
         // File must not contain any syntax errors
+        await clearDocuments(services);
         const syntaxErrors = await getSyntaxErrors(services, code);
         if (syntaxErrors.length > 0) {
             return invalidTest(

tests/resources/scoping/annotation calls/across files/main no imports or own declarations.sdstest

@@ -0,0 +1,17 @@
+package tests.scoping.annotationCalls.acrossFiles
+
+// $TEST$ references same_MyAnnotation
+@»MyAnnotation«
+
+// $TEST$ references same_AnnotationInSamePackage
+@»AnnotationInSamePackage«
+
+// $TEST$ references safeds_AnnotationInSafeDsPackage
+@»AnnotationInSafeDsPackage«
+
+// $TEST$ unresolved
+@»AnnotationInAnotherPackage«
+
+// $TEST$ unresolved
+@»AnnotationWithoutPackage«
+pipeline myPipeline {}

tests/resources/scoping/annotation calls/across files/main with imports and own declarations.sdstest

@@ -0,0 +1,23 @@
+package tests.scoping.annotationCalls.acrossFiles
+
+import safeds.scoping.annotationCalls.acrossFiles.MyAnnotation as MyOwnAnnotation
+import tests.scoping.annotationCalls.acrossFiles.other.AnnotationInAnotherPackage
+
+// $TEST$ target own_MyOwnAnnotation
+annotation »MyOwnAnnotation«
+
+// $TEST$ references own_MyOwnAnnotation
+@»MyOwnAnnotation«
+
+// $TEST$ references same_AnnotationInSamePackage
+@»AnnotationInSamePackage«
+
+// $TEST$ references safeds_AnnotationInSafeDsPackage
+@»AnnotationInSafeDsPackage«
+
+// $TEST$ references other_AnnotationInAnotherPackage
+@»AnnotationInAnotherPackage«
+
+// $TEST$ unresolved
+@»AnnotationWithoutPackage«
+pipeline myPipeline {}

tests/resources/scoping/annotation calls/across files/main with multiple imports of same name.sdstest

@@ -0,0 +1,10 @@
+package tests.scoping.annotationCalls.acrossFiles
+
+import safeds.scoping.annotationCalls.acrossFiles.MyAnnotation
+import tests.scoping.annotationCalls.acrossFiles.other.MyAnnotation
+import tests.scoping.annotationCalls.acrossFiles.MyAnnotation
+
+pipeline myPipeline {
+    // $TEST$ references safeds_MyAnnotation
+    »MyAnnotation«;
+}

tests/resources/scoping/annotation calls/across files/main with qualified import with alias.sdstest

@@ -0,0 +1,31 @@
+package tests.scoping.annotationCalls.acrossFiles
+
+import tests.scoping.annotationCalls.acrossFiles.MyAnnotation as MyAnnotationInSamePackage
+import safeds.scoping.annotationCalls.acrossFiles.MyAnnotation as MyAnnotationInSafeDsPackage
+import tests.scoping.annotationCalls.acrossFiles.other.MyAnnotation as MyAnnotationInAnotherPackage
+
+// $TEST$ references same_MyAnnotation
+@»MyAnnotation«
+
+
+// $TEST$ references same_AnnotationInSamePackage
+@»AnnotationInSamePackage«
+
+// $TEST$ references safeds_AnnotationInSafeDsPackage
+@»AnnotationInSafeDsPackage«
+
+// $TEST$ unresolved
+@»AnnotationInAnotherPackage«
+
+// $TEST$ unresolved
+@»AnnotationWithoutPackage«
+
+// $TEST$ references same_MyAnnotation
+@»MyAnnotationInSamePackage«
+
+// $TEST$ references safeds_MyAnnotation
+@»MyAnnotationInSafeDsPackage«
+
+// $TEST$ references other_MyAnnotation
+@»MyAnnotationInAnotherPackage«
+pipeline myPipeline {}