make: Updating clang-tidy configuration

Updating clang-tidy config for newer features supported.
Some of these we will revisit after some code refactoring and if we decide to modernize to C11 as a minimum standard.

Signed-off-by: Tyler Erickson <[email protected]>

Author: vonericsen

.clang-tidy

@@ -1,21 +1,33 @@
 Checks: 
   '-*, 
   modernize-*, 
+  -modernize-macro-to-enum,
   cert-*, 
   bugprone-*, 
   -bugprone-easily-swappable-parameters, 
+  -bugprone-assignment-in-if-condition,
   clang-analyzer-*, 
   -clang-analyzer-deadcode.DeadStores, 
   misc-*, 
   -misc-no-recursion, 
   -misc-unused-parameters, 
+  -misc-include-cleaner,
   readability-non-const-parameter, 
   readability-inconsistent-declaration-parameter-name, 
   readability-redundant-control-flow, 
   readability-duplicate-include, 
   readability-avoid-const-params-in-decls, 
   readability-function-cognitive-complexity'
 
+# Setting cognitive complexity to 100.
+# This is quite high, but should be seen as a starting point
+# to resolve other complex functions over time to get back to the default
+# value of 25
+CheckOptions:
+  - key: readability-function-cognitive-complexity.Threshold
+    value: 100
+
+
 # Other available checks: 
 # clang-analyzer-*, performance-*, readability-*, misc-*
 
@@ -29,10 +41,17 @@ Checks:
 #   Recursion is useful in our code, so this check is not applicable.
 # - misc-unused-parameters: 
 #   Too many false positives.
+# - misc-include-cleaner
+#   We have a lot of includes wrapping others to work around system differences. This creates too much noise
+#   when it is enabled.
+# - modernize-macro-to-enum
+#   This is a great modernization, however it does not make sense everywhere.
+#   There are plenty of places to use this, however since we do not want to migrate to C11 as a requirement
+#   yet, this is not something we want to enable due to noise since anonymous enums are a C11 standard and not earlier.
+#   if/when we require C11, we should enable this
 # - readability-*: 
 #   Currently generates too many warnings. Manually adding rules until we can address these issues later.
 
 WarningsAsErrors: ''
 HeaderFilterRegex: '.*'
-AnalyzeTemporaryDtors: false
 FormatStyle: 'file'