-
Notifications
You must be signed in to change notification settings - Fork 1
Expand file tree
/
Copy pathspotbugs-result-WebGoat[webgoat]_2023_06_21_15_37_15.html
More file actions
5963 lines (5482 loc) · 372 KB
/
spotbugs-result-WebGoat[webgoat]_2023_06_21_15_37_15.html
File metadata and controls
5963 lines (5482 loc) · 372 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
<!DOCTYPE html
PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta charset="UTF-8"/>
<title>SpotBugs Report</title>
<style type="text/css">
.tablerow0 {
background: #EEEEEE;
}
.tablerow1 {
background: white;
}
.detailrow0 {
background: #EEEEEE;
}
.detailrow1 {
background: white;
}
.tableheader {
background: #b9b9fe;
font-size: larger;
}
</style>
</head>
<body>
<h1>SpotBugs Report</h1>
<p>Produced using <a href="https://spotbugs.github.io">SpotBugs</a>4.4.2.</p>
<p>Project:
WebGoat[webgoat]</p>
<h2>Metrics</h2>
<p>11451 lines of code analyzed,
in 378 classes,
in 60 packages.</p>
<table width="500" cellpadding="5" cellspacing="2">
<tr class="tableheader">
<th align="left">Metric</th>
<th align="right">Total</th>
<th align="right">Density*</th>
</tr>
<tr class="tablerow0">
<td>High Priority Warnings</td>
<td align="right">80</td>
<td align="right">6.99</td>
</tr>
<tr class="tablerow1">
<td>Medium Priority Warnings</td>
<td align="right">268</td>
<td align="right">23.40</td>
</tr>
<tr class="$totalClass">
<td>
<b>Total Warnings</b>
</td>
<td align="right">
<b>348</b>
</td>
<td align="right">
<b>30.39</b>
</td>
</tr>
</table>
<p>
<i>(* Defects per Thousand lines of non-commenting source statements)</i>
</p>
<p>
<br/>
<br/>
</p>
<h2>Summary</h2>
<table width="500" cellpadding="5" cellspacing="2">
<tr class="tableheader">
<th align="left">Warning Type</th>
<th align="right">Number</th>
</tr>
<tr class="tablerow0">
<td>
<a href="#Warnings_BAD_PRACTICE">Bad practice Warnings</a>
</td>
<td align="right">41</td>
</tr>
<tr class="tablerow1">
<td>
<a href="#Warnings_CORRECTNESS">Correctness Warnings</a>
</td>
<td align="right">26</td>
</tr>
<tr class="tablerow0">
<td>
<a href="#Warnings_EXPERIMENTAL">Experimental Warnings</a>
</td>
<td align="right">26</td>
</tr>
<tr class="tablerow1">
<td>
<a href="#Warnings_I18N">Internationalization Warnings</a>
</td>
<td align="right">32</td>
</tr>
<tr class="tablerow0">
<td>
<a href="#Warnings_MALICIOUS_CODE">Malicious code vulnerability Warnings</a>
</td>
<td align="right">71</td>
</tr>
<tr class="tablerow1">
<td>
<a href="#Warnings_PERFORMANCE">Performance Warnings</a>
</td>
<td align="right">18</td>
</tr>
<tr class="tablerow0">
<td>
<a href="#Warnings_SECURITY">Security Warnings</a>
</td>
<td align="right">118</td>
</tr>
<tr class="tablerow1">
<td>
<a href="#Warnings_STYLE">Dodgy code Warnings</a>
</td>
<td align="right">14</td>
</tr>
<tr class="tablerow0">
<td>
<b>Total</b>
</td>
<td align="right">
<b>346</b>
</td>
</tr>
</table>
<p>
<br/>
<br/>
</p>
<h1>Warnings</h1>
<p>Click on each warning link to see a full description of the issue, and
details of how to resolve it.</p>
<h2>
<a name="Warnings_BAD_PRACTICE">Bad practice Warnings</a>
</h2>
<table class="warningtable"
width="100%"
cellspacing="2"
cellpadding="5">
<tr class="tableheader">
<th align="left">Warning</th>
<th align="left">Priority</th>
<th align="left">Details</th>
</tr>
<tr class="tablerow1">
<td width="20%" valign="top">
<a href="#DMI_RANDOM_USED_ONLY_ONCE">Random object created and used only once</a>
</td>
<td width="10%" valign="top">High</td>
<td width="70%">
<p>Random object created and used only once in org.owasp.webgoat.lessons.challenges.challenge1.ImageServlet.<static initializer for ImageServlet>()<br/>
<br/>
<br/>In file ImageServlet.java ImageServlet.java,
line 17 17<br/>In class org.owasp.webgoat.lessons.challenges.challenge1.ImageServlet<br/>In method org.owasp.webgoat.lessons.challenges.challenge1.ImageServlet.<static initializer for ImageServlet>()<br/>Called method java.util.Random.nextInt(int)<br/>At ImageServlet.java:[line 17]<br/>At ImageServlet.java:[line 17]</p>
</td>
</tr>
<tr class="tablerow0">
<td width="20%" valign="top">
<a href="#DMI_RANDOM_USED_ONLY_ONCE">Random object created and used only once</a>
</td>
<td width="10%" valign="top">High</td>
<td width="70%">
<p>Random object created and used only once in org.owasp.webgoat.lessons.challenges.challenge7.PasswordResetLink.createPasswordReset(String, String)<br/>
<br/>
<br/>In file PasswordResetLink.java PasswordResetLink.java,
line 17 17<br/>In class org.owasp.webgoat.lessons.challenges.challenge7.PasswordResetLink<br/>In method org.owasp.webgoat.lessons.challenges.challenge7.PasswordResetLink.createPasswordReset(String, String)<br/>Called method java.util.Random.setSeed(long)<br/>At PasswordResetLink.java:[line 17]<br/>At PasswordResetLink.java:[line 17]</p>
</td>
</tr>
<tr class="tablerow1">
<td width="20%" valign="top">
<a href="#DMI_RANDOM_USED_ONLY_ONCE">Random object created and used only once</a>
</td>
<td width="10%" valign="top">High</td>
<td width="70%">
<p>Random object created and used only once in org.owasp.webgoat.lessons.cryptography.CryptoUtil.generateKeyPair()<br/>
<br/>
<br/>In file CryptoUtil.java CryptoUtil.java,
line 38 38<br/>In class org.owasp.webgoat.lessons.cryptography.CryptoUtil<br/>In method org.owasp.webgoat.lessons.cryptography.CryptoUtil.generateKeyPair()<br/>Called method java.security.SecureRandom.nextInt(int)<br/>At CryptoUtil.java:[line 38]<br/>At CryptoUtil.java:[line 38]</p>
</td>
</tr>
<tr class="tablerow0">
<td width="20%" valign="top">
<a href="#DMI_RANDOM_USED_ONLY_ONCE">Random object created and used only once</a>
</td>
<td width="10%" valign="top">High</td>
<td width="70%">
<p>Random object created and used only once in org.owasp.webgoat.lessons.cryptography.EncodingAssignment.getBasicAuth(HttpServletRequest)<br/>
<br/>
<br/>In file EncodingAssignment.java EncodingAssignment.java,
line 52 52<br/>In class org.owasp.webgoat.lessons.cryptography.EncodingAssignment<br/>In method org.owasp.webgoat.lessons.cryptography.EncodingAssignment.getBasicAuth(HttpServletRequest)<br/>Called method java.util.Random.nextInt(int)<br/>At EncodingAssignment.java:[line 52]<br/>At EncodingAssignment.java:[line 52]</p>
</td>
</tr>
<tr class="tablerow1">
<td width="20%" valign="top">
<a href="#DMI_RANDOM_USED_ONLY_ONCE">Random object created and used only once</a>
</td>
<td width="10%" valign="top">High</td>
<td width="70%">
<p>Random object created and used only once in org.owasp.webgoat.lessons.cryptography.HashingAssignment.getMd5(HttpServletRequest)<br/>
<br/>
<br/>In file HashingAssignment.java HashingAssignment.java,
line 53 53<br/>In class org.owasp.webgoat.lessons.cryptography.HashingAssignment<br/>In method org.owasp.webgoat.lessons.cryptography.HashingAssignment.getMd5(HttpServletRequest)<br/>Called method java.util.Random.nextInt(int)<br/>At HashingAssignment.java:[line 53]<br/>At HashingAssignment.java:[line 53]</p>
</td>
</tr>
<tr class="tablerow0">
<td width="20%" valign="top">
<a href="#DMI_RANDOM_USED_ONLY_ONCE">Random object created and used only once</a>
</td>
<td width="10%" valign="top">High</td>
<td width="70%">
<p>Random object created and used only once in org.owasp.webgoat.lessons.cryptography.HashingAssignment.getSha256(HttpServletRequest)<br/>
<br/>
<br/>In file HashingAssignment.java HashingAssignment.java,
line 71 71<br/>In class org.owasp.webgoat.lessons.cryptography.HashingAssignment<br/>In method org.owasp.webgoat.lessons.cryptography.HashingAssignment.getSha256(HttpServletRequest)<br/>Called method java.util.Random.nextInt(int)<br/>At HashingAssignment.java:[line 71]<br/>At HashingAssignment.java:[line 71]</p>
</td>
</tr>
<tr class="tablerow1">
<td width="20%" valign="top">
<a href="#DMI_RANDOM_USED_ONLY_ONCE">Random object created and used only once</a>
</td>
<td width="10%" valign="top">High</td>
<td width="70%">
<p>Random object created and used only once in org.owasp.webgoat.lessons.csrf.CSRFGetFlag.invoke(HttpServletRequest)<br/>
<br/>
<br/>In file CSRFGetFlag.java CSRFGetFlag.java,
line 60 60<br/>In class org.owasp.webgoat.lessons.csrf.CSRFGetFlag<br/>In method org.owasp.webgoat.lessons.csrf.CSRFGetFlag.invoke(HttpServletRequest)<br/>Called method java.util.Random.nextInt(int)<br/>At CSRFGetFlag.java:[line 60]<br/>At CSRFGetFlag.java:[line 60]</p>
</td>
</tr>
<tr class="tablerow0">
<td width="20%" valign="top">
<a href="#DMI_RANDOM_USED_ONLY_ONCE">Random object created and used only once</a>
</td>
<td width="10%" valign="top">High</td>
<td width="70%">
<p>Random object created and used only once in org.owasp.webgoat.lessons.hijacksession.cas.HijackSessionAuthenticationProvider.<static initializer for HijackSessionAuthenticationProvider>()<br/>
<br/>
<br/>In file HijackSessionAuthenticationProvider.java HijackSessionAuthenticationProvider.java,
line 48 48<br/>In class org.owasp.webgoat.lessons.hijacksession.cas.HijackSessionAuthenticationProvider<br/>In method org.owasp.webgoat.lessons.hijacksession.cas.HijackSessionAuthenticationProvider.<static initializer for HijackSessionAuthenticationProvider>()<br/>Called method java.util.Random.nextLong()<br/>At HijackSessionAuthenticationProvider.java:[line 48]<br/>At HijackSessionAuthenticationProvider.java:[line 48]</p>
</td>
</tr>
<tr class="tablerow1">
<td width="20%" valign="top">
<a href="#DMI_RANDOM_USED_ONLY_ONCE">Random object created and used only once</a>
</td>
<td width="10%" valign="top">High</td>
<td width="70%">
<p>Random object created and used only once in org.owasp.webgoat.lessons.jwt.JWTSecretKeyEndpoint.<static initializer for JWTSecretKeyEndpoint>()<br/>
<br/>
<br/>In file JWTSecretKeyEndpoint.java JWTSecretKeyEndpoint.java,
line 53 53<br/>In class org.owasp.webgoat.lessons.jwt.JWTSecretKeyEndpoint<br/>In method org.owasp.webgoat.lessons.jwt.JWTSecretKeyEndpoint.<static initializer for JWTSecretKeyEndpoint>()<br/>Called method java.util.Random.nextInt(int)<br/>At JWTSecretKeyEndpoint.java:[line 53]<br/>At JWTSecretKeyEndpoint.java:[line 53]</p>
</td>
</tr>
<tr class="tablerow0">
<td width="20%" valign="top">
<a href="#DMI_RANDOM_USED_ONLY_ONCE">Random object created and used only once</a>
</td>
<td width="10%" valign="top">High</td>
<td width="70%">
<p>Random object created and used only once in org.owasp.webgoat.lessons.xss.DOMCrossSiteScripting.completed(Integer, Integer, HttpServletRequest)<br/>
<br/>
<br/>In file DOMCrossSiteScripting.java DOMCrossSiteScripting.java,
line 44 44<br/>In class org.owasp.webgoat.lessons.xss.DOMCrossSiteScripting<br/>In method org.owasp.webgoat.lessons.xss.DOMCrossSiteScripting.completed(Integer, Integer, HttpServletRequest)<br/>Called method java.security.SecureRandom.nextInt()<br/>At DOMCrossSiteScripting.java:[line 44]<br/>At DOMCrossSiteScripting.java:[line 44]</p>
</td>
</tr>
<tr class="tablerow1">
<td width="20%" valign="top">
<a href="#DE_MIGHT_IGNORE">Method might ignore exception</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>org.owasp.webgoat.lessons.passwordreset.ResetLinkAssignmentForgotPassword.fakeClickingLinkEmail(String, String) might ignore java.lang.Exception<br/>
<br/>
<br/>In file ResetLinkAssignmentForgotPassword.java ResetLinkAssignmentForgotPassword.java ResetLinkAssignmentForgotPassword.java,
line 110 110 110<br/>In class org.owasp.webgoat.lessons.passwordreset.ResetLinkAssignmentForgotPassword<br/>In method org.owasp.webgoat.lessons.passwordreset.ResetLinkAssignmentForgotPassword.fakeClickingLinkEmail(String, String)<br/>Exception class java.lang.Exception<br/>At ResetLinkAssignmentForgotPassword.java:[line 110]<br/>At ResetLinkAssignmentForgotPassword.java:[line 110]<br/>At ResetLinkAssignmentForgotPassword.java:[line 110]</p>
</td>
</tr>
<tr class="tablerow0">
<td width="20%" valign="top">
<a href="#VA_FORMAT_STRING_USES_NEWLINE">Format string should use %n rather than \n</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>Format string should use %n rather than \n in org.owasp.webgoat.AccessControlIntegrationTest.assignment3()<br/>
<br/>
<br/>In file AccessControlIntegrationTest.java,
line 42<br/>In class org.owasp.webgoat.AccessControlIntegrationTest<br/>In method org.owasp.webgoat.AccessControlIntegrationTest.assignment3()<br/>Called method String.format(String, Object[])<br/>Format string "{"username":"%s","password":"%s","admin": "true"}\n"<br/>At AccessControlIntegrationTest.java:[line 42]</p>
</td>
</tr>
<tr class="tablerow1">
<td width="20%" valign="top">
<a href="#VA_FORMAT_STRING_USES_NEWLINE">Format string should use %n rather than \n</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>Format string should use %n rather than \n in org.owasp.webgoat.lessons.challenges.challenge7.Assignment7.sendPasswordResetLink(String, HttpServletRequest)<br/>
<br/>
<br/>In file Assignment7.java,
line 84<br/>In class org.owasp.webgoat.lessons.challenges.challenge7.Assignment7<br/>In method org.owasp.webgoat.lessons.challenges.challenge7.Assignment7.sendPasswordResetLink(String, HttpServletRequest)<br/>Called method String.format(String, Object[])<br/>Format string "Hi, you requested a password reset link, please use this <a target='_blank' href='%s:8080/WebGoat/challenge/7/reset-password/%s'>link</a> to reset your password.\n \n\nIf you did not request this password change you can ignore this message.\nIf you have any comments or questions, please do not hesitate to reach us at support@webgoat-cloud.org\n\nKind regards, \nTeam WebGoat"<br/>At Assignment7.java:[line 84]</p>
</td>
</tr>
<tr class="tablerow0">
<td width="20%" valign="top">
<a href="#VA_FORMAT_STRING_USES_NEWLINE">Format string should use %n rather than \n</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>Format string should use %n rather than \n in org.owasp.webgoat.lessons.passwordreset.ResetLinkAssignmentForgotPassword.sendMailToUser(String, String, String)<br/>
<br/>
<br/>In file ResetLinkAssignmentForgotPassword.java,
line 93<br/>In class org.owasp.webgoat.lessons.passwordreset.ResetLinkAssignmentForgotPassword<br/>In method org.owasp.webgoat.lessons.passwordreset.ResetLinkAssignmentForgotPassword.sendMailToUser(String, String, String)<br/>Called method String.format(String, Object[])<br/>Format string "Hi, you requested a password reset link, please use this <a target='_blank'\n href='http://%s/WebGoat/PasswordReset/reset/reset-password/%s'>link</a> to reset your\n password.\n\nIf you did not request this password change you can ignore this message.\nIf you have any comments or questions, please do not hesitate to reach us at\n support@webgoat-cloud.org\n\nKind regards,\nTeam WebGoat\n"<br/>At ResetLinkAssignmentForgotPassword.java:[line 93]</p>
</td>
</tr>
<tr class="tablerow1">
<td width="20%" valign="top">
<a href="#NM_METHOD_NAMING_CONVENTION">Method names should start with a lower case letter</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>The method name org.owasp.webgoat.lessons.missingac.MissingFunctionACHiddenMenusTest.HiddenMenusClose() doesn't start with a lower case letter<br/>
<br/>
<br/>In file MissingFunctionACHiddenMenusTest.java,
lines 65
to 75<br/>In class org.owasp.webgoat.lessons.missingac.MissingFunctionACHiddenMenusTest<br/>In method org.owasp.webgoat.lessons.missingac.MissingFunctionACHiddenMenusTest.HiddenMenusClose()<br/>At MissingFunctionACHiddenMenusTest.java:[lines 65-75]</p>
</td>
</tr>
<tr class="tablerow0">
<td width="20%" valign="top">
<a href="#NM_METHOD_NAMING_CONVENTION">Method names should start with a lower case letter</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>The method name org.owasp.webgoat.lessons.missingac.MissingFunctionACHiddenMenusTest.HiddenMenusFailure() doesn't start with a lower case letter<br/>
<br/>
<br/>In file MissingFunctionACHiddenMenusTest.java,
lines 79
to 89<br/>In class org.owasp.webgoat.lessons.missingac.MissingFunctionACHiddenMenusTest<br/>In method org.owasp.webgoat.lessons.missingac.MissingFunctionACHiddenMenusTest.HiddenMenusFailure()<br/>At MissingFunctionACHiddenMenusTest.java:[lines 79-89]</p>
</td>
</tr>
<tr class="tablerow1">
<td width="20%" valign="top">
<a href="#NM_METHOD_NAMING_CONVENTION">Method names should start with a lower case letter</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>The method name org.owasp.webgoat.lessons.missingac.MissingFunctionACHiddenMenusTest.HiddenMenusSuccess() doesn't start with a lower case letter<br/>
<br/>
<br/>In file MissingFunctionACHiddenMenusTest.java,
lines 51
to 61<br/>In class org.owasp.webgoat.lessons.missingac.MissingFunctionACHiddenMenusTest<br/>In method org.owasp.webgoat.lessons.missingac.MissingFunctionACHiddenMenusTest.HiddenMenusSuccess()<br/>At MissingFunctionACHiddenMenusTest.java:[lines 51-61]</p>
</td>
</tr>
<tr class="tablerow0">
<td width="20%" valign="top">
<a href="#NM_METHOD_NAMING_CONVENTION">Method names should start with a lower case letter</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>The method name org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson9Test.SmithIsMostEarningCompletesAssignment() doesn't start with a lower case letter<br/>
<br/>
<br/>In file SqlInjectionLesson9Test.java,
lines 186
to 197<br/>In class org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson9Test<br/>In method org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson9Test.SmithIsMostEarningCompletesAssignment()<br/>At SqlInjectionLesson9Test.java:[lines 186-197]</p>
</td>
</tr>
<tr class="tablerow1">
<td width="20%" valign="top">
<a href="#ODR_OPEN_DATABASE_RESOURCE">Method may fail to close database resource</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>org.owasp.webgoat.lessons.challenges.challenge5.Assignment5.login(String, String) may fail to close PreparedStatement<br/>
<br/>
<br/>In file Assignment5.java Assignment5.java,
line 59 59<br/>In class org.owasp.webgoat.lessons.challenges.challenge5.Assignment5<br/>In method org.owasp.webgoat.lessons.challenges.challenge5.Assignment5.login(String, String)<br/>Need to close java.sql.PreparedStatement <br/>At Assignment5.java:[line 59]<br/>At Assignment5.java:[line 59]</p>
</td>
</tr>
<tr class="tablerow0">
<td width="20%" valign="top">
<a href="#ODR_OPEN_DATABASE_RESOURCE">Method may fail to close database resource</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>org.owasp.webgoat.lessons.jwt.JWTFinalEndpoint$1.resolveSigningKeyBytes(JwsHeader, Claims) may fail to close Statement<br/>
<br/>
<br/>In file JWTFinalEndpoint.java JWTFinalEndpoint.java,
line 88 88<br/>In class org.owasp.webgoat.lessons.jwt.JWTFinalEndpoint$1<br/>In method org.owasp.webgoat.lessons.jwt.JWTFinalEndpoint$1.resolveSigningKeyBytes(JwsHeader, Claims)<br/>Need to close java.sql.Statement <br/>At JWTFinalEndpoint.java:[line 88]<br/>At JWTFinalEndpoint.java:[line 88]</p>
</td>
</tr>
<tr class="tablerow1">
<td width="20%" valign="top">
<a href="#ODR_OPEN_DATABASE_RESOURCE">Method may fail to close database resource</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>org.owasp.webgoat.lessons.sqlinjection.advanced.SqlInjectionChallenge.registerNewUser(String, String, String) may fail to close PreparedStatement<br/>
<br/>
<br/>In file SqlInjectionChallenge.java SqlInjectionChallenge.java,
line 79 79<br/>In class org.owasp.webgoat.lessons.sqlinjection.advanced.SqlInjectionChallenge<br/>In method org.owasp.webgoat.lessons.sqlinjection.advanced.SqlInjectionChallenge.registerNewUser(String, String, String)<br/>Need to close java.sql.PreparedStatement <br/>At SqlInjectionChallenge.java:[line 79]<br/>At SqlInjectionChallenge.java:[line 79]</p>
</td>
</tr>
<tr class="tablerow0">
<td width="20%" valign="top">
<a href="#ODR_OPEN_DATABASE_RESOURCE">Method may fail to close database resource</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>org.owasp.webgoat.lessons.sqlinjection.advanced.SqlInjectionChallenge.registerNewUser(String, String, String) may fail to close Statement<br/>
<br/>
<br/>In file SqlInjectionChallenge.java SqlInjectionChallenge.java,
line 68 68<br/>In class org.owasp.webgoat.lessons.sqlinjection.advanced.SqlInjectionChallenge<br/>In method org.owasp.webgoat.lessons.sqlinjection.advanced.SqlInjectionChallenge.registerNewUser(String, String, String)<br/>Need to close java.sql.Statement <br/>At SqlInjectionChallenge.java:[line 68]<br/>At SqlInjectionChallenge.java:[line 68]</p>
</td>
</tr>
<tr class="tablerow1">
<td width="20%" valign="top">
<a href="#ODR_OPEN_DATABASE_RESOURCE">Method may fail to close database resource</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>org.owasp.webgoat.lessons.sqlinjection.advanced.SqlInjectionChallengeLogin.login(String, String) may fail to close PreparedStatement<br/>
<br/>
<br/>In file SqlInjectionChallengeLogin.java SqlInjectionChallengeLogin.java,
line 56 56<br/>In class org.owasp.webgoat.lessons.sqlinjection.advanced.SqlInjectionChallengeLogin<br/>In method org.owasp.webgoat.lessons.sqlinjection.advanced.SqlInjectionChallengeLogin.login(String, String)<br/>Need to close java.sql.PreparedStatement <br/>At SqlInjectionChallengeLogin.java:[line 56]<br/>At SqlInjectionChallengeLogin.java:[line 56]</p>
</td>
</tr>
<tr class="tablerow0">
<td width="20%" valign="top">
<a href="#ODR_OPEN_DATABASE_RESOURCE">Method may fail to close database resource</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>org.owasp.webgoat.lessons.sqlinjection.advanced.SqlInjectionLesson6b.getPassword() may fail to close Statement<br/>
<br/>
<br/>In file SqlInjectionLesson6b.java SqlInjectionLesson6b.java,
line 63 63<br/>In class org.owasp.webgoat.lessons.sqlinjection.advanced.SqlInjectionLesson6b<br/>In method org.owasp.webgoat.lessons.sqlinjection.advanced.SqlInjectionLesson6b.getPassword()<br/>Need to close java.sql.Statement <br/>At SqlInjectionLesson6b.java:[line 63]<br/>At SqlInjectionLesson6b.java:[line 63]</p>
</td>
</tr>
<tr class="tablerow1">
<td width="20%" valign="top">
<a href="#ODR_OPEN_DATABASE_RESOURCE">Method may fail to close database resource</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson10.injectableQueryAvailability(String) may fail to close Statement<br/>
<br/>
<br/>In file SqlInjectionLesson10.java SqlInjectionLesson10.java,
line 69 69<br/>In class org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson10<br/>In method org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson10.injectableQueryAvailability(String)<br/>Need to close java.sql.Statement <br/>At SqlInjectionLesson10.java:[line 69]<br/>At SqlInjectionLesson10.java:[line 69]</p>
</td>
</tr>
<tr class="tablerow0">
<td width="20%" valign="top">
<a href="#ODR_OPEN_DATABASE_RESOURCE">Method may fail to close database resource</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson2.injectableQuery(String) may fail to close Statement<br/>
<br/>
<br/>In file SqlInjectionLesson2.java SqlInjectionLesson2.java,
line 64 64<br/>In class org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson2<br/>In method org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson2.injectableQuery(String)<br/>Need to close java.sql.Statement <br/>At SqlInjectionLesson2.java:[line 64]<br/>At SqlInjectionLesson2.java:[line 64]</p>
</td>
</tr>
<tr class="tablerow1">
<td width="20%" valign="top">
<a href="#ODR_OPEN_DATABASE_RESOURCE">Method may fail to close database resource</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson3.injectableQuery(String) may fail to close Statement<br/>
<br/>
<br/>In file SqlInjectionLesson3.java SqlInjectionLesson3.java,
line 62 62<br/>In class org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson3<br/>In method org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson3.injectableQuery(String)<br/>Need to close java.sql.Statement <br/>At SqlInjectionLesson3.java:[line 62]<br/>At SqlInjectionLesson3.java:[line 62]</p>
</td>
</tr>
<tr class="tablerow0">
<td width="20%" valign="top">
<a href="#ODR_OPEN_DATABASE_RESOURCE">Method may fail to close database resource</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson5Test.removeGrant() may fail to close Connection<br/>
<br/>
<br/>In file SqlInjectionLesson5Test.java SqlInjectionLesson5Test.java,
line 44 44<br/>In class org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson5Test<br/>In method org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson5Test.removeGrant()<br/>Need to close java.sql.Connection <br/>At SqlInjectionLesson5Test.java:[line 44]<br/>At SqlInjectionLesson5Test.java:[line 44]</p>
</td>
</tr>
<tr class="tablerow1">
<td width="20%" valign="top">
<a href="#ODR_OPEN_DATABASE_RESOURCE">Method may fail to close database resource</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson5Test.removeGrant() may fail to close PreparedStatement<br/>
<br/>
<br/>In file SqlInjectionLesson5Test.java SqlInjectionLesson5Test.java,
line 45 45<br/>In class org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson5Test<br/>In method org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson5Test.removeGrant()<br/>Need to close java.sql.PreparedStatement <br/>At SqlInjectionLesson5Test.java:[line 45]<br/>At SqlInjectionLesson5Test.java:[line 45]</p>
</td>
</tr>
<tr class="tablerow0">
<td width="20%" valign="top">
<a href="#ODR_OPEN_DATABASE_RESOURCE">Method may fail to close database resource</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson5b.injectableQuery(String, String) may fail to close PreparedStatement<br/>
<br/>
<br/>In file SqlInjectionLesson5b.java SqlInjectionLesson5b.java,
line 65 65<br/>In class org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson5b<br/>In method org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson5b.injectableQuery(String, String)<br/>Need to close java.sql.PreparedStatement <br/>At SqlInjectionLesson5b.java:[line 65]<br/>At SqlInjectionLesson5b.java:[line 65]</p>
</td>
</tr>
<tr class="tablerow1">
<td width="20%" valign="top">
<a href="#ODR_OPEN_DATABASE_RESOURCE">Method may fail to close database resource</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson8.injectableQueryConfidentiality(String, String) may fail to close Statement<br/>
<br/>
<br/>In file SqlInjectionLesson8.java SqlInjectionLesson8.java,
line 75 75<br/>In class org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson8<br/>In method org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson8.injectableQueryConfidentiality(String, String)<br/>Need to close java.sql.Statement <br/>At SqlInjectionLesson8.java:[line 75]<br/>At SqlInjectionLesson8.java:[line 75]</p>
</td>
</tr>
<tr class="tablerow0">
<td width="20%" valign="top">
<a href="#ODR_OPEN_DATABASE_RESOURCE">Method may fail to close database resource</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson9.injectableQueryIntegrity(String, String) may fail to close Statement<br/>
<br/>
<br/>In file SqlInjectionLesson9.java SqlInjectionLesson9.java,
line 74 74<br/>In class org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson9<br/>In method org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson9.injectableQueryIntegrity(String, String)<br/>Need to close java.sql.Statement <br/>At SqlInjectionLesson9.java:[line 74]<br/>At SqlInjectionLesson9.java:[line 74]</p>
</td>
</tr>
<tr class="tablerow1">
<td width="20%" valign="top">
<a href="#OS_OPEN_STREAM">Method may fail to close stream</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>org.dummy.insecure.framework.VulnerableTaskHolder.readObject(ObjectInputStream) may fail to close stream<br/>
<br/>
<br/>In file VulnerableTaskHolder.java VulnerableTaskHolder.java,
line 66 66<br/>In class org.dummy.insecure.framework.VulnerableTaskHolder<br/>In method org.dummy.insecure.framework.VulnerableTaskHolder.readObject(ObjectInputStream)<br/>Need to close java.io.Reader <br/>At VulnerableTaskHolder.java:[line 66]<br/>At VulnerableTaskHolder.java:[line 66]</p>
</td>
</tr>
<tr class="tablerow0">
<td width="20%" valign="top">
<a href="#OS_OPEN_STREAM">Method may fail to close stream</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>org.owasp.webgoat.lessons.pathtraversal.ProfileZipSlip.processZipUpload(MultipartFile) may fail to close stream<br/>
<br/>
<br/>In file ProfileZipSlip.java ProfileZipSlip.java,
line 69 69<br/>In class org.owasp.webgoat.lessons.pathtraversal.ProfileZipSlip<br/>In method org.owasp.webgoat.lessons.pathtraversal.ProfileZipSlip.processZipUpload(MultipartFile)<br/>Need to close java.util.zip.ZipFile <br/>At ProfileZipSlip.java:[line 69]<br/>At ProfileZipSlip.java:[line 69]</p>
</td>
</tr>
<tr class="tablerow1">
<td width="20%" valign="top">
<a href="#RV_RETURN_VALUE_IGNORED_BAD_PRACTICE">Method ignores exceptional return value</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>Exceptional return value of java.io.File.mkdir() ignored in org.owasp.webgoat.lessons.clientsidefiltering.Salaries.copyFiles()<br/>
<br/>
<br/>In file Salaries.java Salaries.java,
line 62 62<br/>In class org.owasp.webgoat.lessons.clientsidefiltering.Salaries<br/>In method org.owasp.webgoat.lessons.clientsidefiltering.Salaries.copyFiles()<br/>Called method java.io.File.mkdir()<br/>At Salaries.java:[line 62]<br/>At Salaries.java:[line 62]</p>
</td>
</tr>
<tr class="tablerow0">
<td width="20%" valign="top">
<a href="#RV_RETURN_VALUE_IGNORED_BAD_PRACTICE">Method ignores exceptional return value</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>Exceptional return value of java.io.File.createNewFile() ignored in org.owasp.webgoat.lessons.pathtraversal.ProfileUploadBase.execute(MultipartFile, String)<br/>
<br/>
<br/>In file ProfileUploadBase.java ProfileUploadBase.java,
line 43 43<br/>In class org.owasp.webgoat.lessons.pathtraversal.ProfileUploadBase<br/>In method org.owasp.webgoat.lessons.pathtraversal.ProfileUploadBase.execute(MultipartFile, String)<br/>Called method java.io.File.createNewFile()<br/>At ProfileUploadBase.java:[line 43]<br/>At ProfileUploadBase.java:[line 43]</p>
</td>
</tr>
<tr class="tablerow1">
<td width="20%" valign="top">
<a href="#RV_RETURN_VALUE_IGNORED_BAD_PRACTICE">Method ignores exceptional return value</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>Exceptional return value of java.io.File.mkdirs() ignored in new org.owasp.webgoat.lessons.pathtraversal.ProfileUploadRetrieval(String)<br/>
<br/>
<br/>In file ProfileUploadRetrieval.java ProfileUploadRetrieval.java,
line 48 48<br/>In class org.owasp.webgoat.lessons.pathtraversal.ProfileUploadRetrieval<br/>In method new org.owasp.webgoat.lessons.pathtraversal.ProfileUploadRetrieval(String)<br/>Called method java.io.File.mkdirs()<br/>At ProfileUploadRetrieval.java:[line 48]<br/>At ProfileUploadRetrieval.java:[line 48]</p>
</td>
</tr>
<tr class="tablerow0">
<td width="20%" valign="top">
<a href="#RV_RETURN_VALUE_IGNORED_BAD_PRACTICE">Method ignores exceptional return value</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>Exceptional return value of java.io.File.mkdirs() ignored in org.owasp.webgoat.lessons.xxe.BlindSendFileAssignment.createSecretFileWithRandomContents(WebGoatUser)<br/>
<br/>
<br/>In file BlindSendFileAssignment.java BlindSendFileAssignment.java,
line 76 76<br/>In class org.owasp.webgoat.lessons.xxe.BlindSendFileAssignment<br/>In method org.owasp.webgoat.lessons.xxe.BlindSendFileAssignment.createSecretFileWithRandomContents(WebGoatUser)<br/>Called method java.io.File.mkdirs()<br/>At BlindSendFileAssignment.java:[line 76]<br/>At BlindSendFileAssignment.java:[line 76]</p>
</td>
</tr>
<tr class="tablerow1">
<td width="20%" valign="top">
<a href="#RV_RETURN_VALUE_IGNORED_BAD_PRACTICE">Method ignores exceptional return value</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>Exceptional return value of java.io.File.delete() ignored in org.owasp.webgoat.webwolf.FileServer.getFiles(HttpServletRequest)<br/>
<br/>
<br/>In file FileServer.java FileServer.java,
line 107 107<br/>In class org.owasp.webgoat.webwolf.FileServer<br/>In method org.owasp.webgoat.webwolf.FileServer.getFiles(HttpServletRequest)<br/>Called method java.io.File.delete()<br/>At FileServer.java:[line 107]<br/>At FileServer.java:[line 107]</p>
</td>
</tr>
<tr class="tablerow0">
<td width="20%" valign="top">
<a href="#RV_RETURN_VALUE_IGNORED_BAD_PRACTICE">Method ignores exceptional return value</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>Exceptional return value of java.io.File.mkdirs() ignored in org.owasp.webgoat.webwolf.FileServer.importFile(MultipartFile)<br/>
<br/>
<br/>In file FileServer.java FileServer.java,
line 77 77<br/>In class org.owasp.webgoat.webwolf.FileServer<br/>In method org.owasp.webgoat.webwolf.FileServer.importFile(MultipartFile)<br/>Called method java.io.File.mkdirs()<br/>At FileServer.java:[line 77]<br/>At FileServer.java:[line 77]</p>
</td>
</tr>
<tr class="tablerow1">
<td width="20%" valign="top">
<a href="#RV_RETURN_VALUE_IGNORED_BAD_PRACTICE">Method ignores exceptional return value</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>Exceptional return value of java.io.File.mkdirs() ignored in org.owasp.webgoat.webwolf.MvcConfiguration.createDirectory()<br/>
<br/>
<br/>In file MvcConfiguration.java MvcConfiguration.java,
line 64 64<br/>In class org.owasp.webgoat.webwolf.MvcConfiguration<br/>In method org.owasp.webgoat.webwolf.MvcConfiguration.createDirectory()<br/>Called method java.io.File.mkdirs()<br/>At MvcConfiguration.java:[line 64]<br/>At MvcConfiguration.java:[line 64]</p>
</td>
</tr>
</table>
<p>
<br/>
<br/>
</p>
<h2>
<a name="Warnings_CORRECTNESS">Correctness Warnings</a>
</h2>
<table class="warningtable"
width="100%"
cellspacing="2"
cellpadding="5">
<tr class="tableheader">
<th align="left">Warning</th>
<th align="left">Priority</th>
<th align="left">Details</th>
</tr>
<tr class="tablerow1">
<td width="20%" valign="top">
<a href="#NP_NULL_PARAM_DEREF">Method call passes null for non-null parameter</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>Null passed for non-null parameter of new String(byte[], Charset) in org.owasp.webgoat.container.LessonTemplateResolver.computeTemplateResource(IEngineConfiguration, String, String, String, String, Map)<br/>
<br/>
<br/>In file LessonTemplateResolver.java LessonTemplateResolver.java LessonTemplateResolver.java LessonTemplateResolver.java,
line 88 76 83 84<br/>In class org.owasp.webgoat.container.LessonTemplateResolver<br/>In method org.owasp.webgoat.container.LessonTemplateResolver.computeTemplateResource(IEngineConfiguration, String, String, String, String, Map)<br/>Called method new String(byte[], Charset)<br/>Argument 1 might be null but must not be null<br/>Value loaded from resource<br/>Method invoked at LessonTemplateResolver.java:[line 88]<br/>Null value at LessonTemplateResolver.java:[line 76]<br/>Known null at LessonTemplateResolver.java:[line 83]<br/>Known null at LessonTemplateResolver.java:[line 84]</p>
</td>
</tr>
<tr class="tablerow0">
<td width="20%" valign="top">
<a href="#RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE">Nullcheck of value previously dereferenced</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>Nullcheck of statement at line 27 of value previously dereferenced in org.owasp.webgoat.container.lessons.LessonConnectionInvocationHandler.invoke(Object, Method, Object[])<br/>
<br/>
<br/>In file LessonConnectionInvocationHandler.java LessonConnectionInvocationHandler.java LessonConnectionInvocationHandler.java,
line 27 28 28<br/>In class org.owasp.webgoat.container.lessons.LessonConnectionInvocationHandler<br/>In method org.owasp.webgoat.container.lessons.LessonConnectionInvocationHandler.invoke(Object, Method, Object[])<br/>Value loaded from statement<br/>Return value of java.sql.Connection.createStatement() of type java.sql.Statement<br/>At LessonConnectionInvocationHandler.java:[line 27]<br/>Redundant null check at LessonConnectionInvocationHandler.java:[line 28]<br/>Redundant null check at LessonConnectionInvocationHandler.java:[line 28]</p>
</td>
</tr>
<tr class="tablerow1">
<td width="20%" valign="top">
<a href="#RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE">Nullcheck of value previously dereferenced</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>Nullcheck of connection at line 59 of value previously dereferenced in org.owasp.webgoat.lessons.challenges.challenge5.Assignment5.login(String, String)<br/>
<br/>
<br/>In file Assignment5.java Assignment5.java Assignment5.java,
line 59 72 72<br/>In class org.owasp.webgoat.lessons.challenges.challenge5.Assignment5<br/>In method org.owasp.webgoat.lessons.challenges.challenge5.Assignment5.login(String, String)<br/>Value loaded from connection<br/>Return value of org.owasp.webgoat.container.LessonDataSource.getConnection() of type java.sql.Connection<br/>At Assignment5.java:[line 59]<br/>Redundant null check at Assignment5.java:[line 72]<br/>Redundant null check at Assignment5.java:[line 72]</p>
</td>
</tr>
<tr class="tablerow0">
<td width="20%" valign="top">
<a href="#RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE">Nullcheck of value previously dereferenced</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>Nullcheck of connection at line 88 of value previously dereferenced in org.owasp.webgoat.lessons.jwt.JWTFinalEndpoint$1.resolveSigningKeyBytes(JwsHeader, Claims)<br/>
<br/>
<br/>In file JWTFinalEndpoint.java JWTFinalEndpoint.java JWTFinalEndpoint.java,
line 88 94 94<br/>In class org.owasp.webgoat.lessons.jwt.JWTFinalEndpoint$1<br/>In method org.owasp.webgoat.lessons.jwt.JWTFinalEndpoint$1.resolveSigningKeyBytes(JwsHeader, Claims)<br/>Value loaded from connection<br/>Return value of org.owasp.webgoat.container.LessonDataSource.getConnection() of type java.sql.Connection<br/>At JWTFinalEndpoint.java:[line 88]<br/>Redundant null check at JWTFinalEndpoint.java:[line 94]<br/>Redundant null check at JWTFinalEndpoint.java:[line 94]</p>
</td>
</tr>
<tr class="tablerow1">
<td width="20%" valign="top">
<a href="#RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE">Nullcheck of value previously dereferenced</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>Nullcheck of connection at line 68 of value previously dereferenced in org.owasp.webgoat.lessons.sqlinjection.advanced.SqlInjectionChallenge.registerNewUser(String, String, String)<br/>
<br/>
<br/>In file SqlInjectionChallenge.java SqlInjectionChallenge.java SqlInjectionChallenge.java,
line 68 86 86<br/>In class org.owasp.webgoat.lessons.sqlinjection.advanced.SqlInjectionChallenge<br/>In method org.owasp.webgoat.lessons.sqlinjection.advanced.SqlInjectionChallenge.registerNewUser(String, String, String)<br/>Value loaded from connection<br/>Return value of org.owasp.webgoat.container.LessonDataSource.getConnection() of type java.sql.Connection<br/>At SqlInjectionChallenge.java:[line 68]<br/>Redundant null check at SqlInjectionChallenge.java:[line 86]<br/>Redundant null check at SqlInjectionChallenge.java:[line 86]</p>
</td>
</tr>
<tr class="tablerow0">
<td width="20%" valign="top">
<a href="#RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE">Nullcheck of value previously dereferenced</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>Nullcheck of connection at line 56 of value previously dereferenced in org.owasp.webgoat.lessons.sqlinjection.advanced.SqlInjectionChallengeLogin.login(String, String)<br/>
<br/>
<br/>In file SqlInjectionChallengeLogin.java SqlInjectionChallengeLogin.java SqlInjectionChallengeLogin.java,
line 56 69 69<br/>In class org.owasp.webgoat.lessons.sqlinjection.advanced.SqlInjectionChallengeLogin<br/>In method org.owasp.webgoat.lessons.sqlinjection.advanced.SqlInjectionChallengeLogin.login(String, String)<br/>Value loaded from connection<br/>Return value of org.owasp.webgoat.container.LessonDataSource.getConnection() of type java.sql.Connection<br/>At SqlInjectionChallengeLogin.java:[line 56]<br/>Redundant null check at SqlInjectionChallengeLogin.java:[line 69]<br/>Redundant null check at SqlInjectionChallengeLogin.java:[line 69]</p>
</td>
</tr>
<tr class="tablerow1">
<td width="20%" valign="top">
<a href="#RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE">Nullcheck of value previously dereferenced</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>Nullcheck of connection at line 72 of value previously dereferenced in org.owasp.webgoat.lessons.sqlinjection.advanced.SqlInjectionLesson6a.injectableQuery(String)<br/>
<br/>
<br/>In file SqlInjectionLesson6a.java SqlInjectionLesson6a.java SqlInjectionLesson6a.java,
line 72 110 110<br/>In class org.owasp.webgoat.lessons.sqlinjection.advanced.SqlInjectionLesson6a<br/>In method org.owasp.webgoat.lessons.sqlinjection.advanced.SqlInjectionLesson6a.injectableQuery(String)<br/>Value loaded from connection<br/>Return value of org.owasp.webgoat.container.LessonDataSource.getConnection() of type java.sql.Connection<br/>At SqlInjectionLesson6a.java:[line 72]<br/>Redundant null check at SqlInjectionLesson6a.java:[line 110]<br/>Redundant null check at SqlInjectionLesson6a.java:[line 110]</p>
</td>
</tr>
<tr class="tablerow0">
<td width="20%" valign="top">
<a href="#RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE">Nullcheck of value previously dereferenced</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>Nullcheck of statement at line 74 of value previously dereferenced in org.owasp.webgoat.lessons.sqlinjection.advanced.SqlInjectionLesson6a.injectableQuery(String)<br/>
<br/>
<br/>In file SqlInjectionLesson6a.java SqlInjectionLesson6a.java SqlInjectionLesson6a.java,
line 74 107 107<br/>In class org.owasp.webgoat.lessons.sqlinjection.advanced.SqlInjectionLesson6a<br/>In method org.owasp.webgoat.lessons.sqlinjection.advanced.SqlInjectionLesson6a.injectableQuery(String)<br/>Value loaded from statement<br/>Return value of java.sql.Connection.createStatement(int, int) of type java.sql.Statement<br/>At SqlInjectionLesson6a.java:[line 74]<br/>Redundant null check at SqlInjectionLesson6a.java:[line 107]<br/>Redundant null check at SqlInjectionLesson6a.java:[line 107]</p>
</td>
</tr>
<tr class="tablerow1">
<td width="20%" valign="top">
<a href="#RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE">Nullcheck of value previously dereferenced</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>Nullcheck of connection at line 69 of value previously dereferenced in org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson10.injectableQueryAvailability(String)<br/>
<br/>
<br/>In file SqlInjectionLesson10.java SqlInjectionLesson10.java SqlInjectionLesson10.java,
line 69 104 104<br/>In class org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson10<br/>In method org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson10.injectableQueryAvailability(String)<br/>Value loaded from connection<br/>Return value of org.owasp.webgoat.container.LessonDataSource.getConnection() of type java.sql.Connection<br/>At SqlInjectionLesson10.java:[line 69]<br/>Redundant null check at SqlInjectionLesson10.java:[line 104]<br/>Redundant null check at SqlInjectionLesson10.java:[line 104]</p>
</td>
</tr>
<tr class="tablerow0">
<td width="20%" valign="top">
<a href="#RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE">Nullcheck of value previously dereferenced</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>Nullcheck of connection at line 64 of value previously dereferenced in org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson2.injectableQuery(String)<br/>
<br/>
<br/>In file SqlInjectionLesson2.java SqlInjectionLesson2.java SqlInjectionLesson2.java,
line 64 77 77<br/>In class org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson2<br/>In method org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson2.injectableQuery(String)<br/>Value loaded from connection<br/>Return value of org.owasp.webgoat.container.LessonDataSource.getConnection() of type java.sql.Connection<br/>At SqlInjectionLesson2.java:[line 64]<br/>Redundant null check at SqlInjectionLesson2.java:[line 77]<br/>Redundant null check at SqlInjectionLesson2.java:[line 77]</p>
</td>
</tr>
<tr class="tablerow1">
<td width="20%" valign="top">
<a href="#RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE">Nullcheck of value previously dereferenced</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>Nullcheck of connection at line 60 of value previously dereferenced in org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson3.injectableQuery(String)<br/>
<br/>
<br/>In file SqlInjectionLesson3.java SqlInjectionLesson3.java SqlInjectionLesson3.java,
line 60 80 80<br/>In class org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson3<br/>In method org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson3.injectableQuery(String)<br/>Value loaded from connection<br/>Return value of org.owasp.webgoat.container.LessonDataSource.getConnection() of type java.sql.Connection<br/>At SqlInjectionLesson3.java:[line 60]<br/>Redundant null check at SqlInjectionLesson3.java:[line 80]<br/>Redundant null check at SqlInjectionLesson3.java:[line 80]</p>
</td>
</tr>
<tr class="tablerow0">
<td width="20%" valign="top">
<a href="#RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE">Nullcheck of value previously dereferenced</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>Nullcheck of statement at line 63 of value previously dereferenced in org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson3.injectableQuery(String)<br/>
<br/>
<br/>In file SqlInjectionLesson3.java SqlInjectionLesson3.java SqlInjectionLesson3.java,
line 63 77 77<br/>In class org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson3<br/>In method org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson3.injectableQuery(String)<br/>Value loaded from statement<br/>Return value of java.sql.Connection.createStatement(int, int) of type java.sql.Statement<br/>At SqlInjectionLesson3.java:[line 63]<br/>Redundant null check at SqlInjectionLesson3.java:[line 77]<br/>Redundant null check at SqlInjectionLesson3.java:[line 77]</p>
</td>
</tr>
<tr class="tablerow1">
<td width="20%" valign="top">
<a href="#RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE">Nullcheck of value previously dereferenced</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>Nullcheck of connection at line 61 of value previously dereferenced in org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson4.injectableQuery(String)<br/>
<br/>
<br/>In file SqlInjectionLesson4.java SqlInjectionLesson4.java SqlInjectionLesson4.java,
line 61 76 76<br/>In class org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson4<br/>In method org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson4.injectableQuery(String)<br/>Value loaded from connection<br/>Return value of org.owasp.webgoat.container.LessonDataSource.getConnection() of type java.sql.Connection<br/>At SqlInjectionLesson4.java:[line 61]<br/>Redundant null check at SqlInjectionLesson4.java:[line 76]<br/>Redundant null check at SqlInjectionLesson4.java:[line 76]</p>
</td>
</tr>
<tr class="tablerow0">
<td width="20%" valign="top">
<a href="#RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE">Nullcheck of value previously dereferenced</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>Nullcheck of statement at line 62 of value previously dereferenced in org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson4.injectableQuery(String)<br/>
<br/>
<br/>In file SqlInjectionLesson4.java SqlInjectionLesson4.java SqlInjectionLesson4.java,
line 62 73 73<br/>In class org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson4<br/>In method org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson4.injectableQuery(String)<br/>Value loaded from statement<br/>Return value of java.sql.Connection.createStatement(int, int) of type java.sql.Statement<br/>At SqlInjectionLesson4.java:[line 62]<br/>Redundant null check at SqlInjectionLesson4.java:[line 73]<br/>Redundant null check at SqlInjectionLesson4.java:[line 73]</p>
</td>
</tr>
<tr class="tablerow1">
<td width="20%" valign="top">
<a href="#RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE">Nullcheck of value previously dereferenced</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>Nullcheck of connection at line 60 of value previously dereferenced in org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson5.createUser()<br/>
<br/>
<br/>In file SqlInjectionLesson5.java SqlInjectionLesson5.java SqlInjectionLesson5.java,
line 60 63 63<br/>In class org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson5<br/>In method org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson5.createUser()<br/>Value loaded from connection<br/>Return value of org.owasp.webgoat.container.LessonDataSource.getConnection() of type java.sql.Connection<br/>At SqlInjectionLesson5.java:[line 60]<br/>Redundant null check at SqlInjectionLesson5.java:[line 63]<br/>Redundant null check at SqlInjectionLesson5.java:[line 63]</p>
</td>
</tr>
<tr class="tablerow0">
<td width="20%" valign="top">
<a href="#RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE">Nullcheck of value previously dereferenced</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>Nullcheck of connection at line 78 of value previously dereferenced in org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson5.injectableQuery(String)<br/>
<br/>
<br/>In file SqlInjectionLesson5.java SqlInjectionLesson5.java SqlInjectionLesson5.java,
line 78 86 86<br/>In class org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson5<br/>In method org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson5.injectableQuery(String)<br/>Value loaded from connection<br/>Return value of org.owasp.webgoat.container.LessonDataSource.getConnection() of type java.sql.Connection<br/>At SqlInjectionLesson5.java:[line 78]<br/>Redundant null check at SqlInjectionLesson5.java:[line 86]<br/>Redundant null check at SqlInjectionLesson5.java:[line 86]</p>
</td>
</tr>
<tr class="tablerow1">
<td width="20%" valign="top">
<a href="#RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE">Nullcheck of value previously dereferenced</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>Nullcheck of statement at line 80 of value previously dereferenced in org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson5.injectableQuery(String)<br/>
<br/>
<br/>In file SqlInjectionLesson5.java SqlInjectionLesson5.java SqlInjectionLesson5.java,
line 80 85 85<br/>In class org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson5<br/>In method org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson5.injectableQuery(String)<br/>Value loaded from statement<br/>Return value of java.sql.Connection.createStatement(int, int) of type java.sql.Statement<br/>At SqlInjectionLesson5.java:[line 80]<br/>Redundant null check at SqlInjectionLesson5.java:[line 85]<br/>Redundant null check at SqlInjectionLesson5.java:[line 85]</p>
</td>
</tr>
<tr class="tablerow0">
<td width="20%" valign="top">
<a href="#RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE">Nullcheck of value previously dereferenced</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>Nullcheck of connection at line 65 of value previously dereferenced in org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson5a.injectableQuery(String)<br/>
<br/>
<br/>In file SqlInjectionLesson5a.java SqlInjectionLesson5a.java SqlInjectionLesson5a.java,
line 65 95 95<br/>In class org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson5a<br/>In method org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson5a.injectableQuery(String)<br/>Value loaded from connection<br/>Return value of org.owasp.webgoat.container.LessonDataSource.getConnection() of type java.sql.Connection<br/>At SqlInjectionLesson5a.java:[line 65]<br/>Redundant null check at SqlInjectionLesson5a.java:[line 95]<br/>Redundant null check at SqlInjectionLesson5a.java:[line 95]</p>
</td>
</tr>
<tr class="tablerow1">
<td width="20%" valign="top">
<a href="#RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE">Nullcheck of value previously dereferenced</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>Nullcheck of statement at line 67 of value previously dereferenced in org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson5a.injectableQuery(String)<br/>
<br/>
<br/>In file SqlInjectionLesson5a.java SqlInjectionLesson5a.java SqlInjectionLesson5a.java,
line 67 92 92<br/>In class org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson5a<br/>In method org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson5a.injectableQuery(String)<br/>Value loaded from statement<br/>Return value of java.sql.Connection.createStatement(int, int) of type java.sql.Statement<br/>At SqlInjectionLesson5a.java:[line 67]<br/>Redundant null check at SqlInjectionLesson5a.java:[line 92]<br/>Redundant null check at SqlInjectionLesson5a.java:[line 92]</p>
</td>
</tr>
<tr class="tablerow0">
<td width="20%" valign="top">
<a href="#RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE">Nullcheck of value previously dereferenced</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>Nullcheck of connection at line 65 of value previously dereferenced in org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson5b.injectableQuery(String, String)<br/>
<br/>
<br/>In file SqlInjectionLesson5b.java SqlInjectionLesson5b.java SqlInjectionLesson5b.java,
line 65 124 124<br/>In class org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson5b<br/>In method org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson5b.injectableQuery(String, String)<br/>Value loaded from connection<br/>Return value of org.owasp.webgoat.container.LessonDataSource.getConnection() of type java.sql.Connection<br/>At SqlInjectionLesson5b.java:[line 65]<br/>Redundant null check at SqlInjectionLesson5b.java:[line 124]<br/>Redundant null check at SqlInjectionLesson5b.java:[line 124]</p>
</td>
</tr>
<tr class="tablerow1">
<td width="20%" valign="top">
<a href="#RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE">Nullcheck of value previously dereferenced</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>Nullcheck of connection at line 75 of value previously dereferenced in org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson8.injectableQueryConfidentiality(String, String)<br/>
<br/>
<br/>In file SqlInjectionLesson8.java SqlInjectionLesson8.java SqlInjectionLesson8.java,
line 75 109 109<br/>In class org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson8<br/>In method org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson8.injectableQueryConfidentiality(String, String)<br/>Value loaded from connection<br/>Return value of org.owasp.webgoat.container.LessonDataSource.getConnection() of type java.sql.Connection<br/>At SqlInjectionLesson8.java:[line 75]<br/>Redundant null check at SqlInjectionLesson8.java:[line 109]<br/>Redundant null check at SqlInjectionLesson8.java:[line 109]</p>
</td>
</tr>
<tr class="tablerow0">
<td width="20%" valign="top">
<a href="#RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE">Nullcheck of value previously dereferenced</a>
</td>
<td width="10%" valign="top">Medium</td>
<td width="70%">
<p>Nullcheck of statement at line 108 of value previously dereferenced in org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson9.checkSalaryRanking(Connection, StringBuilder)<br/>
<br/>
<br/>In file SqlInjectionLesson9.java SqlInjectionLesson9.java SqlInjectionLesson9.java,
line 108 121 121<br/>In class org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson9<br/>In method org.owasp.webgoat.lessons.sqlinjection.introduction.SqlInjectionLesson9.checkSalaryRanking(Connection, StringBuilder)<br/>Value loaded from statement<br/>Return value of java.sql.Connection.createStatement(int, int) of type java.sql.Statement<br/>At SqlInjectionLesson9.java:[line 108]<br/>Redundant null check at SqlInjectionLesson9.java:[line 121]<br/>Redundant null check at SqlInjectionLesson9.java:[line 121]</p>
</td>
</tr>
<tr class="tablerow1">
<td width="20%" valign="top">
<a href="#RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE">Nullcheck of value previously dereferenced</a>
</td>