You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 3c61360
Browse filesBrowse the repository at this point in the historyBrowse files
Merge remote-tracking branch 'origin/main' into jasen/glm52-mi355x-atom-disagg-agentx
Resolve the perf-changelog conflict with prepare_perf_changelog_merge
resolve-conflict, which keeps this PR's entry as the tail append, and keep
both rows in runners/srt-slurm/patches/README.md: 602 from main and 604 from
this PR. All three patches apply in order on srt-slurm 545233a0d.
用 prepare_perf_changelog_merge resolve-conflict 解决 perf-changelog 冲突,
本 PR 的条目仍是末尾追加;runners/srt-slurm/patches/README.md 保留 main 的
602 和本 PR 的 604 两行。三个补丁按顺序都能打到 srt-slurm 545233a0d 上。
[skip-sweep]
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copy file name to clipboardExpand all lines: .github/PULL_REQUEST_TEMPLATE/pull_request_template.md
+2-2Lines changed: 2 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -32,8 +32,8 @@
32
32
-[ ] I have completed the AI model disclosure and kept it current
33
33
-[ ] I have tested my changes locally
34
34
-[ ] I have updated documentation if necessary
35
-
-[ ]**For every change that can affect benchmark performance and every recipe addition or modification, I have appended a new entry to the physical end of `inferencex-e2e/perf-changelog.yaml` and have not edited historical entries**
36
-
-[ ]**If this PR can affect benchmark performance or adds or modifies a recipe, it carries exactly one primary sweep label** (a maintainer applies it on fork PRs): `full-sweep-fail-fast` (recommended), `full-sweep-enabled`, or `non-canary-full-sweep-enabled`. Optional modifiers `all-evals`, `evals-only`, and `agentx-fast` require a primary label; the last two block reuse while applied.
35
+
-[ ]**If `python -m infx.matrix.changed --base origin/main` lists affected config keys, I have appended one new entry covering them to the physical end of `inferencex-e2e/perf-changelog.yaml`; if it lists none, I have added none. I have not edited historical entries**
36
+
-[ ]**If this PR appends an `inferencex-e2e/perf-changelog.yaml` entry, it carries exactly one primary sweep label** (a maintainer applies it on fork PRs): `full-sweep-fail-fast` (recommended), `full-sweep-enabled`, or `non-canary-full-sweep-enabled`. Optional modifiers `all-evals`, `evals-only`, and `agentx-fast` require a primary label; the last two block reuse while applied.
37
37
-[ ]**Before merging via reuse, an authorized maintainer (`OWNER`/`MEMBER`/`COLLABORATOR`) has commented `/use <run_id>` (or the legacy `/reuse-sweep-run`) on this PR**. Do this **only once there is a final full sweep that is all green with evals passing**, since after this comment the primary sweep label will no longer automatically kick off new sweeps. Remove and re-add the primary sweep label to force a new sweep.
Copy file name to clipboardExpand all lines: .github/workflows/claude.yml
+7-10Lines changed: 7 additions & 10 deletions
Original file line number
Diff line number
Diff line change
@@ -184,7 +184,7 @@ jobs:
184
184
- Only wait for the final successful run to complete before analyzing benchmark results
185
185
- Do NOT claim completion until the most recent job finishes and results are analyzed
186
186
- If jobs cannot be run, say exactly what you could not run and why
187
-
- **Important** Modify inferencex-e2e/perf-changelog.yaml for any config changes affecting performance
187
+
- **Important** Append an inferencex-e2e/perf-changelog.yaml entry when the change alters what any benchmark runs (see "Updating perf-changelog.yaml" below)
188
188
189
189
## Profiling (SGLang only)
190
190
When asked to profile a config, dispatch the `profile.yml` workflow. **Only SGLang configs can be profiled** — the profiler uses SGLang's `/start_profile` and `/stop_profile` HTTP endpoints. Reject profiling requests for vLLM, TRT, or other frameworks.
@@ -234,7 +234,7 @@ jobs:
234
234
235
235
## Updating perf-changelog.yaml
236
236
237
-
See `AGENTS.md` → "Non-negotiable benchmark invariants" for changelog rules and `inferencex-e2e/perf-changelog.yaml` for entry format. Required whenever you change image tags, env vars, or perf-affecting params in `inferencex-e2e/configs/*-master.yaml` or `inferencex-e2e/benchmarks/*.sh`. Use `XXX` as the PR-link placeholder until the PR exists.
237
+
See `AGENTS.md` → "Non-negotiable benchmark invariants" for changelog rules and `inferencex-e2e/perf-changelog.yaml` for entry format. Add an entry when the change alters what any benchmark runs: run `uv run python -m infx.matrix.changed --base origin/main` from `inferencex-e2e/` and cover every config key it lists; if it lists none (refactors, recipe moves, docs), add no entry. Use `XXX` as the PR-link placeholder until the PR exists.
238
238
239
239
If an entry uses `append-only: true`, require the generated base matrix to remain an immutable subset of the generated head matrix. New concurrency values or new recipe variants may be added inside a selected existing config/scenario, but no existing generated point may be removed or modified, and every addition must retain the target visual curve's single non-null image. Do not enforce a file allowlist: supporting code, benchmark scripts, launchers, helpers, and other files may change when their benchmark effect is exclusive to the corresponding newly appended points. All added changelog entries must be append-only, and eval modifiers are forbidden. Trace behavior through the complete diff; unguarded changes or paths reachable by an existing point are blocking.
240
240
@@ -397,15 +397,12 @@ jobs:
397
397
- For re-reviews, prefix summary with "Re-review:" and note what changed
398
398
399
399
## Master Config and Perf Changelog Validation:
400
-
When reviewing a PR, check if any of the following master config files were modified:
401
-
- `inferencex-e2e/configs/amd-master.yaml`
402
-
- `inferencex-e2e/configs/nvidia-master.yaml`
400
+
A PR needs an `inferencex-e2e/perf-changelog.yaml` entry exactly when it changes what a benchmark runs; the entry triggers result collection.
403
401
404
-
If either master config file was edited AND `inferencex-e2e/perf-changelog.yaml` was NOT edited in the same PR:
405
-
- This is a 🔴 **BLOCKING** issue
406
-
- Comment that `inferencex-e2e/perf-changelog.yaml` must also be updated when master config files are changed
407
-
- The perf-changelog entry should document what changed in the config and include the PR link
408
-
- Format: "Master config files were modified but `inferencex-e2e/perf-changelog.yaml` was not updated. When changing `inferencex-e2e/configs/amd-master.yaml` or `inferencex-e2e/configs/nvidia-master.yaml`, you must add a corresponding entry to `inferencex-e2e/perf-changelog.yaml` documenting the changes."
402
+
When a PR changes master configs, recipes, benchmark scripts, or launcher code and does NOT add a `inferencex-e2e/perf-changelog.yaml` entry, run `uv run python -m infx.matrix.changed --base origin/<base branch>` from `inferencex-e2e/`:
403
+
- If it lists changed config keys, this is a 🔴 **BLOCKING** issue. Format: "This PR changes benchmark points for <config keys> but adds no `inferencex-e2e/perf-changelog.yaml` entry. Append one entry covering these config keys to the end of the file."
404
+
- If it lists no changed config keys and the PR changes no benchmark script or launcher behavior that a benchmark runs, it is not an issue; do not comment on it. The tool does not see script or launcher code, so judge those changes from the diff and treat a run-affecting one without an entry as 🔴 **BLOCKING**.
405
+
- If it cannot run, say so in the summary comment and ask whether the change alters what any benchmark runs.
409
406
410
407
### Perf Changelog Entry Position:
411
408
`inferencex-e2e/perf-changelog.yaml` is read in chronological order — oldest entries at the top, newest at the bottom. New entries MUST be appended to the END of the file. Never insert in the middle or prepend.
Copy file name to clipboardExpand all lines: AGENTS.md
+2-2Lines changed: 2 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -137,8 +137,8 @@ inspect its generated fields, then collect applicable smoke, sweep, and eval evi
137
137
## Non-negotiable benchmark invariants
138
138
139
139
- Every priority-scheduled benchmark job on a self-hosted cluster must request exactly one `nodes:N` label, where `N` is the positive integer number of physical Slurm nodes required. Single-node jobs use `nodes:1`; generated multi-node jobs must forward their computed `node-count`. A queued job missing this label is ineligible for priority scheduling, and labels cannot be added retroactively, so fix the source branch and dispatch a new run.
140
-
-Every change that can affect benchmark performance and every recipe addition or modification requires a new `inferencex-e2e/perf-changelog.yaml`entry. The file is append-only and byte-sensitive. Preserve all existing bytes and separator whitespace, and append only at the tail.
141
-
- One PR maps to one `inferencex-e2e/perf-changelog.yaml` block. By convention, a PR with a perf changelog entry is a change that affects inference performance or otherwise requires a rerun to collect up-to-date results. That block may list one or more `config-keys` to run, but do not add a second block for the same PR, even when the change evolved across commits. Revise the PR's existing block so it describes the final state of the change.
140
+
-A change that alters what any benchmark runs needs a new `inferencex-e2e/perf-changelog.yaml` entry covering the affected config keys; the entry triggers result collection. A change that leaves every benchmark point unchanged (refactors, recipe moves, docs) needs none. For config and recipe changes, `python -m infx.matrix.changed --base origin/main` (run from `inferencex-e2e/`) lists the affected keys; if it lists none, add no entry. It does not see benchmark script or launcher code, so judge those changes by what they run. The file is append-only and byte-sensitive. Preserve all existing bytes and separator whitespace, and append only at the tail.
141
+
- One PR maps to at most one `inferencex-e2e/perf-changelog.yaml` block. That block may list one or more `config-keys` to run, but do not add a second block for the same PR, even when the change evolved across commits. Revise the PR's existing block so it describes the final state of the change.
142
142
- New `inferencex-e2e/perf-changelog.yaml` entries must be English-only. Do not add Chinese translations or bilingual descriptions; the bilingual README and GitHub-content rules do not apply to these entries. Leave historical entries unchanged.
143
143
- Multi-node srt-slurm changes update the recipe YAML and matching master config together. srt-slurm recipes, fixed-sequence and AgentX, are fragments that get the master image, model, precision (and fixed-sequence lengths) from the binder.
144
144
- Every speculative fixed-sequence benchmark renders prompts with the chat template: the binder (`inferencex-e2e/infx/srt_slurm/workload.py::bind_workload`) sets `benchmark.env.USE_CHAT_TEMPLATE: "true"` for single-node recipes that speculate, which `python3 -m infx.bench fixed-seq` (run by `srt_fixed_sequence.sh`) turns into `--use-chat-template` for the benchmark client.
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -27,7 +27,7 @@ Every PR description must include an **AI model disclosure** section inside a co
27
27
3. Ping a core maintainer on Slack for final approval, after obtaining the checklist sign-off when required.
28
28
4. An authorized maintainer posts `/use <run_id>` (see below) and the PR is merged via the reuse path.
29
29
30
-
**Performance changelog requirement:**Every change that can affect benchmark performance and every recipe addition or modification **MUST** append a new entry to the physical end of `inferencex-e2e/perf-changelog.yaml`. Historical entries **MUST NOT** be edited.
30
+
**Performance changelog:**A PR that changes what any benchmark runs **MUST** append one new entry covering the affected config keys to the physical end of `inferencex-e2e/perf-changelog.yaml`; `python -m infx.matrix.changed --base origin/main` (run from `inferencex-e2e/`) lists them. A PR that changes no benchmark point adds none. Historical entries **MUST NOT** be edited.
0 commit comments