refactor(e2e): verify mutation persistence via re-navigation

The update and default-address-toggle tests were asserting against DOM
state that persists regardless of mutation success. The form uses
uncontrolled inputs (defaultValue/defaultChecked), so user-typed values
survive React re-renders even when the MSW mutation fails silently.

Both tests now re-navigate after the mutation, forcing fresh component
mounts that can only render data from MSW closure state. This ensures
the assertions verify server-side persistence, not stale DOM values.

The completion signal (button text check) was also a race condition -
it could pass immediately before React re-rendered to the loading state.
Replaced with waitForLoadState('networkidle') which reliably waits for
the full action + revalidation cycle to complete.

Also uses MSW_SCENARIOS constant in smoke test for consistency.

Author: itsjustriley

e2e/fixtures/delivery-address-utils.ts

@@ -1,7 +1,6 @@
 import {expect, Locator, Page} from '@playwright/test';
 
 export const EMPTY_STATE_MESSAGE = 'You have no addresses saved.';
-const FORM_SUBMISSION_TIMEOUT_IN_MS = 10_000;
 
 export interface AddressFormData {
   firstName: string;
@@ -87,26 +86,20 @@ export class DeliveryAddressUtil {
     await this.fillAddressForm(form, data);
     const createButton = form.getByRole('button', {name: 'Create'});
     await createButton.click();
-    await expect(createButton).toHaveText('Create', {
-      timeout: FORM_SUBMISSION_TIMEOUT_IN_MS,
-    });
+    await this.page.waitForLoadState('networkidle');
   }
 
   async updateAddress(form: Locator, data: Partial<AddressFormData>) {
     await this.fillAddressForm(form, data);
     const saveButton = form.getByRole('button', {name: 'Save'});
     await saveButton.click();
-    await expect(saveButton).toHaveText('Save', {
-      timeout: FORM_SUBMISSION_TIMEOUT_IN_MS,
-    });
+    await this.page.waitForLoadState('networkidle');
   }
 
   async deleteAddress(form: Locator) {
     const deleteButton = form.getByRole('button', {name: 'Delete'});
     await deleteButton.click();
-    await expect(deleteButton).not.toBeVisible({
-      timeout: FORM_SUBMISSION_TIMEOUT_IN_MS,
-    });
+    await this.page.waitForLoadState('networkidle');
   }
 
   async assertAddressCount(count: number) {

e2e/specs/skeleton/deliveryAddresses.spec.ts

@@ -88,7 +88,11 @@ test.describe('Delivery Addresses', () => {
       await expect(targetForm.getByLabel('City')).not.toHaveValue(updatedCity);
       await addresses.updateAddress(targetForm, {city: updatedCity});
 
-      await expect(targetForm.getByLabel('City')).toHaveValue(updatedCity);
+      // Re-navigate to verify the mutation persisted in MSW closure state.
+      // Without this, the assertion would pass from the user-typed DOM value
+      // alone, since the form uses uncontrolled inputs (defaultValue).
+      await addresses.navigateToAddresses();
+      await addresses.assertAddressVisible({city: updatedCity});
     });
   });
 
@@ -106,8 +110,17 @@ test.describe('Delivery Addresses', () => {
 
       await addresses.updateAddress(secondForm, {defaultAddress: true});
 
-      await expect(secondForm.getByRole('checkbox')).toBeChecked();
-      await expect(firstForm.getByRole('checkbox')).not.toBeChecked();
+      // Re-navigate to verify the default toggle persisted in MSW state.
+      // The checkbox uses defaultChecked (uncontrolled), and key={address.id}
+      // is stable across default-toggle updates, so React reconciles in place
+      // without resetting the checkbox DOM state. Fresh mount is needed.
+      await addresses.navigateToAddresses();
+
+      const refreshedForms = addresses.getExistingAddresses();
+      await expect(
+        refreshedForms.first().getByRole('checkbox'),
+      ).not.toBeChecked();
+      await expect(refreshedForms.nth(1).getByRole('checkbox')).toBeChecked();
     });
   });
 

e2e/specs/smoke/account.spec.ts

@@ -1,9 +1,9 @@
-import {setTestStore, test} from '../../fixtures';
+import {setTestStore, test, MSW_SCENARIOS} from '../../fixtures';
 import {AccountUtil} from '../../fixtures/account-utils';
 
 setTestStore('mockShop', {
   mock: {
-    scenario: 'customer-account-logged-in',
+    scenario: MSW_SCENARIOS.customerAccountLoggedIn,
   },
 });