Skip to content

Commit dee7f13

Browse files
authored
fix: removes rr7 warn on dev.ts (#3499)
* feat: removes rr7 warning from dev.ts Removes the React Router v7 version check from the dev command as it was not accurately checking what is resolved in node_moduels * chore: adds in changeset
1 parent 4608ae1 commit dee7f13

File tree

3 files changed

+5
-134
lines changed

3 files changed

+5
-134
lines changed

.changeset/nine-beers-kiss.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@shopify/cli-hydrogen': patch
3+
---
4+
5+
Removes the React Router v7 version check from the dev command as was confusing from what was resolved in node_modules

packages/cli/src/commands/hydrogen/dev.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ import {
2828
import {spawnCodegenProcess} from '../../lib/codegen.js';
2929
import {getAllEnvironmentVariables} from '../../lib/environment-variables.js';
3030
import {displayDevUpgradeNotice} from './upgrade.js';
31-
import {checkReactRouterVersions} from '../../lib/react-router-version-check.js';
3231
import {
3332
getDebugBannerLine,
3433
startTunnelAndPushConfig,
@@ -344,11 +343,6 @@ export async function runDev({
344343

345344
const storefrontTitle = (await backgroundPromise).storefrontTitle;
346345

347-
// Check React Router versions before showing success banner
348-
if (!disableVersionCheck) {
349-
await checkReactRouterVersions(root);
350-
}
351-
352346
showSuccessBanner({
353347
disableVirtualRoutes,
354348
debug,

packages/cli/src/lib/react-router-version-check.ts

Lines changed: 0 additions & 128 deletions
This file was deleted.

0 commit comments

Comments
 (0)