[ResourceItem] Fix the property "url" does not prevent redirections while savebar activated #13898
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ResourceItem] Fix navigation when SaveBar is active
WHY are these changes introduced?
Fixes #13528
While the SaveBar is active (some modifications are not saved), a click on the ResourceItem component with the
url
property set correctly checks for the savebar status (the savebar vibrates) but does not prevent the redirection. The component was callinganchor.click()
which immediately triggered navigation before the async savebar confirmation could complete.WHAT is this pull request doing?
This PR modifies the ResourceItem component's click handling to properly respect SaveBar state:
Before:
url
would navigate immediately on clickAfter:
event.preventDefault()
shopify.saveBar.leaveConfirmation()
before navigatingKey changes:
event.preventDefault()
inhandleClick
method to stop immediate navigationhandleNavigationWithSaveBarCheck()
method to handle async SaveBar confirmationwindow.location.href
only occurs after confirmationThis ensures consistent behavior with the documented workaround of using
onClick
with manualshopify.saveBar.leaveConfirmation()
calls, but built directly into the component.How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Testing instructions:
url
propertiesshopify.saveBar.show('test-savebar')
🎩 checklist
README.md
with documentation changes