Skip to content

Commit bee5089

Browse files
authored
Try reproducing the MinGW hang on time command (ruby#6168)
to see if it really exits correctly. GitHub Support asked me to confirm the command is exiting correctly.
1 parent 5d5c1d0 commit bee5089

File tree

2 files changed

+1
-8
lines changed

2 files changed

+1
-8
lines changed

.github/workflows/mingw.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ jobs:
135135
run: |
136136
# Actions uses UTF8, causes test failures, similar to normal OS setup
137137
chcp.com 437
138-
make ${{ StartsWith(matrix.test_task, 'test/') && matrix.test_task || 'test-all' }}
138+
time make ${{ StartsWith(matrix.test_task, 'test/') && matrix.test_task || 'test-all' }}
139139
env:
140140
RUBY_TESTOPTS: >-
141141
-j${{env.TEST_JOBS}} --retry --job-status=normal --show-skip --timeout-scale=1.5

test/rinda/test_rinda.rb

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -496,20 +496,13 @@ class TupleSpaceProxyTest < Test::Unit::TestCase
496496
include TupleSpaceTestModule
497497

498498
def setup
499-
if RUBY_PLATFORM.match?(/mingw/)
500-
@omitted = true
501-
omit 'This test seems to randomly hang on GitHub Actions MinGW UCRT64'
502-
end
503499
super
504500
ThreadGroup.new.add(Thread.current)
505501
@ts_base = Rinda::TupleSpace.new(1)
506502
@ts = Rinda::TupleSpaceProxy.new(@ts_base)
507503
@server = DRb.start_service("druby://localhost:0")
508504
end
509505
def teardown
510-
return if @omitted
511-
@omitted = false
512-
513506
# implementation-dependent
514507
@ts_base.instance_eval{
515508
if th = @keeper

0 commit comments

Comments
 (0)