[Core] Fixing PHPUnit deprecations (dataProvider annotations)

Author: rbayet

src/module-elasticsuite-catalog-optimizer/Test/Unit/Model/Optimizer/PreviewTest.php

@@ -13,6 +13,7 @@
  */
 namespace Smile\ElasticsuiteCatalogOptimizer\Test\Unit\Model\Optimizer;
 
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 use ReflectionClass;
@@ -130,6 +131,7 @@ protected function setUp(): void
      * @param integer $category             Category
      * @param boolean $expectedResult       Expected result
      */
+    #[DataProvider('dataProvider')]
     public function testCanApply(
         $searchContainers,
         $name,

src/module-elasticsuite-catalog/Test/Unit/Helper/AbstractAttributeTest.php

@@ -14,6 +14,7 @@
 
 namespace Smile\ElasticsuiteCatalog\Test\Unit\Helper;
 
+use PHPUnit\Framework\Attributes\DataProvider;
 use Smile\ElasticsuiteCore\Api\Index\Mapping\FieldInterface;
 use Smile\ElasticsuiteCatalog\Helper\AbstractAttribute;
 use Smile\ElasticsuiteCore\Api\Index\MappingInterface;
@@ -42,6 +43,7 @@ class AbstractAttributeTest extends \PHPUnit\Framework\TestCase
      *
      * @return void
      */
+    #[DataProvider('attributeTypeProvider')]
     public function testFieldTypes($attributeId, $backendType, $usesSource, $sourceModel, $frontendClass, $expectedType)
     {
         $contextMock   = $this->createMock(\Magento\Framework\App\Helper\Context::class);

src/module-elasticsuite-core/Test/Unit/Helper/IndexSettingsTest.php

@@ -16,6 +16,7 @@
 use Magento\Framework\App\Config\ScopeConfigInterface;
 use Magento\Framework\App\Helper\Context;
 use Magento\Store\Model\StoreManagerInterface;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
 use Smile\ElasticsuiteCore\Helper\IndexSettings as IndexSettingsHelper;
 use Smile\ElasticsuiteCore\Index\Indices\Config as IndicesConfig;
@@ -43,6 +44,7 @@ class IndexSettingsTest extends TestCase
      *
      * @return void
      */
+    #[DataProvider('parseIndexNameDataProvider')]
     public function testParseIndexName(string $indexName, string $alias, string $suffixPattern, $expected)
     {
         $scopeConfigMock = $this->getMockBuilder(ScopeConfigInterface::class)->disableOriginalConstructor()->getMock();
@@ -96,7 +98,7 @@ public function testParseIndexName(string $indexName, string $alias, string $suf
      *
      * @return iterable
      */
-    public static function parseIndexNameDataProvider(): iterable
+    public function parseIndexNameDataProvider(): iterable
     {
         yield [
             'magento2_default_catalog_product_20250707_093823',

src/module-elasticsuite-core/Test/Unit/Index/Indices/ConfigTest.php

@@ -13,6 +13,7 @@
 
 namespace Smile\ElasticsuiteCore\Test\Unit\Index\Indices;
 
+use PHPUnit\Framework\Attributes\DataProvider;
 use Magento\Framework\Config\CacheInterface;
 use Magento\Framework\Serialize\SerializerInterface;
 use Smile\ElasticsuiteCore\Index\Indices\Config\Converter;
@@ -59,6 +60,7 @@ class ConfigTest extends \PHPUnit\Framework\TestCase
      *
      * @return void
      */
+    #[DataProvider('stringFieldDynamicConfigProvider')]
     public function testConfig($stringFieldDynamicConfig)
     {
         $config = new Config(

src/module-elasticsuite-core/Test/Unit/Index/Mapping/FieldTest.php

@@ -13,6 +13,7 @@
  */
 namespace Smile\ElasticsuiteCore\Test\Unit\Index\Mapping;
 
+use PHPUnit\Framework\Attributes\DataProvider;
 use Smile\ElasticsuiteCore\Index\Mapping\Field;
 use Smile\ElasticsuiteCore\Api\Index\Mapping\FieldInterface;
 use Smile\ElasticsuiteCore\Search\Request\SortOrderInterface;
@@ -166,6 +167,7 @@ public function testSimpleSearchableStringField()
      * @param bool  $isSearchable       Expected result for is_searchable property
      * @param bool  $isUsedInSpellcheck Expected result for is_used_in_spellcheck property
      */
+    #[DataProvider('getIsUsedInSpellcheckFieldConfigDataProvider')]
     public function testIsUsedInSpellcheckField($fieldConfig, $isSearchable, $isUsedInSpellcheck)
     {
         $fieldType   = FieldInterface::FIELD_TYPE_TEXT;
@@ -237,6 +239,7 @@ public function testTokenCountField()
      * @param int    $searchWeight       Expected result for search_weight property
      * @param string $defaultAnalyzer    Expected result for default_search_analyzer property
      */
+    #[DataProvider('getMergeConfigFieldConfigDataProvider')]
     public function testMergeConfig(
         $fieldConfig,
         $config,

src/module-elasticsuite-core/Test/Unit/Model/SearchTest.php

@@ -13,6 +13,7 @@
  */
 namespace Smile\ElasticsuiteCore\Test\Unit\Model;
 
+use PHPUnit\Framework\Attributes\DataProvider;
 use Smile\ElasticsuiteCore\Api\Search\ContextInterface;
 
 /**
@@ -28,13 +29,14 @@ class SearchTest extends \PHPUnit\Framework\TestCase
     /**
      * Test search response format.
      *
-     * @dataProvider dataprovider
+     * @dataProvider dataProvider
      *
-     * @param unknown $documents Search engine hits.
-     * @param unknown $docCount  Total number of docs that match the search.
+     * @param array $documents Search engine hits.
+     * @param int   $docCount  Total number of docs that match the search.
      *
      * @return void.
      */
+    #[DataProvider('dataProvider')]
     public function testSearch($documents, $docCount)
     {
         $searchEngine          = $this->getSearchEngine($documents, $docCount);

src/module-elasticsuite-core/Test/Unit/Search/Adapter/Elasticsuite/Request/Aggregation/Builder/TermTest.php

@@ -13,6 +13,7 @@
  */
 namespace Smile\ElasticsuiteCore\Test\Unit\Search\Adapter\Elasticsuite\Request\Aggregation\Builder;
 
+use PHPUnit\Framework\Attributes\DataProvider;
 use Smile\ElasticsuiteCore\Search\Adapter\Elasticsuite\Request\Aggregation\Builder\Term as TermBuilder;
 use Smile\ElasticsuiteCore\Search\Request\Aggregation\Bucket\Term as TermBucket;
 use Smile\ElasticsuiteCore\Search\Request\SortOrderInterface;
@@ -242,6 +243,7 @@ public function testInvalidBucketAggregationBuild()
      *
      * @return void
      */
+    #[DataProvider('sizeDataProvider')]
     public function testBucketSize($size, $expected)
     {
         $aggBuilder = $this->getAggregationBuilder();

src/module-elasticsuite-core/Test/Unit/Search/Adapter/Elasticsuite/Request/Aggregation/Builder/TopHitsTest.php

@@ -13,6 +13,7 @@
 
 namespace Smile\ElasticsuiteCore\Test\Unit\Search\Adapter\Elasticsuite\Request\Aggregation\Builder;
 
+use PHPUnit\Framework\Attributes\DataProvider;
 use Smile\ElasticsuiteCore\Search\Adapter\Elasticsuite\Request\Aggregation\Builder\TopHits as TopHitsBuilder;
 use Smile\ElasticsuiteCore\Search\Request\Aggregation\Bucket\Term as TermBucket;
 use Smile\ElasticsuiteCore\Search\Request\Aggregation\Bucket\TopHits as TopHitsBucket;
@@ -40,6 +41,7 @@ class TopHitsTest extends \PHPUnit\Framework\TestCase
      *
      * @return void
      */
+    #[DataProvider('sizeDataProvider')]
     public function testBucketNoSize($size, $hasSize, $expected)
     {
         $aggBuilder = $this->getAggregationBuilder();

src/module-elasticsuite-core/Test/Unit/Search/Adapter/Elasticsuite/Request/Query/Builder/NeuralTest.php

@@ -13,6 +13,7 @@
  */
 namespace Smile\ElasticsuiteCore\Test\Unit\Search\Adapter\Elasticsuite\Request\Query\Builder;
 
+use PHPUnit\Framework\Attributes\DataProvider;
 use Smile\ElasticsuiteCore\Search\Request\Query\Vector\Opensearch\Neural as NeuralQuery;
 use Smile\ElasticsuiteCore\Search\Adapter\Elasticsuite\Request\Query\Builder\Opensearch\Neural as NeuralQueryBuilder;
 
@@ -33,6 +34,7 @@ class NeuralTest extends AbstractSimpleQueryBuilder
      *
      * @return void
      */
+    #[DataProvider('neuralQueryAssemblerDataProvider')]
     public function testNeuralQueryAssembler(
         array $queryParameters,
         array $expectedQuery,

src/module-elasticsuite-thesaurus/Test/Unit/Config/ThesaurusCacheConfigTest.php

@@ -16,6 +16,7 @@
 namespace Smile\ElasticsuiteThesaurus\Test\Unit\Config;
 
 use Magento\Framework\App\Config\ScopeConfigInterface;
+use PHPUnit\Framework\Attributes\DataProvider;
 use Magento\Store\Model\ScopeInterface;
 use PHPUnit\Framework\MockObject\MockObject;
 use Smile\ElasticsuiteCore\Api\Search\Request\ContainerConfigurationInterface;
@@ -40,6 +41,7 @@ class ThesaurusCacheConfigTest extends \PHPUnit\Framework\TestCase
      * @param int   $rewritesCount               Number of rewrites/alternative queries.
      * @param bool  $expectedCacheStorageAllowed Expected cache storage allowed result.
      */
+    #[DataProvider('cacheStorageLimitationDataProvider')]
     public function testCacheStorageLimitation(
         $isSetFlagReturnsMap,
         $getValueReturnsMap,