[Swatch] Fix error when value is not an array fixes #3800

Author: PierreGauthier

src/module-elasticsuite-swatches/Helper/Swatches.php

@@ -90,8 +90,11 @@ public function loadFirstVariationWithImage(ProductInterface $configurableProduc
 
             foreach ($usedProducts as $simpleProduct) {
                 foreach ($requiredAttributes as $attributeCode => $requiredValues) {
-                    if (!in_array($simpleProduct->getData($attributeCode), $requiredValues)) {
-                        break 2;
+                    if (!in_array(
+                        $simpleProduct->getData($attributeCode),
+                        is_array($requiredValues) ? $requiredValues : [$requiredValues]
+                    )) {
+                        continue 2;
                     }
                 }
 

src/module-elasticsuite-swatches/Model/Plugin/ProductImage.php

@@ -90,7 +90,7 @@ private function getFilterArray(array $request, \Magento\Catalog\Model\Product $
     private function loadSimpleVariation(Product $parentProduct, array $filterArray)
     {
         $childProduct = $this->swatchHelperData->loadVariationByFallback($parentProduct, $filterArray);
-        if ($childProduct && !$childProduct->getImage()) {
+        if ($childProduct && (!$childProduct->getImage() || $childProduct->getImage() == 'no_selection')) {
             $childProduct = $this->swatchHelperData->loadFirstVariationWithImage($parentProduct, $filterArray);
         }
         if (!$childProduct) {