Skip to content

Commit 18d6241

Browse files
committed
Merge branch 'main' into improve-insufficient-replica-alarm
2 parents 443e1af + 8a5857d commit 18d6241

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

src/modules/keydb_modstatsd/modmain.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -251,6 +251,7 @@ std::unordered_map<std::string, StatsRecord> g_mapInfoFields = {
251251
{ "cluster_size", { StatsD_Type::STATSD_GAUGE_LONGLONG }},
252252
{ "storage_flash_available_bytes", { StatsD_Type::STATSD_GAUGE_BYTES }},
253253
{ "storage_flash_total_bytes", { StatsD_Type::STATSD_GAUGE_BYTES }},
254+
{ "last_overload_cpu_reading", { StatsD_Type::STATSD_GAUGE_FLOAT }},
254255
};
255256

256257
/* Globals */

src/server.cpp

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2610,6 +2610,7 @@ int serverCron(struct aeEventLoop *eventLoop, long long id, void *clientData) {
26102610
perc /= cserver.cthreads;
26112611
perc *= 100.0;
26122612
serverLog(LL_WARNING, "CPU Used: %.2f", perc);
2613+
g_pserver->last_overload_cpu_reading = static_cast<float>(perc);
26132614
if (perc > g_pserver->overload_protect_threshold) {
26142615
serverLog(LL_WARNING, "\tWARNING: CPU overload detected.");
26152616
g_pserver->is_overloaded = true;
@@ -6271,13 +6272,15 @@ sds genRedisInfoString(const char *section) {
62716272
"used_cpu_sys_children:%ld.%06ld\r\n"
62726273
"used_cpu_user_children:%ld.%06ld\r\n"
62736274
"server_threads:%d\r\n"
6274-
"long_lock_waits:%" PRIu64 "\r\n",
6275+
"long_lock_waits:%" PRIu64 "\r\n"
6276+
"last_overload_cpu_reading:%.2f\r\n",
62756277
(long)self_ru.ru_stime.tv_sec, (long)self_ru.ru_stime.tv_usec,
62766278
(long)self_ru.ru_utime.tv_sec, (long)self_ru.ru_utime.tv_usec,
62776279
(long)c_ru.ru_stime.tv_sec, (long)c_ru.ru_stime.tv_usec,
62786280
(long)c_ru.ru_utime.tv_sec, (long)c_ru.ru_utime.tv_usec,
62796281
cserver.cthreads,
6280-
fastlock_getlongwaitcount());
6282+
fastlock_getlongwaitcount(),
6283+
g_pserver->last_overload_cpu_reading);
62816284
#ifdef RUSAGE_THREAD
62826285
struct rusage m_ru;
62836286
getrusage(RUSAGE_THREAD, &m_ru);

src/server.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2758,6 +2758,7 @@ struct redisServer {
27582758

27592759
sds sdsAvailabilityZone;
27602760
int overload_protect_threshold = 0;
2761+
float last_overload_cpu_reading = 0.0f;
27612762
int is_overloaded = 0;
27622763
int overload_closed_clients = 0;
27632764

0 commit comments

Comments
 (0)