Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This pull request fixes a self-hosting issue where the Tauri HTTP client fails with
Unexpected token ... is not valid JSONbecause certain API endpoints returned plain text responses.What was changed
AdminSettingsController:updateSettingsandupdateSettingsSectionto return structured JSON objects instead of raw strings.Map<String, Object>with keys likemessageanderror.UserController:/api/v1/user/get-api-keyand/api/v1/user/update-api-keyto return JSON objects ({ "apiKey": "..." }) and JSON error objects instead of plain text.Why the change was made
"Successful..."or an API key string causes JSON parsing to fail, resulting in network errors on self-hosted setups.Checklist
General
Documentation
Translations (if applicable)
scripts/counter_translation.pyUI Changes (if applicable)
Testing (if applicable)