[test, toolbar] Include test to check build boundaries with invalid data and error is caught when executing the build boundaries model

Author: lacardonap

asistente_ladm_col/lib/geometry.py

@@ -720,8 +720,14 @@ def build_boundaries(self, boundary_layer):
         """
         :return: QgsVectorLayer
         """
-        params = {'boundaries': boundary_layer, 'native:refactorfields_2:built_boundaries': 'TEMPORARY_OUTPUT'}
-        build_boundary_layer = processing.run("model:Build_Boundaries", params)['native:refactorfields_2:built_boundaries']
+        feedback = CustomFeedbackWithErrors()
+        try:
+            params = {'boundaries': boundary_layer, 'native:refactorfields_2:built_boundaries': 'TEMPORARY_OUTPUT'}
+            build_boundary_layer = processing.run("model:Build_Boundaries", params, feedback=feedback)['native:refactorfields_2:built_boundaries']
+        except QgsProcessingException as e:
+            self.logger.warning(__name__, QCoreApplication.translate("Geometry",
+                                                                     "Error running the model to build boundaries. Details: {}".format(feedback.msg)))
+            build_boundary_layer = QgsVectorLayer("LineString?crs={}".format(get_crs_authid(boundary_layer.sourceCrs())), "build_boundaries", "memory")
 
         # For CTM12 the output layer remains without projection. The projection of the input layer is assigned
         if not build_boundary_layer.crs().authid():

asistente_ladm_col/lib/processing/models/model_build_boundaries.model3

@@ -54,7 +54,9 @@
     'no_interlis_gpkg': 'static/gpkg/no_interlis.gpkg',
     'test_logic_quality_rules_gpkg': 'ladm/gpkg/test_logic_quality_rules_v1_1.gpkg',
     'test_valid_quality_rules_gpkg': 'ladm/gpkg/test_valid_quality_rules_v1_1.gpkg',
-    'test_toolbar_gpkg': 'ladm/gpkg/test_toolbar_v1_1.gpkg',
-    'test_toolbar_empty_geom_gpkg': 'ladm/gpkg/test_toolbar_v1_1_empty_geom.gpkg',
+    'test_build_boundaries_gpkg': 'ladm/gpkg/test_build_boundaries_v1_1.gpkg',
+    'test_build_boundaries_invalid_geom_gpkg': 'ladm/gpkg/test_build_boundaries_invalid_geom_v1_1.gpkg',
+    'test_build_boundaries_empty_geom_gpkg': 'ladm/gpkg/test_build_boundaries_empty_geom_v1_1.gpkg',
+    'test_build_boundaries_fix_geoms_gpkg': 'ladm/gpkg/test_build_boundaries_fix_geoms_v1_1.gpkg',
     'interlis_no_ladm_col_models_gpkg': 'static/gpkg/interlis_no_ladm_col_models.gpkg'
 }

asistente_ladm_col/tests/config/test_config.py

@@ -33,7 +33,7 @@ def setUpClass(cls):
 
     def test_build_boundaries(self):
         print('\nINFO: Validating build boundaries...')
-        db_gpkg = get_copy_gpkg_conn('test_toolbar_gpkg')
+        db_gpkg = get_copy_gpkg_conn('test_build_boundaries_gpkg')
         res, code, msg = db_gpkg.test_connection()
         self.assertTrue(res, msg)
 
@@ -99,7 +99,7 @@ def test_build_boundaries(self):
 
     def test_build_boundaries_with_empty_geom(self):
         print('\nINFO: Validating build boundaries, null geometries of the input layer are removed...')
-        db_gpkg = get_copy_gpkg_conn('test_toolbar_empty_geom_gpkg')
+        db_gpkg = get_copy_gpkg_conn('test_build_boundaries_empty_geom_gpkg')
         res, code, msg = db_gpkg.test_connection()
         self.assertTrue(res, msg)
 
@@ -120,6 +120,43 @@ def test_build_boundaries_with_empty_geom(self):
         self.assertEqual(boundary_layer.selectedFeatureCount(), 0,
                          'Null features count does not match for the layer boundary layer')
 
+    def test_build_boundaries_with_invalid_geom(self):
+        print('\nINFO: Validating build boundaries, invalid geometry of the input layer are removed...')
+        db_gpkg = get_copy_gpkg_conn('test_build_boundaries_invalid_geom_gpkg')
+        res, code, msg = db_gpkg.test_connection()
+        self.assertTrue(res, msg)
+
+        boundary_layer = self.app.core.get_layer(db_gpkg, db_gpkg.names.LC_BOUNDARY_T, load=True)
+        self.assertEqual(boundary_layer.featureCount(), 16, 'Features count does not match for the layer boundary layer')
+
+        self.toolbar.build_boundaries(db_gpkg, True)
+
+        self.assertEqual(boundary_layer.featureCount(), 1, 'Features count does not match for the layer boundary layer')
+
+        exp = "is_empty_or_null($geometry)"
+        boundary_layer.selectByExpression(exp)
+        self.assertEqual(boundary_layer.selectedFeatureCount(), 0,
+                         'Null features count does not match for the layer boundary layer')
+
+
+    def test_build_boundaries_with_invalid_geom_in_processing(self):
+        print('\nINFO: Validating build boundaries, invalid geometries generated when running the processing algorithm are fixed...')
+        db_gpkg = get_copy_gpkg_conn('test_build_boundaries_fix_geoms_gpkg')
+        res, code, msg = db_gpkg.test_connection()
+        self.assertTrue(res, msg)
+
+        boundary_layer = self.app.core.get_layer(db_gpkg, db_gpkg.names.LC_BOUNDARY_T, load=True)
+        self.assertEqual(boundary_layer.featureCount(), 7, 'Features count does not match for the layer boundary layer')
+
+        self.toolbar.build_boundaries(db_gpkg, True)
+
+        self.assertEqual(boundary_layer.featureCount(), 17, 'Features count does not match for the layer boundary layer')
+
+        exp = "is_empty_or_null($geometry)"
+        boundary_layer.selectByExpression(exp)
+        self.assertEqual(boundary_layer.selectedFeatureCount(), 0,
+                         'Null features count does not match for the layer boundary layer')
+
     def test_check_build_boundaries(self):
         print('\nINFO: Validation of the definition of boundaries...')