fix(core): serialize, deserialize and compareWith are now mandatory.

Author: Airblader

projects/ngqp-demo/src/app/playground/playground.component.ts

@@ -25,7 +25,7 @@ export class PlaygroundComponent {
             }),
             range: queryParamBuilder.numericParam({
                 name: 'range',
-                emptyOn: 5,
+                emptyOn: 2,
             }),
         });
     }

projects/ngqp/core/src/lib/model.ts

@@ -1,4 +1,4 @@
-import { Comparator, isOptionalFunction, wrapTryCatch } from './util';
+import { Comparator, isFunction, wrapTryCatch } from './util';
 import { createEmptyOnDeserializer, createEmptyOnSerializer } from './serializers';
 
 /** TODO Documentation */
@@ -65,15 +65,15 @@ export class QueryParamControl<T> {
     constructor(opts: QueryParamControlOpts<T>) {
         const { name, serialize, deserialize, debounceTime, emptyOn, compareWith } = opts;
 
-        if (!isOptionalFunction(serialize)) {
+        if (!isFunction(serialize)) {
             throw new Error(`serialize must be a function, but received ${serialize}`);
         }
 
-        if (!isOptionalFunction(deserialize)) {
+        if (!isFunction(deserialize)) {
             throw new Error(`deserialize must be a function, but received ${deserialize}`);
         }
 
-        if (!isOptionalFunction(compareWith)) {
+        if (!isFunction(compareWith)) {
             throw new Error(`compareWith must be a function, but received ${compareWith}`);
         }
 

projects/ngqp/core/src/lib/util.ts

@@ -15,8 +15,8 @@ export function isMissing(obj: any): obj is null | undefined {
 /**
  * TODO Documentation
  */
-export function isOptionalFunction(obj: any): boolean {
-    return isMissing(obj) || typeof obj === 'function';
+export function isFunction(obj: any): boolean {
+    return !isMissing(obj) && typeof obj === 'function';
 }
 
 /**