fix(core): Remove string shorthand syntax

fixes #63

Author: Airblader

projects/ngqp-demo/src/app/docs-items/examples/patch-set-value-example/patch-set-value-example.component.ts

@@ -16,8 +16,8 @@ export class PatchSetValueExampleComponent {
 
     constructor(private qpb: QueryParamBuilder) {
         this.paramGroup = qpb.group({
-            p1: 'p1',
-            p2: 'p2',
+            p1: qpb.stringParam({ param: 'p1' }),
+            p2: qpb.stringParam({ param: 'p2' }),
         });
     }
 

projects/ngqp-demo/src/app/docs-items/examples/replace-url-example/replace-url-example.component.ts

@@ -17,11 +17,11 @@ export class ReplaceUrlExampleComponent {
 
     constructor(private qpb: QueryParamBuilder) {
         this.replaceParamGroup = this.qpb.group({
-            text: 'q1',
+            text: qpb.stringParam({ param: 'q1' }),
         }, { replaceUrl: true });
 
         this.noReplaceParamGroup = this.qpb.group({
-            text: 'q2',
+            text: qpb.stringParam({ param: 'q2' }),
         }, { replaceUrl: false });
     }
 

projects/ngqp-demo/src/app/docs-items/introduction/introduction-docs.component.ts

@@ -27,7 +27,7 @@ export class IntroductionDocsComponent {
                 param: 'q',
                 debounceTime: 300,
             }),
-            manufacturer: 'manufacturer',
+            manufacturer: qpb.stringParam({ param: 'manufacturer' }),
             priceCap: qpb.numberParam({
                 param: 'costsLessThan',
                 emptyOn: 0,

projects/ngqp-demo/src/app/docs-items/model-usage/snippets/queryparamgroup-get.example.ts

@@ -8,10 +8,10 @@ export class ExampleComponent {
 
     constructor(private qpb: QueryParamBuilder) {
         this.paramGroup = qpb.group({
-            myParam: 'q',
+            myParam: qpb.stringParam({ param: 'q' }),
         });
 
-        const myParam: QueryParam = this.paramGroup.get('myParam');
+        const myParam: QueryParam<string> = this.paramGroup.get('myParam');
     }
 
 }

projects/ngqp-demo/src/app/docs-items/model-usage/snippets/queryparamgroup-value.example.ts

@@ -8,7 +8,7 @@ export class ExampleComponent {
 
     constructor(private qpb: QueryParamBuilder) {
         this.paramGroup = qpb.group({
-            myParam: 'q',
+            myParam: qpb.stringParam({ param: 'q' }),
         });
 
         const value = this.paramGroup.value;

projects/ngqp-demo/src/app/docs-items/model-usage/snippets/queryparamgroup-valuechanges.example.ts

@@ -11,7 +11,7 @@ export class ExampleComponent implements OnDestroy {
 
     constructor(private qpb: QueryParamBuilder) {
         this.paramGroup = qpb.group({
-            myParam: 'q',
+            myParam: qpb.stringParam({ param: 'q' }),
         });
 
         this.paramGroup.valueChanges.pipe(

projects/ngqp-demo/src/app/docs-items/usage-guide/snippets/define-model.example.ts

@@ -8,7 +8,6 @@ export class ExampleComponent {
 
     constructor(private qpb: QueryParamBuilder) {
         this.paramGroup = qpb.group({
-            simple: 'p1',
             stringParam: qpb.stringParam({
                 param: 'p2'
             }),

projects/ngqp/core/src/lib/query-param-builder.service.ts

@@ -35,16 +35,11 @@ export class QueryParamBuilder {
      * @returns The new {@link QueryParamGroup}.
      */
     public group(
-        queryParams: { [ name: string ]: QueryParam<any> | string },
+        queryParams: { [ name: string ]: QueryParam<any> },
         extras: RouterOptions = {}
     ): QueryParamGroup {
-        const mappedQueryParams: { [ queryParamName: string ]: QueryParam<any> } = {};
-        Object.keys(queryParams).forEach(queryParamName => {
-            mappedQueryParams[ queryParamName ] = this.createQueryParam(queryParams[ queryParamName ]);
-        });
-
         // TODO Maybe we should first validate that no two queryParams defined the same "param".
-        return new QueryParamGroup(mappedQueryParams, extras);
+        return new QueryParamGroup(queryParams, extras);
     }
 
     /** @ignore */
@@ -117,14 +112,4 @@ export class QueryParamBuilder {
         });
     }
 
-    private createQueryParam<T>(queryParam: QueryParam<T> | string): QueryParam<T> | QueryParam<string> {
-        if (queryParam instanceof QueryParam) {
-            return queryParam;
-        }
-
-        return this.stringParam({
-            param: queryParam,
-        });
-    }
-
 }