Skip to content

Commit e0e875b

Browse files
committed
fix(core): Don't expost "adapter" naming in API
1 parent 412f4fd commit e0e875b

8 files changed

Lines changed: 25 additions & 26 deletions

File tree

projects/ngqp-demo/src/app/test-router-adapter.service.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
import { Injectable } from '@angular/core';
22
import { convertToParamMap, ParamMap, Params } from '@angular/router';
33
import { ReplaySubject } from 'rxjs';
4-
import { RouterAdapter } from '@ngqp/core';
5-
import { RouterAdapterOptions } from '../../../ngqp/core/src/lib/router-adapter/router-adapter.interface';
4+
import { RouterAdapter, RouterOptions } from '@ngqp/core';
65

76
@Injectable()
87
export class TestRouterAdapter implements RouterAdapter {
@@ -15,7 +14,7 @@ export class TestRouterAdapter implements RouterAdapter {
1514

1615
private _params: Params;
1716

18-
public navigate(queryParams: Params, extras: RouterAdapterOptions = {}): Promise<boolean> {
17+
public navigate(queryParams: Params, extras: RouterOptions = {}): Promise<boolean> {
1918
const previousUrl = this.url;
2019

2120
const newParams = {

projects/ngqp/core/src/lib/model.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { Params } from '@angular/router';
22
import { Observable, Subject } from 'rxjs';
33
import { Comparator, isFunction, isMissing, wrapTryCatch } from './util';
44
import { createEmptyOnDeserializer, createEmptyOnSerializer } from './serializers';
5-
import { RouterAdapterOptions } from './router-adapter/router-adapter.interface';
5+
import { RouterOptions } from './router-adapter/router-adapter.interface';
66

77
/**
88
* A serializer defines how the represented form control's
@@ -141,13 +141,13 @@ export class QueryParamGroup {
141141
public readonly queryParams: { [ queryParamName: string ]: QueryParam<any> };
142142

143143
/** @internal */
144-
public readonly routerOptions: RouterAdapterOptions;
144+
public readonly routerOptions: RouterOptions;
145145

146146
private changeFunctions: OnChangeFunction<QueryParamGroupValue>[] = [];
147147

148148
constructor(
149149
queryParams: { [ queryParamName: string ]: QueryParam<any> },
150-
extras: RouterAdapterOptions = {}
150+
extras: RouterOptions = {}
151151
) {
152152
this.queryParams = queryParams;
153153
this.routerOptions = extras;

projects/ngqp/core/src/lib/query-param-builder.service.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import {
99
DEFAULT_STRING_SERIALIZER
1010
} from './serializers';
1111
import { LOOSE_IDENTITY_COMPARATOR } from './util';
12-
import { RouterAdapterOptions } from './router-adapter/router-adapter.interface';
12+
import { RouterOptions } from './router-adapter/router-adapter.interface';
1313

1414
type OverwritePartial<T1, T2 extends keyof T1> = Pick<T1, Exclude<keyof T1, T2>> & Partial<Pick<T1, T2>>;
1515

@@ -40,7 +40,7 @@ export class QueryParamBuilder {
4040
*/
4141
public group(
4242
queryParams: { [ name: string ]: QueryParam<any> | string },
43-
extras: RouterAdapterOptions = {}
43+
extras: RouterOptions = {}
4444
): QueryParamGroup {
4545
const mappedQueryParams: { [ queryParamName: string ]: QueryParam<any> } = {};
4646
Object.keys(queryParams).forEach(queryParamName => {

projects/ngqp/core/src/lib/query-param-group.directive.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { Directive, Inject, Input, OnDestroy, OnInit, Optional } from '@angular/
22
import { Params } from '@angular/router';
33
import { Subject } from 'rxjs';
44
import { concatMap, debounceTime, map, takeUntil, tap } from 'rxjs/operators';
5-
import { NGQP_ROUTER_ADAPTER, NGQP_ROUTER_OPTIONS, RouterAdapter, RouterAdapterOptions } from './router-adapter/router-adapter.interface';
5+
import { NGQP_ROUTER_ADAPTER, NGQP_ROUTER_OPTIONS, RouterAdapter, RouterOptions } from './router-adapter/router-adapter.interface';
66
import { QueryParamNameDirective } from './query-param-name.directive';
77
import { QueryParam, QueryParamGroup, QueryParamGroupValue, Unpack } from './model';
88
import { isMissing } from './util';
@@ -46,7 +46,7 @@ export class QueryParamGroupDirective implements OnInit, OnDestroy {
4646

4747
constructor(
4848
@Inject(NGQP_ROUTER_ADAPTER) private routerAdapter: RouterAdapter,
49-
@Optional() @Inject(NGQP_ROUTER_OPTIONS) private globalRouterOptions: RouterAdapterOptions
49+
@Optional() @Inject(NGQP_ROUTER_OPTIONS) private globalRouterOptions: RouterOptions
5050
) {
5151
this.setupNavigationQueue();
5252
}
@@ -170,7 +170,7 @@ export class QueryParamGroupDirective implements OnInit, OnDestroy {
170170
}
171171
}
172172

173-
private get routerOptions(): RouterAdapterOptions {
173+
private get routerOptions(): RouterOptions {
174174
const groupOptions = this.queryParamGroup ? this.queryParamGroup.routerOptions : {};
175175

176176
return {

projects/ngqp/core/src/lib/query-param.module.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@ import {
1414
} from './accessors/accessors';
1515
import {
1616
DefaultRouterAdapter,
17-
DefaultRouterAdapterOptions,
17+
DefaultRouterOptions,
1818
NGQP_ROUTER_ADAPTER,
1919
NGQP_ROUTER_OPTIONS,
20-
RouterAdapterOptions
20+
RouterOptions
2121
} from './router-adapter/router-adapter';
2222

2323
/** @ignore */
@@ -48,19 +48,19 @@ const DIRECTIVES: Type<any>[] = [
4848
},
4949
{
5050
provide: NGQP_ROUTER_OPTIONS,
51-
useValue: DefaultRouterAdapterOptions,
51+
useValue: DefaultRouterOptions,
5252
},
5353
],
5454
})
5555
export class QueryParamModule {
5656

57-
public static forRoot(config: { routerOptions?: RouterAdapterOptions } = {}): ModuleWithProviders<QueryParamModule> {
57+
public static forRoot(config: { routerOptions?: RouterOptions } = {}): ModuleWithProviders<QueryParamModule> {
5858
return {
5959
ngModule: QueryParamModule,
6060
providers: [
6161
{
6262
provide: NGQP_ROUTER_OPTIONS,
63-
useValue: config.routerOptions ? config.routerOptions : DefaultRouterAdapterOptions,
63+
useValue: config.routerOptions ? config.routerOptions : DefaultRouterOptions,
6464
},
6565
],
6666
};

projects/ngqp/core/src/lib/router-adapter/default-router-adapter.service.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { Injectable } from '@angular/core';
22
import { ActivatedRoute, Params, Router } from '@angular/router';
3-
import { RouterAdapter, RouterAdapterOptions } from './router-adapter.interface';
3+
import { RouterAdapter, RouterOptions } from './router-adapter.interface';
44

55
/** @internal */
66
@Injectable()
@@ -17,7 +17,7 @@ export class DefaultRouterAdapter implements RouterAdapter {
1717
return this.route.queryParamMap;
1818
}
1919

20-
public navigate(queryParams: Params, extras: RouterAdapterOptions = {}): Promise<boolean> {
20+
public navigate(queryParams: Params, extras: RouterOptions = {}): Promise<boolean> {
2121
return this.router.navigate([], {
2222
relativeTo: this.route,
2323
queryParamsHandling: 'merge',

projects/ngqp/core/src/lib/router-adapter/router-adapter.interface.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,25 +20,25 @@ export interface RouterAdapter {
2020
queryParamMap: Observable<ParamMap>;
2121

2222
/** @internal */
23-
navigate(queryParams: Params, extras?: RouterAdapterOptions): Promise<boolean>;
23+
navigate(queryParams: Params, extras?: RouterOptions): Promise<boolean>;
2424

2525
}
2626

2727
/**
2828
* Options to be provided when a navigation is started to update the URL.
2929
* These options are simply forwarded to Router#navigate.
3030
*/
31-
export type RouterAdapterOptions = Pick<NavigationExtras, 'replaceUrl'>;
31+
export type RouterOptions = Pick<NavigationExtras, 'replaceUrl'>;
3232

3333
/**
34-
* See {@link RouterAdapterOptions}.
34+
* See {@link RouterOptions}.
3535
*/
36-
export const DefaultRouterAdapterOptions: RouterAdapterOptions = {
36+
export const DefaultRouterOptions: RouterOptions = {
3737
replaceUrl: true,
3838
};
3939

4040
/** @internal */
4141
export const NGQP_ROUTER_ADAPTER = new InjectionToken<RouterAdapter>('NGQP_ROUTER_ADAPTER');
4242

43-
/** Injection token to provide {@link RouterAdapterOptions}. */
44-
export const NGQP_ROUTER_OPTIONS = new InjectionToken<RouterAdapterOptions>('NGQP_ROUTER_OPTIONS');
43+
/** Injection token to provide {@link RouterOptions}. */
44+
export const NGQP_ROUTER_OPTIONS = new InjectionToken<RouterOptions>('NGQP_ROUTER_OPTIONS');
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
export {
22
RouterAdapter,
33
NGQP_ROUTER_ADAPTER,
4-
RouterAdapterOptions,
5-
DefaultRouterAdapterOptions,
4+
RouterOptions,
5+
DefaultRouterOptions,
66
NGQP_ROUTER_OPTIONS
77
} from './router-adapter.interface';
88
export { DefaultRouterAdapter } from './default-router-adapter.service';

0 commit comments

Comments
 (0)