Skip to content

Commit ee2c473

Browse files
committed
fix(core): Rename numericParam to numberParam
fixes #62
1 parent 96985ca commit ee2c473

7 files changed

Lines changed: 12 additions & 12 deletions

File tree

projects/ngqp-demo/src/app/docs-items/examples/control-value-accessor-directive-example/control-value-accessor-directive-example.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export class ControlValueAccessorDirectiveExampleComponent {
1616

1717
constructor(private qpb: QueryParamBuilder) {
1818
this.paramGroup = qpb.group({
19-
page: qpb.numericParam({
19+
page: qpb.numberParam({
2020
param: 'page',
2121
emptyOn: 1,
2222
}),

projects/ngqp-demo/src/app/docs-items/examples/empty-on-example/empty-on-example.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@ export class EmptyOnExampleComponent {
1616

1717
constructor(private qpb: QueryParamBuilder) {
1818
this.paramGroup = qpb.group({
19-
number1: qpb.numericParam({
19+
number1: qpb.numberParam({
2020
param: 'n1',
2121
emptyOn: 20,
2222
}),
23-
number2: qpb.numericParam({
23+
number2: qpb.numberParam({
2424
param: 'n2',
2525
deserialize: createNumberDeserializer(20),
2626
}),

projects/ngqp-demo/src/app/docs-items/examples/manual-wiring-example/manual-wiring-example.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export class ManualWiringExampleComponent implements OnDestroy {
2121

2222
constructor(private qpb: QueryParamBuilder) {
2323
this.paramGroup = qpb.group({
24-
page: qpb.numericParam({
24+
page: qpb.numberParam({
2525
param: 'page',
2626
emptyOn: 1,
2727
}),

projects/ngqp-demo/src/app/docs-items/introduction/introduction-docs.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export class IntroductionDocsComponent {
2828
debounceTime: 300,
2929
}),
3030
manufacturer: 'manufacturer',
31-
priceCap: qpb.numericParam({
31+
priceCap: qpb.numberParam({
3232
param: 'costsLessThan',
3333
emptyOn: 0,
3434
}),

projects/ngqp-demo/src/app/docs-items/introduction/our-first-example/typescript.example.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export class ExampleComponent implements OnInit, OnDestroy {
2727

2828
// The price cap is a numeric parameter, and we want the default value
2929
// to be 0
30-
priceCap: qpb.numericParam({
30+
priceCap: qpb.numberParam({
3131
param: 'costsLessThan',
3232
emptyOn: 0,
3333
}),

projects/ngqp/core/src/lib/query-param-builder.service.spec.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,14 @@ describe(QueryParamBuilder.name, () => {
3232
});
3333
});
3434

35-
describe('numericParam', () => {
35+
describe('numberParam', () => {
3636
it('can create a parameter', () => {
37-
const param: QueryParam<number> = qpb.numericParam({ param: 'q' });
37+
const param: QueryParam<number> = qpb.numberParam({ param: 'q' });
3838
expect(param).toBeTruthy();
3939
});
4040

4141
it('can create a multi parameter', () => {
42-
const param: QueryParam<number[]> = qpb.numericParam({ param: 'q', multi: true });
42+
const param: QueryParam<number[]> = qpb.numberParam({ param: 'q', multi: true });
4343
expect(param).toBeTruthy();
4444
});
4545
});

projects/ngqp/core/src/lib/query-param-builder.service.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,15 +66,15 @@ export class QueryParamBuilder {
6666
}
6767

6868
/** @ignore */
69-
public numericParam(opts: QueryParamOpts<number[]> & { multi: true }): QueryParam<number[]>;
69+
public numberParam(opts: QueryParamOpts<number[]> & { multi: true }): QueryParam<number[]>;
7070
/** @ignore */
71-
public numericParam(opts: QueryParamOpts<number>): QueryParam<number>;
71+
public numberParam(opts: QueryParamOpts<number>): QueryParam<number>;
7272
/**
7373
* Create a new parameter of type `number`.
7474
*
7575
* See {@link QueryParamOpts}.
7676
*/
77-
public numericParam(opts: QueryParamOpts<number> | QueryParamOpts<number[]>): QueryParam<number> | QueryParam<number[]> {
77+
public numberParam(opts: QueryParamOpts<number> | QueryParamOpts<number[]>): QueryParam<number> | QueryParam<number[]> {
7878
return new QueryParam<any>({
7979
serialize: DEFAULT_NUMBER_SERIALIZER,
8080
deserialize: DEFAULT_NUMBER_DESERIALIZER,

0 commit comments

Comments
 (0)