Skip to content

Commit a8beb48

Browse files
committed
bump minimum solid-js version
1 parent 3d008f9 commit a8beb48

File tree

11 files changed

+665
-392
lines changed

11 files changed

+665
-392
lines changed

examples/solid/basic-graphql-request/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"@tanstack/solid-query": "^4.3.9",
1414
"graphql": "^16.6.0",
1515
"graphql-request": "^5.0.0",
16-
"solid-js": "^1.6.2"
16+
"solid-js": "^1.6.13"
1717
},
1818
"devDependencies": {
1919
"typescript": "4.7.4",

examples/solid/basic-typescript/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"license": "MIT",
1212
"dependencies": {
1313
"@tanstack/solid-query": "^4.3.9",
14-
"solid-js": "^1.6.2"
14+
"solid-js": "^1.6.13"
1515
},
1616
"devDependencies": {
1717
"typescript": "4.7.4",

examples/solid/default-query-function/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"license": "MIT",
1212
"dependencies": {
1313
"@tanstack/solid-query": "^4.3.9",
14-
"solid-js": "^1.6.2"
14+
"solid-js": "^1.6.13"
1515
},
1616
"devDependencies": {
1717
"typescript": "4.7.4",

examples/solid/simple/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"license": "MIT",
1212
"dependencies": {
1313
"@tanstack/solid-query": "^4.3.9",
14-
"solid-js": "^1.6.2"
14+
"solid-js": "^1.6.13"
1515
},
1616
"devDependencies": {
1717
"@tanstack/eslint-plugin-query": "^4.13.0",

examples/solid/solid-start-streaming/package.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,15 @@
1111
"esbuild": "^0.14.54",
1212
"postcss": "^8.4.18",
1313
"solid-start-node": "^0.2.0",
14-
"typescript": "^4.8.4",
15-
"vite": "^3.1.8"
14+
"typescript": "^4.9.4",
15+
"vite": "^4.1.4"
1616
},
1717
"dependencies": {
18-
"@tanstack/solid-query": "^4.3.9",
18+
"@tanstack/solid-query": "^5.0.0-alpha.3",
1919
"@solidjs/meta": "^0.28.2",
20-
"@solidjs/router": "^0.6.0",
21-
"solid-js": "^1.6.9",
22-
"solid-start": "^0.2.15",
20+
"@solidjs/router": "^0.7.0",
21+
"solid-js": "^1.6.13",
22+
"solid-start": "^0.2.23",
2323
"undici": "^5.11.0"
2424
},
2525
"engines": {

examples/solid/solid-start-streaming/src/root.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export default function Root() {
2020
const queryClient = new QueryClient({
2121
defaultOptions: {
2222
queries: {
23-
retry: 0,
23+
retry: false,
2424
},
2525
},
2626
})

examples/solid/solid-start-streaming/src/routes/hydration.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,8 @@ export default function Hydration() {
4343
<th>isLoading</th>
4444
<th>isStale</th>
4545
<th>isSuccess</th>
46+
<th>isError</th>
47+
<th>error</th>
4648
<th>fetchStatus</th>
4749
<th>dataUpdatedAt</th>
4850
</tr>
@@ -88,6 +90,8 @@ const QueryStateRow = (props: { context: string; query: QueryState }) => {
8890
<td>{String(props.query.isLoading)}</td>
8991
<td>{String(props.query.isStale)}</td>
9092
<td>{String(props.query.isSuccess)}</td>
93+
<td>{String(props.query.isError)}</td>
94+
<td>{String(props.query.error)}</td>
9195
<td>{String(props.query.fetchStatus)}</td>
9296
<td>{String(props.query.dataUpdatedAt)}</td>
9397
</tr>

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@
8484
"rollup-plugin-terser": "^7.0.2",
8585
"rollup-plugin-visualizer": "^5.9.0",
8686
"rollup-preset-solid": "^1.4.0",
87-
"solid-js": "^1.5.7",
87+
"solid-js": "^1.6.13",
8888
"solid-testing-library": "^0.3.0",
8989
"stream-to-array": "^2.3.0",
9090
"ts-jest": "^29.0.5",

packages/solid-query/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
"@tanstack/query-core": "workspace:*"
5555
},
5656
"peerDependencies": {
57-
"solid-js": "^1.6.2"
57+
"solid-js": "^1.6.13"
5858
},
5959
"peerDependenciesMeta": {}
6060
}

packages/solid-query/src/createBaseQuery.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ export function createBaseQuery<
172172
)
173173

174174
onCleanup(() => {
175-
if (!isServer && unsubscribe) {
175+
if (unsubscribe) {
176176
unsubscribe()
177177
unsubscribe = null
178178
}

0 commit comments

Comments
 (0)