Skip to content

Commit f3f38f3

Browse files
committed
fix: scrollToOffset now properly passes options without crash
1 parent 8327dad commit f3f38f3

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

examples/sandbox/src/SmoothScroll.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ const raf = fn => requestAnimationFrame(fn);
1212

1313
export default function() {
1414
const parentRef = React.useRef();
15-
1615
const scrollingRef = React.useRef();
1716

1817
const [animationType, setAnimationType] = React.useState("setTimeout");

src/index.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,7 @@ export function useVirtual({
115115

116116
const latestRef = React.useRef()
117117
latestRef.current = {
118+
measurements,
118119
outerSize,
119120
scrollOffset,
120121
scrollOffsetPlusOuterSize,
@@ -155,6 +156,12 @@ export function useVirtual({
155156

156157
const scrollToIndex = React.useCallback(
157158
(index, { align = 'auto' } = {}) => {
159+
const {
160+
measurements,
161+
scrollOffset,
162+
scrollOffsetPlusOuterSize,
163+
} = latestRef.current
164+
158165
const measurement = measurements[index]
159166

160167
if (!measurement) {
@@ -177,7 +184,7 @@ export function useVirtual({
177184
: align === 'end'
178185
? measurement.end
179186
: measurement.start
180-
scrollToOffset(offset, options)
187+
scrollToOffset(offset, { align })
181188
},
182189
[scrollToOffset]
183190
)

0 commit comments

Comments
 (0)