Merge pull request #399 from Tinyblargon/GuestID

feat: type `GuestID`

Author: Tinyblargon

cli/command/create/create-snapshot.go

@@ -15,7 +15,7 @@ var (
 		TraverseChildren: true,
 		Args:             cobra.RangeArgs(2, 3),
 		RunE: func(cmd *cobra.Command, args []string) (err error) {
-			id := cli.ValidateIntIDset(args, "GuestID")
+			id := cli.ValidateGuestIDset(args, "GuestID")
 			snapName := cli.RequiredIDset(args, 1, "SnapshotName")
 			config := proxmox.ConfigSnapshot{
 				Name:        proxmox.SnapshotName(snapName),

cli/command/create/guest/create-guest.go

@@ -2,7 +2,6 @@ package guest
 
 import (
 	"context"
-	"strconv"
 
 	"github.com/Telmate/proxmox-api-go/cli"
 	"github.com/Telmate/proxmox-api-go/cli/command/create"
@@ -21,7 +20,7 @@ func init() {
 }
 
 func createGuest(ctx context.Context, args []string, IDtype string) (err error) {
-	id := cli.ValidateIntIDset(args, IDtype+"ID")
+	id := cli.ValidateGuestIDset(args, IDtype+"ID")
 	node := cli.RequiredIDset(args, 1, "NodeID")
 	vmr := proxmox.NewVmRef(id)
 	vmr.SetNode(node)
@@ -61,6 +60,6 @@ func createGuest(ctx context.Context, args []string, IDtype string) (err error)
 	if err != nil {
 		return
 	}
-	cli.PrintItemCreated(guestCmd.OutOrStdout(), strconv.Itoa(id), IDtype)
+	cli.PrintItemCreated(guestCmd.OutOrStdout(), id.String(), IDtype)
 	return
 }

cli/command/delete/delete-guest.go

@@ -1,8 +1,6 @@
 package delete
 
 import (
-	"strconv"
-
 	"github.com/Telmate/proxmox-api-go/cli"
 	"github.com/Telmate/proxmox-api-go/proxmox"
 	"github.com/spf13/cobra"
@@ -13,7 +11,7 @@ var delete_guestCmd = &cobra.Command{
 	Short: "Deletes the Specified Guest",
 	Args:  cobra.ExactArgs(1),
 	RunE: func(cmd *cobra.Command, args []string) (err error) {
-		id := cli.ValidateIntIDset(args, "GuestID")
+		id := cli.ValidateGuestIDset(args, "GuestID")
 		vmr := proxmox.NewVmRef(id)
 		c := cli.NewClient()
 		_, err = c.StopVm(cli.Context(), vmr)
@@ -24,7 +22,7 @@ var delete_guestCmd = &cobra.Command{
 		if err != nil {
 			return
 		}
-		cli.PrintItemDeleted(deleteCmd.OutOrStdout(), strconv.Itoa(id), "GuestID")
+		cli.PrintItemDeleted(deleteCmd.OutOrStdout(), id.String(), "GuestID")
 		return
 	},
 }

cli/command/delete/delete-snapshot.go

@@ -12,7 +12,7 @@ var (
 		Short: "Deletes the Specified snapshot",
 		Args:  cobra.ExactArgs(2),
 		RunE: func(cmd *cobra.Command, args []string) (err error) {
-			id := cli.ValidateIntIDset(args, "GuestID")
+			id := cli.ValidateGuestIDset(args, "GuestID")
 			snapName := cli.RequiredIDset(args, 1, "SnapshotName")
 			_, err = proxmox.SnapshotName(snapName).Delete(cli.Context(), cli.NewClient(), proxmox.NewVmRef(id))
 			if err != nil {

cli/command/get/guest/get-guest-config.go

@@ -11,7 +11,7 @@ var configCmd = &cobra.Command{
 	Short: "Gets the configuration of the specified guest",
 	Args:  cobra.ExactArgs(1),
 	RunE: func(cmd *cobra.Command, args []string) (err error) {
-		id := cli.ValidateIntIDset(args, "GuestID")
+		id := cli.ValidateGuestIDset(args, "GuestID")
 		vmr := proxmox.NewVmRef(id)
 		c := cli.NewClient()
 		err = c.CheckVmRef(cli.Context(), vmr)

cli/command/get/guest/get-guest-feature.go

@@ -11,7 +11,7 @@ var featureCmd = &cobra.Command{
 	Short: "Gets the available features of the specified guest",
 	Args:  cobra.ExactArgs(1),
 	RunE: func(cmd *cobra.Command, args []string) (err error) {
-		id := cli.ValidateIntIDset(args, "GuestID")
+		id := cli.ValidateGuestIDset(args, "GuestID")
 		vmr := proxmox.NewVmRef(id)
 		c := cli.NewClient()
 		err = c.CheckVmRef(cli.Context(), vmr)

cli/command/get/id/get-id-check.go

@@ -8,11 +8,11 @@ import (
 )
 
 var id_checkCmd = &cobra.Command{
-	Use:   "check ID",
-	Short: "Checks if a ID is available",
+	Use:   "check GuestID",
+	Short: "Checks if a GuestID is available",
 	Args:  cobra.ExactArgs(1),
 	RunE: func(cmd *cobra.Command, args []string) (err error) {
-		id := cli.ValidateIntIDset(args, "ID")
+		id := cli.ValidateGuestIDset(args, "GUESTID")
 		c := cli.NewClient()
 		exists, err := c.VMIdExists(cli.Context(), id)
 		if err != nil {

cli/command/guest/guest-rollback.go

@@ -13,7 +13,7 @@ var guest_rollbackCmd = &cobra.Command{
 	Short: "Shuts the specified guest down",
 	Args:  cobra.ExactArgs(2),
 	RunE: func(cmd *cobra.Command, args []string) (err error) {
-		vmr := proxmox.NewVmRef(cli.ValidateIntIDset(args, "GuestID"))
+		vmr := proxmox.NewVmRef(cli.ValidateGuestIDset(args, "GuestID"))
 		snapName := cli.RequiredIDset(args, 1, "SnapshotName")
 		_, err = proxmox.SnapshotName(snapName).Rollback(cli.Context(), cli.NewClient(), vmr)
 		if err == nil {

cli/command/guest/guest-shutdown.go

@@ -11,7 +11,7 @@ var guest_shutdownCmd = &cobra.Command{
 	Short: "Shuts the specified guest down",
 	Args:  cobra.ExactArgs(1),
 	RunE: func(cmd *cobra.Command, args []string) (err error) {
-		vmr := proxmox.NewVmRef(cli.ValidateIntIDset(args, "GuestID"))
+		vmr := proxmox.NewVmRef(cli.ValidateGuestIDset(args, "GuestID"))
 		c := cli.NewClient()
 		_, err = c.ShutdownVm(cli.Context(), vmr)
 		if err == nil {

cli/command/guest/guest-start.go

@@ -11,7 +11,7 @@ var guest_statusCmd = &cobra.Command{
 	Short: "Starts the specified guest",
 	Args:  cobra.ExactArgs(1),
 	RunE: func(cmd *cobra.Command, args []string) (err error) {
-		vmr := proxmox.NewVmRef(cli.ValidateIntIDset(args, "GuestID"))
+		vmr := proxmox.NewVmRef(cli.ValidateGuestIDset(args, "GuestID"))
 		c := cli.NewClient()
 		_, err = c.StartVm(cli.Context(), vmr)
 		if err == nil {