Skip to content

Commit 32f2da3

Browse files
committed
Get the join on success test passing again
1 parent 70759d3 commit 32f2da3

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

src/lib/output-socket.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ var OutputSocket = function (socket, messageHandler, nickname, logger) {
8484

8585
unsubscribe();
8686
logger.debug("Resolving with join message.");
87-
deferred.resolve(join);
87+
resolve(join);
8888
};
8989

9090
messageHandler.on('join', onJoin);

src/test/output-socket.sjs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,15 +33,18 @@ describe 'IRC Output Socket:' {
3333
assert(socket.raw.calledWithExactly(format("JOIN :%s", channel)));
3434
}
3535

36-
it skip 'On Success' (done) {
36+
it 'On Success' (done) {
3737
const joinmsg = {nickname: nickname, channel: channel};
3838

3939
socket.raw = function () {
4040
messageHandler.emit('join', joinmsg);
4141
};
4242

43-
assert(out.join(channel) === undefined);
44-
done();
43+
out.join(channel).then(function (join) {
44+
assert(join.channel === channel);
45+
assert(join.nickname === nickname);
46+
done();
47+
});
4548
}
4649
}
4750

0 commit comments

Comments
 (0)