fix: runtime issues in Phases 20-24 — SQL conflicts, HTTP methods, route paths, FK constraints

Zajfan · Zajfan · commit 59d4a7832f8d · 2026-03-10T09:45:55.000+01:00
Fixes:
- Repo: dismiss_recommendation now dismisses by rec_id (was using server_id as WHERE clause)
- Repo: award_achievement ON CONFLICT now uses explicit columns + DO UPDATE to always return row
- Repo: cast_vote ON CONFLICT now uses explicit columns + DO UPDATE to always return row
- Repo: added get_sync_cursor() read-only function (GET handler was calling upsert)
- Routes: award_achievement, dismiss_recommendation, cast_vote changed from GET to POST
- Routes: award_contributor_badge removed GET handler (POST-only, expects JSON body)
- Routes: cast_vote handler changed from Query to Json body extraction
- Routes: get_sync_cursor now calls read-only get_sync_cursor() instead of upsert
- invoke.ts: scaling-configs paths fixed from /servers/ to /admin/
- invoke.ts: voice-quality-logs, slow-mode-overrides fixed from /servers/ to /channels/
- invoke.ts: ai-suggestions, ai-consent, ai-audit-log paths fixed to match route definitions
- invoke.ts: live-streams now includes required channel_id query param
- invoke.ts: dismiss, award, vote calls changed from GET to POST
- Migration 000030: added FK constraints and indexes for all Phase 20-24 tables
diff --git a/crates/nexus-api/src/routes/growth.rs b/crates/nexus-api/src/routes/growth.rs
@@ -6,7 +6,7 @@
 use axum::{
     extract::{Extension, Path, Query, State},
     middleware,
-    routing::get,
+    routing::{get, post},
     Json, Router,
 };
 use nexus_common::error::{NexusError, NexusResult};
@@ -30,7 +30,7 @@ pub fn router() -> Router<Arc<AppState>> {
         )
         .route(
             "/users/@me/recommendations/:rec_id/dismiss",
-            get(dismiss_recommendation),
+            post(dismiss_recommendation),
         )
         // Onboarding flows
         .route(
@@ -57,7 +57,7 @@ pub fn router() -> Router<Arc<AppState>> {
         )
         .route(
             "/servers/:server_id/achievements/:achievement_id/award",
-            get(award_achievement),
+            post(award_achievement),
         )
         // Sync cursors
         .route("/users/@me/sync-cursors", get(get_sync_cursor).post(upsert_sync_cursor))
@@ -324,9 +324,9 @@ async fn get_sync_cursor(
     Extension(ctx): Extension<AuthContext>,
     Query(q): Query<SyncCursorQuery>,
 ) -> NexusResult<Json<Option<SyncCursor>>> {
-    let row = growth::upsert_sync_cursor(
-        &state.db.pool, ctx.user_id, &q.device_id, q.channel_id, None,
-    ).await.ok();
+    let row = growth::get_sync_cursor(
+        &state.db.pool, ctx.user_id, &q.device_id, q.channel_id,
+    ).await.map_err(|e| NexusError::Internal(e.into()))?;
     Ok(Json(row))
 }
 
diff --git a/crates/nexus-api/src/routes/sustainability.rs b/crates/nexus-api/src/routes/sustainability.rs
@@ -6,7 +6,7 @@
 use axum::{
     extract::{Extension, Path, Query, State},
     middleware,
-    routing::get,
+    routing::{get, post},
     Json, Router,
 };
 use nexus_common::error::{NexusError, NexusResult};
@@ -33,7 +33,7 @@ pub fn router() -> Router<Arc<AppState>> {
         )
         .route(
             "/servers/:server_id/governance/polls/:poll_id/vote",
-            get(cast_vote),
+            post(cast_vote),
         )
         // Governance proposals
         .route(
@@ -47,7 +47,7 @@ pub fn router() -> Router<Arc<AppState>> {
         )
         .route(
             "/users/:user_id/contributor-badges/award",
-            get(award_contributor_badge).post(award_contributor_badge),
+            post(award_contributor_badge),
         )
         // Security audits (admin)
         .route("/admin/security-audits", get(list_security_audits).post(create_security_audit))
@@ -199,13 +199,13 @@ async fn cast_vote(
     State(state): State<Arc<AppState>>,
     Extension(ctx): Extension<AuthContext>,
     Path((server_id, poll_id)): Path<(Uuid, Uuid)>,
-    Query(q): Query<CastVoteReq>,
+    Json(body): Json<CastVoteReq>,
 ) -> NexusResult<Json<PollVote>> {
     let _m: Option<Member> = members::find_member(&state.db.pool, ctx.user_id, server_id)
         .await.map_err(|e| NexusError::Internal(e.into()))?;
     if _m.is_none() { return Err(NexusError::Forbidden); }
 
-    let row = sustainability::cast_vote(&state.db.pool, poll_id, ctx.user_id, q.option_index)
+    let row = sustainability::cast_vote(&state.db.pool, poll_id, ctx.user_id, body.option_index)
         .await.map_err(|e| NexusError::Internal(e.into()))?;
     Ok(Json(row))
 }
diff --git a/crates/nexus-db/migrations/20260218000030_add_fk_and_indexes.sql b/crates/nexus-db/migrations/20260218000030_add_fk_and_indexes.sql
@@ -0,0 +1,184 @@
+-- ============================================================================
+-- Phase 20-24: Add missing foreign key constraints and indexes
+-- ============================================================================
+
+-- ── Migration 25: Scalability Hardening ────────────────────────────────────
+
+ALTER TABLE voice_quality_logs
+    ADD CONSTRAINT fk_vql_channel FOREIGN KEY (channel_id) REFERENCES channels(id) ON DELETE CASCADE,
+    ADD CONSTRAINT fk_vql_user    FOREIGN KEY (user_id)    REFERENCES users(id)    ON DELETE CASCADE;
+
+ALTER TABLE member_prune_rules
+    ADD CONSTRAINT fk_mpr_server FOREIGN KEY (server_id) REFERENCES servers(id) ON DELETE CASCADE;
+
+ALTER TABLE slow_mode_overrides
+    ADD CONSTRAINT fk_smo_channel FOREIGN KEY (channel_id) REFERENCES channels(id) ON DELETE CASCADE;
+
+CREATE INDEX IF NOT EXISTS idx_vql_channel   ON voice_quality_logs(channel_id, created_at DESC);
+CREATE INDEX IF NOT EXISTS idx_vql_user      ON voice_quality_logs(user_id);
+CREATE INDEX IF NOT EXISTS idx_mpr_server    ON member_prune_rules(server_id);
+CREATE INDEX IF NOT EXISTS idx_smo_channel   ON slow_mode_overrides(channel_id);
+
+-- ── Migration 26: AI Intelligence ─────────────────────────────────────────
+
+ALTER TABLE search_embeddings
+    ADD CONSTRAINT fk_se_message FOREIGN KEY (message_id) REFERENCES messages(id) ON DELETE CASCADE,
+    ADD CONSTRAINT fk_se_channel FOREIGN KEY (channel_id) REFERENCES channels(id) ON DELETE CASCADE;
+
+ALTER TABLE search_queries
+    ADD CONSTRAINT fk_sq_user FOREIGN KEY (user_id) REFERENCES users(id) ON DELETE CASCADE;
+
+ALTER TABLE ai_suggestions
+    ADD CONSTRAINT fk_as_user    FOREIGN KEY (user_id)    REFERENCES users(id)    ON DELETE CASCADE,
+    ADD CONSTRAINT fk_as_channel FOREIGN KEY (channel_id) REFERENCES channels(id) ON DELETE CASCADE;
+
+ALTER TABLE thread_summaries
+    ADD CONSTRAINT fk_ts_channel FOREIGN KEY (channel_id) REFERENCES channels(id) ON DELETE CASCADE;
+
+ALTER TABLE toxicity_scores
+    ADD CONSTRAINT fk_tox_message FOREIGN KEY (message_id) REFERENCES messages(id) ON DELETE CASCADE,
+    ADD CONSTRAINT fk_tox_server  FOREIGN KEY (server_id)  REFERENCES servers(id)  ON DELETE CASCADE;
+
+ALTER TABLE raid_detections
+    ADD CONSTRAINT fk_rd_server FOREIGN KEY (server_id) REFERENCES servers(id) ON DELETE CASCADE;
+
+ALTER TABLE voice_transcripts
+    ADD CONSTRAINT fk_vt_channel FOREIGN KEY (channel_id) REFERENCES channels(id) ON DELETE CASCADE;
+
+ALTER TABLE voice_commands
+    ADD CONSTRAINT fk_vc_user    FOREIGN KEY (user_id)    REFERENCES users(id)    ON DELETE CASCADE,
+    ADD CONSTRAINT fk_vc_channel FOREIGN KEY (channel_id) REFERENCES channels(id) ON DELETE CASCADE;
+
+ALTER TABLE ai_consent
+    ADD CONSTRAINT fk_ac_user   FOREIGN KEY (user_id)   REFERENCES users(id)   ON DELETE CASCADE,
+    ADD CONSTRAINT fk_ac_server FOREIGN KEY (server_id) REFERENCES servers(id) ON DELETE CASCADE;
+
+ALTER TABLE ai_audit_log
+    ADD CONSTRAINT fk_aal_server FOREIGN KEY (server_id) REFERENCES servers(id) ON DELETE CASCADE;
+
+CREATE INDEX IF NOT EXISTS idx_se_message    ON search_embeddings(message_id);
+CREATE INDEX IF NOT EXISTS idx_se_channel    ON search_embeddings(channel_id);
+CREATE INDEX IF NOT EXISTS idx_sq_user       ON search_queries(user_id);
+CREATE INDEX IF NOT EXISTS idx_as_user       ON ai_suggestions(user_id, channel_id);
+CREATE INDEX IF NOT EXISTS idx_ts_channel    ON thread_summaries(channel_id);
+CREATE INDEX IF NOT EXISTS idx_tox_message   ON toxicity_scores(message_id);
+CREATE INDEX IF NOT EXISTS idx_tox_server    ON toxicity_scores(server_id);
+CREATE INDEX IF NOT EXISTS idx_rd_server     ON raid_detections(server_id, detected_at DESC);
+CREATE INDEX IF NOT EXISTS idx_vt_channel    ON voice_transcripts(channel_id, created_at DESC);
+CREATE INDEX IF NOT EXISTS idx_vc_user       ON voice_commands(user_id, channel_id);
+CREATE INDEX IF NOT EXISTS idx_ac_user       ON ai_consent(user_id, server_id);
+CREATE INDEX IF NOT EXISTS idx_aal_server    ON ai_audit_log(server_id, created_at DESC);
+
+-- ── Migration 27: Voice & Collaboration ───────────────────────────────────
+
+ALTER TABLE video_layouts
+    ADD CONSTRAINT fk_vl_channel FOREIGN KEY (channel_id) REFERENCES channels(id) ON DELETE CASCADE,
+    ADD CONSTRAINT fk_vl_user    FOREIGN KEY (user_id)    REFERENCES users(id)    ON DELETE CASCADE;
+
+ALTER TABLE virtual_backgrounds
+    ADD CONSTRAINT fk_vb_user FOREIGN KEY (user_id) REFERENCES users(id) ON DELETE CASCADE;
+
+ALTER TABLE live_streams
+    ADD CONSTRAINT fk_ls_channel  FOREIGN KEY (channel_id)  REFERENCES channels(id) ON DELETE CASCADE,
+    ADD CONSTRAINT fk_ls_streamer FOREIGN KEY (streamer_id) REFERENCES users(id)    ON DELETE CASCADE;
+
+ALTER TABLE stream_viewers
+    ADD CONSTRAINT fk_sv_user FOREIGN KEY (user_id) REFERENCES users(id) ON DELETE CASCADE;
+
+ALTER TABLE breakout_rooms
+    ADD CONSTRAINT fk_br_parent  FOREIGN KEY (parent_channel) REFERENCES channels(id) ON DELETE CASCADE,
+    ADD CONSTRAINT fk_br_creator FOREIGN KEY (created_by)     REFERENCES users(id)    ON DELETE SET NULL;
+
+ALTER TABLE collab_sessions
+    ADD CONSTRAINT fk_cs_channel FOREIGN KEY (channel_id) REFERENCES channels(id) ON DELETE CASCADE;
+
+ALTER TABLE spatial_audio_configs
+    ADD CONSTRAINT fk_sac_channel FOREIGN KEY (channel_id) REFERENCES channels(id) ON DELETE CASCADE;
+
+CREATE INDEX IF NOT EXISTS idx_vl_channel    ON video_layouts(channel_id);
+CREATE INDEX IF NOT EXISTS idx_vl_user       ON video_layouts(user_id);
+CREATE INDEX IF NOT EXISTS idx_vb_user       ON virtual_backgrounds(user_id);
+CREATE INDEX IF NOT EXISTS idx_ls_channel    ON live_streams(channel_id);
+CREATE INDEX IF NOT EXISTS idx_ls_streamer   ON live_streams(streamer_id);
+CREATE INDEX IF NOT EXISTS idx_sv_user       ON stream_viewers(user_id);
+CREATE INDEX IF NOT EXISTS idx_br_parent     ON breakout_rooms(parent_channel);
+CREATE INDEX IF NOT EXISTS idx_cs_channel    ON collab_sessions(channel_id);
+
+-- ── Migration 28: Growth & Retention ──────────────────────────────────────
+
+ALTER TABLE server_recommendations
+    ADD CONSTRAINT fk_sr_user   FOREIGN KEY (user_id)   REFERENCES users(id)   ON DELETE CASCADE,
+    ADD CONSTRAINT fk_sr_server FOREIGN KEY (server_id) REFERENCES servers(id) ON DELETE CASCADE;
+
+ALTER TABLE onboarding_flows
+    ADD CONSTRAINT fk_of_server FOREIGN KEY (server_id) REFERENCES servers(id) ON DELETE CASCADE;
+
+ALTER TABLE device_sessions
+    ADD CONSTRAINT fk_ds_user FOREIGN KEY (user_id) REFERENCES users(id) ON DELETE CASCADE;
+
+ALTER TABLE clipboard_sync
+    ADD CONSTRAINT fk_cbs_user FOREIGN KEY (user_id) REFERENCES users(id) ON DELETE CASCADE;
+
+ALTER TABLE user_xp
+    ADD CONSTRAINT fk_ux_user   FOREIGN KEY (user_id)   REFERENCES users(id)   ON DELETE CASCADE,
+    ADD CONSTRAINT fk_ux_server FOREIGN KEY (server_id) REFERENCES servers(id) ON DELETE CASCADE;
+
+ALTER TABLE gamification_configs
+    ADD CONSTRAINT fk_gc_server FOREIGN KEY (server_id) REFERENCES servers(id) ON DELETE CASCADE;
+
+ALTER TABLE achievements
+    ADD CONSTRAINT fk_ach_server FOREIGN KEY (server_id) REFERENCES servers(id) ON DELETE CASCADE;
+
+ALTER TABLE user_achievements
+    ADD CONSTRAINT fk_ua_user FOREIGN KEY (user_id) REFERENCES users(id) ON DELETE CASCADE;
+
+ALTER TABLE activity_streaks
+    ADD CONSTRAINT fk_ast_user   FOREIGN KEY (user_id)   REFERENCES users(id)   ON DELETE CASCADE,
+    ADD CONSTRAINT fk_ast_server FOREIGN KEY (server_id) REFERENCES servers(id) ON DELETE CASCADE;
+
+ALTER TABLE sync_cursors
+    ADD CONSTRAINT fk_sc_user    FOREIGN KEY (user_id)    REFERENCES users(id)    ON DELETE CASCADE,
+    ADD CONSTRAINT fk_sc_channel FOREIGN KEY (channel_id) REFERENCES channels(id) ON DELETE CASCADE;
+
+ALTER TABLE offline_queue
+    ADD CONSTRAINT fk_oq_user FOREIGN KEY (user_id) REFERENCES users(id) ON DELETE CASCADE;
+
+CREATE INDEX IF NOT EXISTS idx_sr_user       ON server_recommendations(user_id);
+CREATE INDEX IF NOT EXISTS idx_sr_server     ON server_recommendations(server_id);
+CREATE INDEX IF NOT EXISTS idx_of_server     ON onboarding_flows(server_id);
+CREATE INDEX IF NOT EXISTS idx_ds_user       ON device_sessions(user_id);
+CREATE INDEX IF NOT EXISTS idx_ux_user       ON user_xp(user_id, server_id);
+CREATE INDEX IF NOT EXISTS idx_ach_server    ON achievements(server_id);
+CREATE INDEX IF NOT EXISTS idx_ast_user      ON activity_streaks(user_id, server_id);
+CREATE INDEX IF NOT EXISTS idx_sc_user       ON sync_cursors(user_id, channel_id);
+
+-- ── Migration 29: Sustainability ──────────────────────────────────────────
+
+ALTER TABLE governance_polls
+    ADD CONSTRAINT fk_gp_server  FOREIGN KEY (server_id)  REFERENCES servers(id) ON DELETE CASCADE,
+    ADD CONSTRAINT fk_gp_creator FOREIGN KEY (created_by) REFERENCES users(id)   ON DELETE SET NULL;
+
+ALTER TABLE poll_votes
+    ADD CONSTRAINT fk_pv_user FOREIGN KEY (user_id) REFERENCES users(id) ON DELETE CASCADE;
+
+ALTER TABLE governance_proposals
+    ADD CONSTRAINT fk_gprop_server FOREIGN KEY (server_id) REFERENCES servers(id) ON DELETE CASCADE,
+    ADD CONSTRAINT fk_gprop_author FOREIGN KEY (author_id) REFERENCES users(id)   ON DELETE SET NULL;
+
+ALTER TABLE contributor_badges
+    ADD CONSTRAINT fk_cb_user FOREIGN KEY (user_id) REFERENCES users(id) ON DELETE CASCADE;
+
+ALTER TABLE vulnerability_records
+    DROP CONSTRAINT IF EXISTS vulnerability_records_audit_id_fkey,
+    ADD CONSTRAINT fk_vr_audit FOREIGN KEY (audit_id) REFERENCES security_audits(id) ON DELETE CASCADE;
+
+ALTER TABLE tutorial_progress
+    ADD CONSTRAINT fk_tp_user FOREIGN KEY (user_id) REFERENCES users(id) ON DELETE CASCADE;
+
+CREATE INDEX IF NOT EXISTS idx_gp_server     ON governance_polls(server_id);
+CREATE INDEX IF NOT EXISTS idx_gp_creator    ON governance_polls(created_by);
+CREATE INDEX IF NOT EXISTS idx_pv_user       ON poll_votes(user_id);
+CREATE INDEX IF NOT EXISTS idx_gprop_server  ON governance_proposals(server_id);
+CREATE INDEX IF NOT EXISTS idx_gprop_author  ON governance_proposals(author_id);
+CREATE INDEX IF NOT EXISTS idx_cb_user       ON contributor_badges(user_id);
+CREATE INDEX IF NOT EXISTS idx_tp_user       ON tutorial_progress(user_id);
diff --git a/crates/nexus-db/src/repository/growth.rs b/crates/nexus-db/src/repository/growth.rs
@@ -52,11 +52,11 @@ pub async fn list_recommendations(
 pub async fn dismiss_recommendation(
     pool: &AnyPool,
     user_id: Uuid,
-    server_id: Uuid,
+    rec_id: Uuid,
 ) -> Result<(), sqlx::Error> {
-    sqlx::query("UPDATE server_recommendations SET dismissed = TRUE WHERE user_id = $1 AND server_id = $2")
+    sqlx::query("UPDATE server_recommendations SET dismissed = TRUE WHERE id = $1 AND user_id = $2")
+        .bind(rec_id.to_string())
         .bind(user_id.to_string())
-        .bind(server_id.to_string())
         .execute(pool)
         .await?;
     Ok(())
@@ -285,7 +285,8 @@ pub async fn award_achievement(
 ) -> Result<UserAchievement, sqlx::Error> {
     let q = format!(
         "INSERT INTO user_achievements (user_id, achievement_id) \
-         VALUES ($1, $2) ON CONFLICT DO NOTHING \
+         VALUES ($1, $2) \
+         ON CONFLICT (user_id, achievement_id) DO UPDATE SET earned_at = user_achievements.earned_at \
          RETURNING {USER_ACHIEVEMENT_COLS}"
     );
     sqlx::query_as::<_, UserAchievement>(&q)
@@ -297,6 +298,24 @@ pub async fn award_achievement(
 
 // ── 23-04: Sync Cursors / Offline Queue ───────────────────────────────────
 
+pub async fn get_sync_cursor(
+    pool: &AnyPool,
+    user_id: Uuid,
+    device_id: &str,
+    channel_id: Uuid,
+) -> Result<Option<SyncCursor>, sqlx::Error> {
+    let q = format!(
+        "SELECT {SYNC_CURSOR_COLS} FROM sync_cursors \
+         WHERE user_id = $1 AND device_id = $2 AND channel_id = $3"
+    );
+    sqlx::query_as::<_, SyncCursor>(&q)
+        .bind(user_id.to_string())
+        .bind(device_id)
+        .bind(channel_id.to_string())
+        .fetch_optional(pool)
+        .await
+}
+
 pub async fn upsert_sync_cursor(
     pool: &AnyPool,
     user_id: Uuid,
diff --git a/crates/nexus-db/src/repository/sustainability.rs b/crates/nexus-db/src/repository/sustainability.rs
@@ -139,7 +139,8 @@ pub async fn cast_vote(
 ) -> Result<PollVote, sqlx::Error> {
     let q = format!(
         "INSERT INTO poll_votes (poll_id, user_id, option_index) \
-         VALUES ($1, $2, $3) ON CONFLICT DO NOTHING \
+         VALUES ($1, $2, $3) \
+         ON CONFLICT (poll_id, user_id, option_index) DO UPDATE SET voted_at = poll_votes.voted_at \
          RETURNING {POLL_VOTE_COLS}"
     );
     sqlx::query_as::<_, PollVote>(&q)
diff --git a/crates/nexus-desktop/src/invoke.ts b/crates/nexus-desktop/src/invoke.ts
