Skip to content

Unresponsive PRs and issues #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
harshildarji opened this issue Aug 27, 2019 · 12 comments
Closed

Unresponsive PRs and issues #1155

harshildarji opened this issue Aug 27, 2019 · 12 comments
Assignees

Comments

@harshildarji
Copy link
Member

harshildarji commented Aug 27, 2019

To @cclauss @AnupKumarPanwar @poyea


Hey all,
At this moment, we have over 150 PRs. Some of these are requested changes by the reviewers, but there is no response from the PR makers after that. Some PRs are months old which now may cause conflicts with current implementations if merged.
Therefore, I plan to close such PRs which have no response from people who made it or is months old which might break an existing implementation.
But before doing so, I would like to know what other members think about this.
Thank you.

Best regards,
Harshil Darji

@cclauss
Copy link
Member

cclauss commented Aug 27, 2019

My sense is that we should implement #1134.

It is better if it is automated using GitHub's tool rather than doing it manually.

@QuantumNovice
Copy link
Contributor

One of the reason why #1134 should be accepted.

@harshildarji
Copy link
Member Author

@cclauss I agree. Doing so manually is tedious and it is also not my intention considering the number of open PRs. But we have to do this ASAP so we can focus only on PRs which are important and close the ones which are unnecessary and unresponsive.

@cclauss
Copy link
Member

cclauss commented Aug 27, 2019

@harshildarji
Copy link
Member Author

harshildarji commented Aug 28, 2019

@AnupKumarPanwar @dynamitechetan @r0hit-gupta I've sent the request to install stale.
@cclauss Thanks for approving #1158.

@r0hit-gupta
Copy link
Member

@harshildarji I have approved the request. Please go forward.

@harshildarji
Copy link
Member Author

@r0hit-gupta Hey, Thanks for approving this. It's installed but since I do not have permission to configure it, you'll have to do it as an owner.
Visit configure stale to configure it to work with Python repo.
Thank you.

@cclauss cclauss removed their assignment Oct 3, 2019
@cclauss
Copy link
Member

cclauss commented Oct 3, 2019

I do not have the rights to turn this on but it should be turned on.

@harshildarji
Copy link
Member Author

@cclauss I think so. I also do not have rights for that!

@chttrjeankr
Copy link
Contributor

I think using GitHub actions to check stale issues and PRs can be done now, since GitHub Actions is open for public.
Searched a bit and created this gist which I think will be apt for TheAlgorithms/Python repository, but I am unable to understand how exactly can I implement this. Can I please have some help to implement this into the repository? 🙏

@cclauss
Copy link
Member

cclauss commented Nov 15, 2019

https://github.com/marketplace/stale is all we need. It is free from GitHub. Someone with Admin privileges just needs to turn in on.

@chttrjeankr
Copy link
Contributor

I was suggesting we use this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants
@cclauss @AnupKumarPanwar @harshildarji @r0hit-gupta @poyea @chttrjeankr @QuantumNovice and others