-
Notifications
You must be signed in to change notification settings - Fork 90
Support for Tokio 0.3 #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
To benefit from Tokio 0.3 I think it would make sense to wait for reqwest to update to 0.3 which in turn is blocked on updating hyper to 0.3. As you can see by the number of mentions in the last issue, the whole Rust internet ecosystem is blocked on hyper updating to 0.3. When reqwest's update lands, |
Oh, now I see the bigger picture of dependencies. Thanks for the clarification! With that in mind, I don't see any advantage of updating cloud-storage before the rest of the ecosystem. I made it work with tokio 0.3 by using the compatibility crate I mentioned, and when it updates to 0.3, all I'll have to do is remove the Thanks for the quick reply, I wish all project maintainers were like that :) lol |
Reqwest is updated! That means that cloud-storage can now follow suit! |
We failed to get support for Tokio 0.3 as the PR requests, but since 0.7 has landed with support for Tokio 1.0, I think its time to close the PR nonetheless. |
Uh oh!
There was an error while loading. Please reload this page.
The crate currently depends on Tokyo ^0.2, but maybe it would be beneficial to update to the new version since it's considered a beta before 1.0.
If you try to run a program that uses both the
cloud-storage
and thetokio 0.3
crates, you get a "thread 'main' panicked at 'not currently running on the Tokio runtime." error.For now, I can use the tokio-compat-02 crate as a workaround, and it could also be used when updating
cloud-storage
to use tokio 0.3, while its other dependencies also update themselves to use it.The text was updated successfully, but these errors were encountered: