Activates asan in tests/fuzzer for msvc (#36)

Author: TinyTinni

.github/workflows/cmake.yml

@@ -8,7 +8,7 @@ on:
 
 env:
   # Customize the CMake build type here (Release, Debug, RelWithDebInfo, etc.)
-  BUILD_TYPE: Release
+  BUILD_TYPE: RelWithDebInfo
 
 
 jobs:
@@ -25,6 +25,13 @@ jobs:
       with:
         python-version: '3.13' 
 
+    # setup toolchain for asan
+    - name: Setup MSVC dev command prompt
+      uses: TheMrMilchmann/setup-msvc-dev@v3
+      with:
+        arch: x64
+      if: contains(matrix.os, 'windows' )
+
     - name: Configure CMake
       # Configure CMake in a 'build' subdirectory. `CMAKE_BUILD_TYPE` is only required if you are using a single-configuration generator such as make.
       # See https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html?highlight=cmake_build_type
@@ -45,7 +52,7 @@ jobs:
     - name: Test
       working-directory: ${{github.workspace}}/build
       env:
-        RC_PARAMS: "max_success=1000"
+        RC_PARAMS: "max_success=300"
       # Execute tests defined by the CMake configuration.
       # See https://cmake.org/cmake/help/latest/manual/ctest.1.html for more detail
       run: ctest --output-on-failure -C ${{env.BUILD_TYPE}}

fuzzing/CMakeLists.txt

@@ -4,14 +4,11 @@ set(FUZZ_RUNTIME
 
 set (CMAKE_CXX_STANDARD 17)
 add_executable(fuzzing main.cpp)
-target_link_libraries(fuzzing PRIVATE -coverage -fsanitize=fuzzer)
 if ("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang")
-	target_compile_options(fuzzing PRIVATE -fsanitize=fuzzer)
+	target_compile_options(fuzzing PRIVATE -coverage -fsanitize=fuzzer)
     target_link_libraries(fuzzing PUBLIC -fsanitize=address,undefined)
-    target_compile_definitions(fuzzing PRIVATE "-D_LIBCPP_DISABLE_DEPRECATION_WARNINGS")
 elseif("${CMAKE_CXX_COMPILER_ID}" MATCHES "MSVC")
-	target_compile_options(fuzzing PRIVATE /fsanitize=fuzzer)
-    target_compile_definitions(fuzzing PRIVATE "-D_SILENCE_ALL_CXX17_DEPRECATION_WARNINGS")
+	target_compile_options(fuzzing PRIVATE /fsanitize=fuzzer /fsanitize=address)
 endif()
 
 target_link_libraries(fuzzing PRIVATE ValveFileVDF)

tests/CMakeLists.txt

@@ -18,6 +18,8 @@ target_compile_options(tests PRIVATE
 
 if ("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang")
     target_link_libraries(tests PUBLIC -fsanitize=address,undefined)
+elseif("${CMAKE_CXX_COMPILER_ID}" MATCHES "MSVC")
+    target_compile_options(tests PRIVATE /fsanitize=address)
 endif()
 
 

tests/proptests/CMakeLists.txt

@@ -24,6 +24,10 @@ target_compile_options(rapidcheck_tests PRIVATE
 
 if ("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang")
     target_link_libraries(rapidcheck_tests PUBLIC -fsanitize=address,undefined)
+elseif("${CMAKE_CXX_COMPILER_ID}" MATCHES "MSVC")
+    # disable annotations or possible annotation mismatch with librapidcheck. It is not really required by the vdf parser
+    target_compile_definitions(rapidcheck_tests PRIVATE "_DISABLE_VECTOR_ANNOTATION" "_DISABLE_STRING_ANNOTATION") 
+    target_compile_options(rapidcheck_tests PRIVATE /fsanitize=address)
 endif()