Skip to content

Commit 86167c2

Browse files
committed
build: run lint before tests
Have `make test` run linting tools before tests rather than after. Lint is likely to find issues quickly. Tests may take a while to run. So do the linting first. Interestingly, it appears that `vcbuild.bat` is already set up this way on Windows. Refs: nodejs#4546 (comment)
1 parent ffdc046 commit 86167c2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,9 +111,9 @@ v8:
111111
$(MAKE) -C deps/v8 $(V8_ARCH) $(V8_BUILD_OPTIONS)
112112

113113
test: | cctest # Depends on 'all'.
114-
$(PYTHON) tools/test.py --mode=release message parallel sequential -J
115114
$(MAKE) jslint
116115
$(MAKE) cpplint
116+
$(PYTHON) tools/test.py --mode=release message parallel sequential -J
117117

118118
test-parallel: all
119119
$(PYTHON) tools/test.py --mode=release parallel -J

0 commit comments

Comments
 (0)