Skip to content

Commit 8efee55

Browse files
committed
test: fix freebsd10-64 CI failures
Remove unneeded timers from some tests and move others from parallel testing to sequential testing. This is to resolve test failures on freebsd10-64 on CI. The failures are all due to timers firing later than expected. Timers firing later than they are set for can happen on resource-constrained hosts and is not a bug. In general, it may be wise to put tests that depend on timing into sequential testing rather than parallel testing, as the timing can be affected by other simultaneously-running test processes. Fixes: nodejs#8041 Fixes: nodejs#9227
1 parent 2c6ca32 commit 8efee55

6 files changed

+0
-10
lines changed

test/parallel/test-dgram-send-callback-multi-buffer.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,8 @@ const dgram = require('dgram');
66

77
const client = dgram.createSocket('udp4');
88

9-
const timer = setTimeout(function() {
10-
throw new Error('Timeout');
11-
}, common.platformTimeout(200));
12-
139
const messageSent = common.mustCall(function messageSent(err, bytes) {
1410
assert.equal(bytes, buf1.length + buf2.length);
15-
clearTimeout(timer);
1611
});
1712

1813
const buf1 = Buffer.alloc(256, 'x');

test/parallel/test-dgram-send-multi-buffer-copy.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,8 @@ const dgram = require('dgram');
66

77
const client = dgram.createSocket('udp4');
88

9-
const timer = setTimeout(function() {
10-
throw new Error('Timeout');
11-
}, common.platformTimeout(200));
12-
139
const onMessage = common.mustCall(function(err, bytes) {
1410
assert.equal(bytes, buf1.length + buf2.length);
15-
clearTimeout(timer);
1611
});
1712

1813
const buf1 = Buffer.alloc(256, 'x');

0 commit comments

Comments
 (0)