Skip to content

Commit be8108b

Browse files
committed
Apply suggestions from code review
1 parent 70d124a commit be8108b

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

docs/src/internals/submodel_condition.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,7 @@ myprefix(big_ctx, @varname(x))
306306
```
307307

308308
This is a much better result!
309-
The implementation of related functions such as `hasconditioned_nested` and `getconditioned_nested`, under the hood, use a similar recursion scheme, so you will find that this is a common pattern when reading the source code of various prefixing-related functions, you will find that this is a common pattern
309+
The implementation of related functions such as `hasconditioned_nested` and `getconditioned_nested`, under the hood, use a similar recursion scheme, so you will find that this is a common pattern when reading the source code of various prefixing-related functions.
310310
When editing this code, it is worth being mindful of this as a potential source of incorrectness.
311311

312312
!!! info

src/contexts.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -426,7 +426,7 @@ hasconditioned_nested(::IsLeaf, context, vn) = hasconditioned(context, vn)
426426
function hasconditioned_nested(::IsParent, context, vn)
427427
return hasconditioned(context, vn) || hasconditioned_nested(childcontext(context), vn)
428428
end
429-
function hasconditioned_nested(context::PrefixContext{Prefix}, vn) where {Prefix}
429+
function hasconditioned_nested(context::PrefixContext, vn)
430430
return hasconditioned_nested(collapse_prefix_stack(context), vn)
431431
end
432432

@@ -444,7 +444,7 @@ end
444444
function getconditioned_nested(::IsLeaf, context, vn)
445445
return error("context $(context) does not contain value for $vn")
446446
end
447-
function getconditioned_nested(context::PrefixContext{Prefix}, vn) where {Prefix}
447+
function getconditioned_nested(context::PrefixContext, vn)
448448
return getconditioned_nested(collapse_prefix_stack(context), vn)
449449
end
450450
function getconditioned_nested(::IsParent, context, vn)

0 commit comments

Comments
 (0)