[TT-278] Fix ensuring transport to upstream (#3329)

* Fix ensuring transport to upstream

Fixes #3259
This refactors EnsureTransport function for properly ensuring transport
is present on the host when  load balancer is enabled.

We rely on url.Parse to do heavy lifting. We add missing Scheme field to
make sure URL.String will return a valid
upstream host.

* use http when scheme and protocol are missing

Author: gernest

gateway/reverse_proxy.go

@@ -157,7 +157,6 @@ func nextTarget(targetData *apidef.HostList, spec *APISpec) (string, error) {
 			}
 
 			host := EnsureTransport(gotHost, spec.Protocol)
-
 			if !spec.Proxy.CheckHostAgainstUptimeTests {
 				return host, nil // we don't care if it's up
 			}

gateway/reverse_proxy_test.go

@@ -1028,3 +1028,23 @@ func BenchmarkCopyRequestResponse(b *testing.B) {
 		}
 	}
 }
+
+func TestEnsureTransport(t *testing.T) {
+	cases := []struct {
+		host, protocol, expect string
+	}{
+		{"https://httpbin.org ", "https", "https://httpbin.org"},
+		{"httpbin.org ", "https", "https://httpbin.org"},
+		{"http://httpbin.org ", "https", "http://httpbin.org"},
+		{"httpbin.org ", "tls", "tls://httpbin.org"},
+		{"httpbin.org ", "", "http://httpbin.org"},
+	}
+	for i, v := range cases {
+		t.Run(fmt.Sprintf("case-%d", i), func(t *testing.T) {
+			g := EnsureTransport(v.host, v.protocol)
+			if g != v.expect {
+				t.Errorf("expected %q got %q", v.expect, g)
+			}
+		})
+	}
+}

go.mod

@@ -20,7 +20,7 @@ require (
 	github.com/alecthomas/units v0.0.0-20190924025748-f65c72e2690d // indirect
 	github.com/bshuster-repo/logrus-logstash-hook v0.4.1
 	github.com/buger/jsonparser v1.1.1
-	github.com/cenk/backoff v2.2.1+incompatible // indirect
+	github.com/cenk/backoff v2.2.1+incompatible
 	github.com/cenkalti/backoff/v4 v4.0.2
 	github.com/certifi/gocertifi v0.0.0-20190905060710-a5e0173ced67 // indirect
 	github.com/clbanning/mxj v1.8.4
@@ -29,6 +29,8 @@ require (
 	github.com/emanoelxavier/openid2go v0.0.0-20190718021401-6345b638bfc9 // indirect
 	github.com/evalphobia/logrus_sentry v0.8.2
 	github.com/facebookgo/clock v0.0.0-20150410010913-600d898af40a // indirect
+	github.com/franela/goblin v0.0.0-20211003143422-0a4f594942bf // indirect
+	github.com/franela/goreq v0.0.0-20171204163338-bcd34c9993f8
 	github.com/gemnasium/logrus-graylog-hook v2.0.7+incompatible
 	github.com/getkin/kin-openapi v0.32.0
 	github.com/getsentry/raven-go v0.2.0 // indirect

go.sum

@@ -121,6 +121,10 @@ github.com/facebookgo/clock v0.0.0-20150410010913-600d898af40a h1:yDWHCSQ40h88yi
 github.com/facebookgo/clock v0.0.0-20150410010913-600d898af40a/go.mod h1:7Ga40egUymuWXxAe151lTNnCv97MddSOVsjpPPkityA=
 github.com/fatih/color v1.7.0/go.mod h1:Zm6kSWBoL9eyXnKyktHP6abPY2pDugNf5KwzbycvMj4=
 github.com/fatih/structs v1.1.0/go.mod h1:9NiDSp5zOcgEDl+j00MP/WkGVPOlPRLejGD8Ga6PJ7M=
+github.com/franela/goblin v0.0.0-20211003143422-0a4f594942bf h1:NrF81UtW8gG2LBGkXFQFqlfNnvMt9WdB46sfdJY4oqc=
+github.com/franela/goblin v0.0.0-20211003143422-0a4f594942bf/go.mod h1:VzmDKDJVZI3aJmnRI9VjAn9nJ8qPPsN1fqzr9dqInIo=
+github.com/franela/goreq v0.0.0-20171204163338-bcd34c9993f8 h1:a9ENSRDFBUPkJ5lCgVZh26+ZbGyoVJG7yb5SSzF5H54=
+github.com/franela/goreq v0.0.0-20171204163338-bcd34c9993f8/go.mod h1:ZhphrRTfi2rbfLwlschooIH4+wKKDR4Pdxhh+TRoA20=
 github.com/fsnotify/fsnotify v1.4.7/go.mod h1:jwhsz4b93w/PPRr/qN1Yymfu8t87LnFCMoQvtojpjFo=
 github.com/fsnotify/fsnotify v1.4.9 h1:hsms1Qyu0jgnwNXIxa+/V/PDsU6CfLf6CNO8H7IWoS4=
 github.com/fsnotify/fsnotify v1.4.9/go.mod h1:znqG4EE+3YCdAaPaxE2ZRY/06pZUdp0tY4IgpuI1SZQ=