Skip to content

Enhancement: Implement Tsickle for Google Closure Compiler #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TheLarkInn opened this issue Jun 7, 2016 · 8 comments
Closed

Enhancement: Implement Tsickle for Google Closure Compiler #224

TheLarkInn opened this issue Jun 7, 2016 · 8 comments
Labels

Comments

@TheLarkInn
Copy link

Currently there is an angular project which I think could benefit all Typescript users.

As we all know, Google closure compiler is still the most efficient minifier, however requires annotations for it to be used in ADVANCED mode.

https://github.com/angular/tsickle

This project is using a baked tsc that automagically converts decorators and types to annotations that allow for GCC to understand.

Since Webpack2 is implementing LoaderOptionsPlugin which hands the responsibilities of minifying to the loader, it would be perfect timing to add a minify feature into the loader.

Thoughts?

Cross reference post to both ts loaders.
s-panferov/awesome-typescript-loader#153

@nathanosdev
Copy link

Would love to see this! Need any help?

@johnnyreilly
Copy link
Member

If you'd like to have a crack at implementation then go for it! We gratefully accept PRs

@nathanosdev
Copy link

Did you have any preferences on the configuration for this? Like just a boolean flag to turn tsickle on or off from the user's point of view?

@johnnyreilly
Copy link
Member

That sounds like a good starting point. Essentially anything can be refined at any point though - have a play and see what you come up with would be my advice.

@nathanosdev
Copy link

Sounds good, I'll post back when I come up with something.

@stale
Copy link

stale bot commented Jan 19, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

1 similar comment
@stale
Copy link

stale bot commented Mar 20, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 20, 2019
@stale
Copy link

stale bot commented Mar 27, 2019

Closing as stale. Please reopen if you'd like to work on this further.

@stale stale bot closed this as completed Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants