Skip to content

Extended interface does not show extended properties #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ORESoftware opened this issue Jun 15, 2017 · 4 comments
Closed

Extended interface does not show extended properties #532

ORESoftware opened this issue Jun 15, 2017 · 4 comments

Comments

@ORESoftware
Copy link

ORESoftware commented Jun 15, 2017

I have this:

export interface IClient extends Client {
  __inactiveTimeoutX: Timer,
  returnToPool: Function,
  ldapPoolRemoved?: boolean
  cdtClientId: number;
}

where Client is

import {Client} from '@types/ldapjs';

export interface Client extends EventEmitter {

	connected: boolean;

	bind(dn: string, password: string, callback: CallBack): void;
	bind(dn: string, password: string, controls: Control | Array<Control>, callback: CallBack): void;

	add(name: string, entry: Object, callback: ErrorCallback): void;
	add(name: string, entry: Object, controls: Control | Array<Control>, callback: ErrorCallback): void;

	compare(name: string, attr: string, value: string, callback: CompareCallback): void;
	compare(name: string, attr: string, value: string, controls: Control | Array<Control>, callback: CompareCallback): void;

	exop(name: string, value: string, callback: ExopCallback): void;
	exop(name: string, value: string, controls: Control | Array<Control>, callback: ExopCallback): void;

	modify(name: string, change: Change | Array<Change>, callback: ErrorCallback): void;
	modify(name: string, change: Change | Array<Change>, controls: Control | Array<Control>, callback: ErrorCallback): void;

	modifyDN(name: string, newName: string, callback: ErrorCallback): void;
	modifyDN(name: string, newName: string, controls: Control | Array<Control>, callback: ErrorCallback): void;


	search(base: string, options: SearchOptions, callback: SearchCallBack): void;
	search(base: string, options: SearchOptions, callback: SearchCallBack, _bypass: boolean): void;
	search(base: string, options: SearchOptions, controls: Control | Array<Control>, callback: SearchCallBack): void;
	search(base: string, options: SearchOptions, controls: Control | Array<Control>, callback: SearchCallBack, _bypass: boolean): void;

	
	starttls(options: Object, controls: Control | Array<Control>, callback: CallBack): void;
	starttls(options: Object, controls: Control | Array<Control>, callback: CallBack, _bypass: boolean): void;

	
	unbind(callback?: ErrorCallback): void;
	destroy(err?: any): void;
}

It would be really nice if the UI of the docs reflected that IClient has these inherited properties as well, but it doesn't. All I see is:

screenshot 2017-06-14 20 01 22

@ORESoftware
Copy link
Author

I guess they do show that IClient inherits from Client, but there is no "link to Client"

@kuuroro
Copy link

kuuroro commented Mar 18, 2020

i have the same problem

@ayZagen
Copy link

ayZagen commented Oct 8, 2020

probably related to #1094

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Nov 28, 2020

This behaves as expected in 0.20. There's no link to Client here either, but that is because Client is not exported and therefore not considered to be part of the docs.

image

If I export Client as well, this works as expected:

image

@Gerrit0 Gerrit0 added the bug label Nov 28, 2020
@Gerrit0 Gerrit0 closed this as completed Dec 28, 2020
@Gerrit0 Gerrit0 removed the bug label Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants