-
Notifications
You must be signed in to change notification settings - Fork 244
fix auth loops #3087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix auth loops #3087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craig8
commented
Jun 5, 2023
craig8
commented
Jun 5, 2023
shwethanidd
approved these changes
Jun 5, 2023
| _log.debug( | ||
| "Connecting using: %s", get_fq_identity(self.identity) | ||
| ) | ||
| _log.debug("Connecting using: %s", get_fq_identity(self.identity)) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
This expression logs [sensitive data (password)](1) as clear text.
This expression logs [sensitive data (password)](1) as clear text.
| _log.debug( | ||
| "Connecting using: %s", get_fq_identity(self.identity) | ||
| ) | ||
| _log.debug("Connecting using: %s", get_fq_identity(self.identity)) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
This expression logs [sensitive data (password)](1) as clear text.
This expression logs [sensitive data (password)](1) as clear text.
| url_address=info.rmq_address, ssl_auth=True) | ||
| remote_rmq_user = get_fq_identity(fqid_local, | ||
| info.instance_name) | ||
| _log.debug("REMOTE RMQ USER IS: %s", remote_rmq_user) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
This expression logs [sensitive data (password)](1) as clear text.
This expression logs [sensitive data (password)](1) as clear text.
rebwang
pushed a commit
to rebwang/volttron
that referenced
this pull request
Nov 29, 2025
fix auth loops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes updates to the logger as well as improvements in the way the watchers work. Files that were modified also were reformatted, though I tried to keep the reformatting as different commits than the true changes.
Fixes #3307
Type of change
Please delete options that are not relevant.
After this PR startup sequence of VOLTTRON (-v)
Before PR startup sequence VOLTTRON (-v)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Tested on my branch and develop using python 3.8 on ubuntu 20.04
Checklist: