Skip to content

Conversation

@davidraker
Copy link
Contributor

Description

Replaces yaml.load(file) with yaml.safe_load(file). This is necessary for yaml 6.0 compatability, and also closes a possible code injection possiblity.

Fixes # 3100

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [ ]

How Has This Been Tested?

Tests for the modbus_tk driver have been run manually, and work after the change.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@craig8 craig8 merged commit 1c7e490 into VOLTTRON:develop Aug 17, 2023
@davidraker davidraker deleted the yaml_load_fix branch August 9, 2025 16:30
rebwang pushed a commit to rebwang/volttron that referenced this pull request Nov 29, 2025
Updaed yaml.load(file) to yaml.safe_load(file).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants