Skip to content

Conversation

@davidraker
Copy link
Contributor

@davidraker davidraker commented Jan 24, 2025

Description

The watchdog package added a requirement for keyword arguments in version 5.0.0. The current version watchdog is 6.0.0, so new environments will fail when the VolttronHomeFileReloader or AbsolutePathFileReloader are used. This affects the web API on startup, since VolttronHomeFileReloaders is used for web-users.json.

Unfortunately, simply updating to use keyword arguments also broke other things when running on python 3.8, as watchdog removed support for python 3.8 in the same version. Instead, pinned watchdog version to less than 5.0.0, since we need to continue support for python 3.8.

Fixes #3200

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Started Volttron with and without the change while a bind-web-address was set. The error described in #3200 is present without the fix and no longer appears with the fix.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@craig8 craig8 merged commit a87f3a3 into VOLTTRON:develop Jan 25, 2025
14 of 15 checks passed
@davidraker davidraker deleted the file_reloader branch January 29, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants