Skip to content

Webpack 5 compatibility #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davidmpaz opened this issue Sep 23, 2019 · 4 comments
Closed

Webpack 5 compatibility #83

davidmpaz opened this issue Sep 23, 2019 · 4 comments

Comments

@davidmpaz
Copy link

Hello,

First of all thanks for the work done on this plugin. This is not an issue, it is more a question about webpack 5 compatibility.

How it is planned the use of this plugin in webpack 5?
Would it face some compatibility issue?

The reason behind this question is the realization of: symfony/webpack-encore#145

Best regards,
David

@Va1
Copy link
Owner

Va1 commented Apr 8, 2020

hi David,

sorry for delayed reply.

so far, all webpack versions were supported by me or by community supplying pull requests upon major webpack release. worth mentioning is that there was no big compatibility issues and that the webpack APIs used by this package barely change. but you never know, of course.

unless you or someone else of the community wants to check it now against webpack 5-beta, i would wait for webpack 5 release and see what happens.

regards

@tarponjargon
Copy link

Hi - just checking if there are plans to pursue wp5 compatibility. I had browser-sync-webpack-plugin working with the last version wp4 but can't seem to get it working with 5

@Va1
Copy link
Owner

Va1 commented Nov 15, 2020

hi @tarponjargon

for the time being, support of Webpack 5 can be achieved only via community contribution.

this means, if you have a project where you've upgraded to Webpack v5 and this plugin now causes failure, i encourage you to investigate what is going wrong and submit a PR with a fix. i can help you with debugging and all administrative stuff, but, myself, i do not have a Webpack project (nor time to create/find one) to test with and patch things myself.

cheers

@Va1
Copy link
Owner

Va1 commented Dec 21, 2020

so, as was outlined by @Locheed in this PR, the plugin in its current state is compatible with Webpack 5. so, to avoid warnings/errors while installing it on Webpack 5 projects, I have merged the mentioned PR and bumped the version to 2.3.0. thanks everyone for participating.

@Va1 Va1 closed this as completed Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants