[IMP] controller_report_xls: Apply pre-commit-vauxoo fixes

- Fix undefined variable 'cssstyle' in get_css_style function
- Fix undefined variable 'result' in match_color_index function
- Improve string comparison using truthiness instead of empty string
  check

Author: CDanielSanSeg

controller_report_xls/controllers/main.py

@@ -19,6 +19,7 @@ def get_css_style(csstext, style):
     cssutils.log.setLevel(logging.CRITICAL)
     cssnode = parseString(csstext)
     stylesheet = cssnode.cssRules
+    cssstyle = None
     for rule in stylesheet:
         if rule.selectorText.replace(".", "") == style:
             cssstyle = str(rule.style.cssText)
@@ -30,9 +31,9 @@ def get_odoo_style(html, style, node):
         for class_style in node.attrib.get("class", False).split():
             for style_element in html.xpath('//style[@type="text/css"]'):
                 styleclass = get_css_style(style_element.text, class_style)
-                style.update(dict(item.split(":") for item in text_adapt(styleclass).split(";") if item != ""))
+                style.update(dict(item.split(":") for item in text_adapt(styleclass).split(";") if item))
     if node.attrib.get("style", False):
-        style.update(dict(item.split(":") for item in node.attrib.get("style").split(";") if item != ""))
+        style.update(dict(item.split(":") for item in node.attrib.get("style").split(";") if item))
     return style
 
 

controller_report_xls/reports/report_xls.py

@@ -31,7 +31,7 @@ def get_odoo_style(html, style, node):
         for class_style in node.attrib.get("class", False).split():
             for style_element in html.xpath('//style[@type="text/css"]'):
                 styleclass = get_css_style(style_element.text, class_style)
-                style.update(dict(item.split(":") for item in text_adapt(styleclass).split(";") if item != ""))
+                style.update(dict(item.split(":") for item in text_adapt(styleclass).split(";") if item))
     if node.attrib.get("style", False):
         style_nodes = [style_node.strip() for style_node in node.attrib.get("style").split(";") if style_node.strip()]
         style.update(dict(item.split(":", 1) for item in style_nodes))

controller_report_xls/reports/xfstyle.py

@@ -260,6 +260,7 @@ def match_color_index(color):
     color = htmlcolortorgb(color)
     if isinstance(color, int):
         return color
+    result = None
     if color:
         distances = [color_distance(color, x) for x in XLWT_COLORS]
         result = distances.index(min(distances))