Skip to content

Commit f990a6a

Browse files
author
Shemesh, Ofir
committed
fix a memory leak
1 parent 4881538 commit f990a6a

File tree

4 files changed

+15
-8
lines changed

4 files changed

+15
-8
lines changed

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,3 +33,5 @@ bower_components
3333

3434
# ignore css map files.
3535
*.css.map
36+
37+
package-lock.json

angular-ui-tab-scroll.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
* angular-ui-tab-scroll
33
* https://github.com/VersifitTechnologies/angular-ui-tab-scroll
44
*
5-
* Version: 2.3.4
5+
* Version: 2.3.5
66
* License: MIT
77
*/
88

@@ -362,10 +362,14 @@ angular.module('ui.tab.scroll', [])
362362
$scope.dropdownTabs.push(tabScope);
363363
}
364364
});
365+
} else {
366+
$scope.dropdownTabs = [];
365367
}
366368

367369
$scope.reCalcSides();
368-
}
370+
} else {
371+
$scope.dropdownTabs = [];
372+
}
369373
};
370374

371375
// this is how we init for the first time.
@@ -376,6 +380,7 @@ angular.module('ui.tab.scroll', [])
376380
// when scope destroyed
377381
$scope.$on('$destroy', function () {
378382
angular.element($window).off('resize', $scope.onWindowResize);
383+
$scope.dropdownTabs = [];
379384
});
380385

381386
}

bower.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "angular-ui-tab-scroll",
33
"main": ["angular-ui-tab-scroll.js","angular-ui-tab-scroll.css"],
4-
"version": "2.3.4",
4+
"version": "2.3.5",
55
"homepage": "https://github.com/VersifitTechnologies/angular-ui-tab-scroll",
66
"description": "A scrollable tab plugin intended for scrolling UI Bootstrap tabset",
77
"keywords": [

package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
{
22
"name": "angular-ui-tab-scroll",
3-
"version": "2.3.4",
3+
"version": "2.3.5",
44
"homepage": "https://github.com/VersifitTechnologies/angular-ui-tab-scroll",
55
"description": "A scrollable tab plugin intended for scrolling UI Bootstrap tabset.",
6-
"license" : "MIT",
7-
"repository" : {
8-
"type" : "git",
9-
"url" : "https://github.com/VersifitTechnologies/angular-ui-tab-scroll"
6+
"license": "MIT",
7+
"repository": {
8+
"type": "git",
9+
"url": "https://github.com/VersifitTechnologies/angular-ui-tab-scroll"
1010
},
1111
"keywords": [
1212
"ui",

0 commit comments

Comments
 (0)