Refactoring2 (Code-Hex#2)

* getType

* reduce visitor

* rm redundant factories

* fixed 2 indent

* wip

* wip2

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* lazy

* wip

* reduce

* fix

* pass fieldMetadata

* ren

* fix

* fix

* create lazy

* apply lazy

* islazy

* wip

* wip

* lazier

* rm shouldBeLazy

* todo

* note

* todo

* ref

* rm unused imports

* pass renderer

* pass render 2

* pass renderer 3

* rules render

* refactor rules

* cleanup

* fix deps

* FieldFactory

* metad

* wip

* factory of rule

* rm awkward object

* ref

* rm directiveFactory

* name in metadata

* optional

* super rename

* wip

* AST

* split schemaASTRenderer

* fix

* reduce

* prv

* ref

* interim

* reduce visitor

* reduce field

* wip

* ren

* simplify1

* kind

* SchemaASTFac

* name

* robustness

* reduce deps

* rm scalarRenderer

* robust kind

* factory method

* 2

* split scalar types

* refactor

* lintfix

* bump 0.7.2

Author: wand2016

example/test.graphql

@@ -15,7 +15,11 @@ type Guest {
 
 union UserKind = Admin | Guest
 
-type User {
+interface Node {
+  id: ID
+}
+
+type User implements Node {
   id: ID
   name: String
   email: String

example/types.ts

@@ -103,6 +103,10 @@ export type MyTypeFooArgs = {
   d: Scalars['Float']['input'];
 };
 
+export type Node = {
+  id?: Maybe<Scalars['ID']['output']>;
+};
+
 export type PageInput = {
   attributes?: InputMaybe<Array<AttributeInput>>;
   date?: InputMaybe<Scalars['Date']['input']>;
@@ -124,7 +128,7 @@ export enum PageType {
   Service = 'SERVICE'
 }
 
-export type User = {
+export type User = Node & {
   __typename?: 'User';
   createdAt?: Maybe<Scalars['Date']['output']>;
   email?: Maybe<Scalars['String']['output']>;

package.json

@@ -1,6 +1,6 @@
 {
   "name": "graphql-codegen-lighthouse-yup-schema",
-  "version": "0.7.1",
+  "version": "0.7.2",
   "description": "GraphQL Code Generator plugin to generate form validation schema from your GraphQL schema",
   "respository": {
     "type": "git",

src/LaravelValidationRule.ts

@@ -1,71 +1,51 @@
 import { TsVisitor } from '@graphql-codegen/typescript';
 import { NormalizedScalarsMap } from '@graphql-codegen/visitor-plugin-common';
-import { FieldDefinitionNode, GraphQLSchema, NameNode, ObjectTypeDefinitionNode } from 'graphql';
+import { GraphQLSchema, Kind } from 'graphql';
 
 import { ValidationSchemaPluginConfig } from './config';
-import { isSpecifiedScalarName } from './graphql';
 
 export class Visitor extends TsVisitor {
   constructor(
     private schema: GraphQLSchema,
-    private pluginConfig: ValidationSchemaPluginConfig
+    pluginConfig: ValidationSchemaPluginConfig
   ) {
     super(schema, pluginConfig);
   }
 
-  public getType(name: string) {
-    return this.schema.getType(name);
-  }
+  public getKind(graphQLTypeName: string) {
+    const foundType = this.schema.getType(graphQLTypeName);
+    if (!foundType) {
+      throw new Error(`type ${graphQLTypeName} not found in schema`);
+    }
 
-  public getNameNodeConverter(node: NameNode) {
-    const typ = this.schema.getType(node.value);
-    const astNode = typ?.astNode;
-    if (astNode === undefined || astNode === null) {
-      return undefined;
+    // String 等の組み込みの scalar の場合、 astNode がない
+    if (!foundType.astNode) {
+      return null;
     }
-    return {
-      targetKind: astNode.kind,
-      convertName: () => this.convertName(astNode.name.value),
-    };
-  }
 
-  public getScalarType(scalarName: string, scalarDirection: keyof NormalizedScalarsMap[string]): string | null {
-    return this.scalars[scalarName][scalarDirection];
+    const kind = foundType.astNode.kind;
+    assertsNotInterface(kind);
+
+    return kind;
   }
 
-  public shouldEmitAsNotAllowEmptyString(name: string, scalarDirection: keyof NormalizedScalarsMap[string]): boolean {
-    if (this.pluginConfig.notAllowEmptyString !== true) {
-      return false;
-    }
-    const typ = this.getType(name);
-    if (typ?.astNode?.kind !== 'ScalarTypeDefinition' && !isSpecifiedScalarName(name)) {
-      return false;
-    }
-    const tsType = this.getScalarType(name, scalarDirection);
-    return tsType === 'string';
+  public getTypeScriptScalarType(
+    graphQLTypeName: string,
+    scalarDirection: keyof NormalizedScalarsMap[string]
+  ): string | null {
+    return this.scalars[graphQLTypeName]?.[scalarDirection] ?? null;
   }
+}
 
-  public buildArgumentsSchemaBlock(
-    node: ObjectTypeDefinitionNode,
-    callback: (typeName: string, field: FieldDefinitionNode) => string
-  ) {
-    const fieldsWithArguments = node.fields?.filter(field => field.arguments && field.arguments.length > 0) ?? [];
-    if (fieldsWithArguments.length === 0) {
-      return undefined;
-    }
-    return fieldsWithArguments
-      .map(field => {
-        const name =
-          node.name.value +
-          (this.config.addUnderscoreToArgsType ? '_' : '') +
-          this.convertName(field, {
-            useTypesPrefix: false,
-            useTypesSuffix: false,
-          }) +
-          'Args';
+/**
+ * String 等の組み込みの scalar の場合は null
+ */
+export type GetKindResult = ReturnType<Visitor['getKind']>;
 
-        return callback(name, field);
-      })
-      .join('\n');
+function assertsNotInterface<TKind extends Kind>(
+  kind: TKind
+): asserts kind is Exclude<TKind, Kind.INTERFACE_TYPE_DEFINITION> {
+  if (kind === Kind.INTERFACE_TYPE_DEFINITION) {
+    throw new Error(`unexpected kind: ${kind}`);
   }
 }